All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	srivatsa.bhat-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/8] cgroup: add cgroup->id
Date: Tue, 20 Nov 2012 16:11:38 +0900	[thread overview]
Message-ID: <50AB2D2A.1040604@jp.fujitsu.com> (raw)
In-Reply-To: <20121120070851.GG25790-9pTldWuhBndy/B6EtB590w@public.gmane.org>

(2012/11/20 16:08), Tejun Heo wrote:
> Hello, Kamezawa.
>
> On Tue, Nov 20, 2012 at 04:05:51PM +0900, Kamezawa Hiroyuki wrote:
>> BTW, css's ID was limited to 65535 to be encoded in 2bytes.
>> If we use INT, this will increase size of swap_cgroup.
>> (2bytes per page => 4bytes per page) It's preallocated at swapon()
>> because allocating memory dynamically when we swap a memory is not good.
>>
>> Do we really need 4bytes for ID ? If so, swap_cgroup should be totally re-designed.
>
> That's a memcg restriction which shouldn't have been imposed on cgroup
> core from the beginning.  What memcg should do is rejecting to become
> online from ->css_onilne() if cgrp->id is out of the range it can
> handle.
>

Hmm. I'll think a little and consider a patch to remove memcg's refcnt.


Thanks,
-Kame

WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Tejun Heo <tj@kernel.org>
Cc: daniel.wagner@bmw-carit.de, srivatsa.bhat@linux.vnet.ibm.com,
	john.r.fastabend@intel.com, nhorman@tuxdriver.com,
	lizefan@huawei.com, containers@lists.linux-foundation.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] cgroup: add cgroup->id
Date: Tue, 20 Nov 2012 16:11:38 +0900	[thread overview]
Message-ID: <50AB2D2A.1040604@jp.fujitsu.com> (raw)
In-Reply-To: <20121120070851.GG25790@mtj.dyndns.org>

(2012/11/20 16:08), Tejun Heo wrote:
> Hello, Kamezawa.
>
> On Tue, Nov 20, 2012 at 04:05:51PM +0900, Kamezawa Hiroyuki wrote:
>> BTW, css's ID was limited to 65535 to be encoded in 2bytes.
>> If we use INT, this will increase size of swap_cgroup.
>> (2bytes per page => 4bytes per page) It's preallocated at swapon()
>> because allocating memory dynamically when we swap a memory is not good.
>>
>> Do we really need 4bytes for ID ? If so, swap_cgroup should be totally re-designed.
>
> That's a memcg restriction which shouldn't have been imposed on cgroup
> core from the beginning.  What memcg should do is rejecting to become
> online from ->css_onilne() if cgrp->id is out of the range it can
> handle.
>

Hmm. I'll think a little and consider a patch to remove memcg's refcnt.


Thanks,
-Kame


  parent reply	other threads:[~2012-11-20  7:11 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 19:20 [PATCHSET cgroup/for-3.8] netprio_cgroup: implement hierarchy support Tejun Heo
2012-11-16 19:20 ` Tejun Heo
     [not found] ` <1353093624-22608-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-16 19:20   ` [PATCH 1/8] cgroup: add cgroup->id Tejun Heo
2012-11-16 19:20     ` Tejun Heo
     [not found]     ` <1353093624-22608-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-19  9:03       ` Li Zefan
2012-11-19  9:03         ` Li Zefan
     [not found]         ` <50A9F5F3.3050907-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-11-19 17:05           ` Tejun Heo
2012-11-19 17:05             ` Tejun Heo
2012-11-19  9:03       ` Li Zefan
2012-11-20  4:34       ` Kamezawa Hiroyuki
2012-11-20  4:34         ` Kamezawa Hiroyuki
     [not found]         ` <50AB086E.70901-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-11-20  5:31           ` Tejun Heo
2012-11-20  5:31             ` Tejun Heo
     [not found]             ` <20121120053112.GE25790-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-11-20  7:05               ` Kamezawa Hiroyuki
2012-11-20  7:05                 ` Kamezawa Hiroyuki
2012-11-20  8:20                 ` Glauber Costa
2012-11-20  8:20                   ` Glauber Costa
     [not found]                 ` <50AB2BCF.2050204-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-11-20  7:08                   ` Tejun Heo
2012-11-20  7:08                   ` Tejun Heo
2012-11-20  7:08                     ` Tejun Heo
     [not found]                     ` <20121120070851.GG25790-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-11-20  7:11                       ` Kamezawa Hiroyuki [this message]
2012-11-20  7:11                         ` Kamezawa Hiroyuki
2012-11-20  8:20                   ` Glauber Costa
2012-11-20  5:31           ` Tejun Heo
2012-11-16 19:20   ` [PATCH 2/8] netprio: simplify write_priomap() Tejun Heo
2012-11-16 19:20     ` Tejun Heo
2012-11-16 19:20   ` [PATCH 3/8] netprio_cgroup: shorten variable names in extend_netdev_table() Tejun Heo
2012-11-16 19:20     ` Tejun Heo
2012-11-16 19:20   ` [PATCH 4/8] netprio_cgroup: reimplement priomap expansion Tejun Heo
2012-11-16 19:20     ` Tejun Heo
2012-11-16 19:20   ` [PATCH 5/8] netprio_cgroup: use cgroup->id instead of cgroup_netprio_state->prioidx Tejun Heo
2012-11-16 19:20     ` Tejun Heo
2012-11-16 19:20   ` [PATCH 6/8] netprio_cgroup: implement netprio[_set]_prio() helpers Tejun Heo
2012-11-16 19:20     ` Tejun Heo
2012-11-16 19:20   ` [PATCH 7/8] netprio_cgroup: keep track of whether prio is set or not Tejun Heo
2012-11-16 19:20   ` [PATCH 8/8] netprio_cgroup: implement hierarchy support Tejun Heo
2012-11-16 19:20     ` Tejun Heo
2012-11-16 19:20   ` Tejun Heo
2012-11-19 13:25   ` [PATCHSET cgroup/for-3.8] " Neil Horman
2012-11-19 13:25     ` Neil Horman
2012-11-19 19:25   ` Daniel Wagner
2012-11-19 19:25     ` Daniel Wagner
     [not found]     ` <50AA87BD.1040106-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-11-19 19:54       ` Daniel Wagner
2012-11-19 19:54       ` Daniel Wagner
2012-11-19 19:54         ` Daniel Wagner
2012-11-19 19:25   ` Daniel Wagner
2012-11-16 19:20 ` [PATCH 7/8] netprio_cgroup: keep track of whether prio is set or not Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AB2D2A.1040604@jp.fujitsu.com \
    --to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org \
    --cc=john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    --cc=srivatsa.bhat-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.