All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] net: mvneta: adjust multiline comments to net/ style
Date: Tue, 20 Nov 2012 15:22:03 +0400	[thread overview]
Message-ID: <50AB67DB.3030309@mvista.com> (raw)
In-Reply-To: <20121119135609.3808b1c7@skate>

Hello.

On 19-11-2012 16:56, Thomas Petazzoni wrote:

>>> -/*
>>> - * The two bytes Marvell header. Either contains a special value used
>>> +/* The two bytes Marvell header. Either contains a special value used
>>
>>      Why the heck you're doing this? It's the preferred style, see
>> Documentation/CodingStyle, chapter 8.

> No. Please read Documentation/CodingStyle, chapter 8 entirely:

> ===============================================================
> The preferred style for long (multi-line) comments is:
>
>          /*
>           * This is the preferred style for multi-line
>           * comments in the Linux kernel source code.
>           * Please use it consistently.
>           *
>           * Description:  A column of asterisks on the left side,
>           * with beginning and ending almost-blank lines.
>           */
>
> For files in net/ and drivers/net/ the preferred style for long
> (multi-line) comments is a little different.
>
>          /* The preferred comment style for files in net/ and drivers/net
>           * looks like this.
>           *
>           * It is nearly the same as the generally preferred comment style,
>           * but there is no initial almost-blank line.
>           */
> ===============================================================

> Seen the second part?

    Not until now probably. Sorry for the noise then. :-/

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
	Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
	netdev@vger.kernel.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] net: mvneta: adjust multiline comments to net/ style
Date: Tue, 20 Nov 2012 15:22:03 +0400	[thread overview]
Message-ID: <50AB67DB.3030309@mvista.com> (raw)
In-Reply-To: <20121119135609.3808b1c7@skate>

Hello.

On 19-11-2012 16:56, Thomas Petazzoni wrote:

>>> -/*
>>> - * The two bytes Marvell header. Either contains a special value used
>>> +/* The two bytes Marvell header. Either contains a special value used
>>
>>      Why the heck you're doing this? It's the preferred style, see
>> Documentation/CodingStyle, chapter 8.

> No. Please read Documentation/CodingStyle, chapter 8 entirely:

> ===============================================================
> The preferred style for long (multi-line) comments is:
>
>          /*
>           * This is the preferred style for multi-line
>           * comments in the Linux kernel source code.
>           * Please use it consistently.
>           *
>           * Description:  A column of asterisks on the left side,
>           * with beginning and ending almost-blank lines.
>           */
>
> For files in net/ and drivers/net/ the preferred style for long
> (multi-line) comments is a little different.
>
>          /* The preferred comment style for files in net/ and drivers/net
>           * looks like this.
>           *
>           * It is nearly the same as the generally preferred comment style,
>           * but there is no initial almost-blank line.
>           */
> ===============================================================

> Seen the second part?

    Not until now probably. Sorry for the noise then. :-/

WBR, Sergei

  reply	other threads:[~2012-11-20 11:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 11:00 [GIT PULL] Marvell mvneta Ethernet/MDIO drivers checkpatch fixes Thomas Petazzoni
2012-11-19 11:00 ` Thomas Petazzoni
2012-11-19 11:00 ` [PATCH 1/3] net: mvmdio: use <linux/delay.h> instead of <asm/delay.h> Thomas Petazzoni
2012-11-19 11:00   ` Thomas Petazzoni
2012-11-19 11:00 ` [PATCH 2/3] net: mvmdio: adjust multiline comment to net/ style Thomas Petazzoni
2012-11-19 11:00   ` Thomas Petazzoni
2012-11-19 11:00 ` [PATCH 3/3] net: mvneta: adjust multiline comments " Thomas Petazzoni
2012-11-19 11:00   ` Thomas Petazzoni
2012-11-19 12:49   ` Sergei Shtylyov
2012-11-19 12:49     ` Sergei Shtylyov
2012-11-19 12:56     ` Thomas Petazzoni
2012-11-19 12:56       ` Thomas Petazzoni
2012-11-20 11:22       ` Sergei Shtylyov [this message]
2012-11-20 11:22         ` Sergei Shtylyov
2012-11-19 19:01     ` David Miller
2012-11-19 19:01       ` David Miller
2012-11-19 19:16 ` [GIT PULL] Marvell mvneta Ethernet/MDIO drivers checkpatch fixes David Miller
2012-11-19 19:16   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AB67DB.3030309@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.