All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: linux-crypto@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.hengli.com.au>, Sonic.Zhang@analog.com
Subject: Tcrypt  hmac(crc32) test can work only on Blackfin
Date: Tue, 20 Nov 2012 15:03:31 +0100	[thread overview]
Message-ID: <50AB8DB3.6040008@redhat.com> (raw)

Hi,

commit a482b081a2d4d74d16bc9ea8779f9f6055f95852
Author: Sonic Zhang <sonic.zhang@analog.com>
Date:   Fri May 25 17:54:13 2012 +0800
    crypto: testmgr - Add new test cases for Blackfin CRC crypto driver

added tcrypt mode=110 test for hmac(crc32)

It seems, that this mode is only directly implemented by Blackfin
driver and must fail on all other architectures because:

- nobody implements "crc32" but "crc32c"

- the block size is 1 and digest size is 4 for crc32[c], so
hmac(crc32c) must fail because ds > block_size (test in hmac_create)

And it doesn't fail here because you implement it directly and
not using hmac.c...

Just try modprobe tcrypt mode=110 on so other arch
  alg: hash: Failed to load transform for hmac(crc32): -2

Why was such one-device dependent test vector added?

IMHO either it should provide crc32c (as do generic, sparc or x86 hw drivers)
or the block size for crc32c should be 4... (and test vector is wrong then)

But now we have test vector which must fail for most of systems.

Milan

             reply	other threads:[~2012-11-20 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 14:03 Milan Broz [this message]
2012-11-21 11:29 ` Tcrypt hmac(crc32) test can work only on Blackfin Zhang, Sonic
2012-11-21 12:01   ` Milan Broz
2012-11-22  2:33     ` Herbert Xu
2012-11-22  8:38       ` Zhang, Sonic
2012-12-06  9:07         ` Herbert Xu
2012-12-06  9:58           ` Zhang, Sonic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AB8DB3.6040008@redhat.com \
    --to=mbroz@redhat.com \
    --cc=Sonic.Zhang@analog.com \
    --cc=herbert@gondor.hengli.com.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.