From: Milan Broz <mbroz@redhat.com>
To: "Zhang, Sonic" <Sonic.Zhang@analog.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.hengli.com.au>
Subject: Re: Tcrypt hmac(crc32) test can work only on Blackfin
Date: Wed, 21 Nov 2012 13:01:49 +0100 [thread overview]
Message-ID: <50ACC2AD.2060100@redhat.com> (raw)
In-Reply-To: <DB904C5425BA6F4E8424B3B51A1414D173F34B2A37@NWD2CMBX1.ad.analog.com>
On 11/21/2012 12:29 PM, Zhang, Sonic wrote:
> Is there a policy that the CRC test vector
> in testmgr.h should support all CRC drivers?
> If so, I am fine to drop this test vector.
Question for Herbert...
But the problem I see is that it confuses people, it simply
returns fail everytime (except Blackfin platform).
My mail originates from bug report "tcrypt tests started failing",
and it was not obvious why (for people not familiar with tcrypt
internals, they just tried all test modes available).
>> IMHO either it should provide crc32c (as do generic, sparc or x86 hw drivers) or
>> the block size for crc32c should be 4... (and test vector is wrong then)
>>
>
> I can set the default polynomials to that of crc32c for blackfin crc32 driver.
> But, it should not be limited to crc32c.
Sure, my question was just about test vector, hw driver support
for something more is of course good thing.
But it would be nice to have "crc32c" directly supported/accelerated as well.
Thanks,
Milan
next prev parent reply other threads:[~2012-11-21 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 14:03 Tcrypt hmac(crc32) test can work only on Blackfin Milan Broz
2012-11-21 11:29 ` Zhang, Sonic
2012-11-21 12:01 ` Milan Broz [this message]
2012-11-22 2:33 ` Herbert Xu
2012-11-22 8:38 ` Zhang, Sonic
2012-12-06 9:07 ` Herbert Xu
2012-12-06 9:58 ` Zhang, Sonic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ACC2AD.2060100@redhat.com \
--to=mbroz@redhat.com \
--cc=Sonic.Zhang@analog.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.