* [PATCH 4/7] gpiolib: return any error code from range creation
@ 2012-11-20 14:04 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-20 14:04 UTC (permalink / raw)
To: linux-arm-kernel
From: Linus Walleij <linus.walleij@linaro.org>
If we try to create a range for a certain GPIO chip and the
target pin controller is not yet available it may return
a probe deferral error code, so handle this all the way
our by checking the error code.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpiolib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index a59d13d..317ff04 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1218,10 +1218,11 @@ int gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name,
pin_range->range.npins = npins;
pin_range->pctldev = pinctrl_find_and_add_gpio_range(pinctl_name,
&pin_range->range);
- if (!pin_range->pctldev) {
+ if (IS_ERR(pin_range->pctldev)) {
pr_err("%s: GPIO chip: could not create pin range\n",
chip->label);
kfree(pin_range);
+ return PTR_ERR(pin_range->pctldev);
}
pr_debug("%s: GPIO chip: created GPIO range %d->%d ==> PIN %d->%d\n",
chip->label, offset, offset + npins - 1,
--
1.7.11.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/7] gpiolib: return any error code from range creation
@ 2012-11-20 14:04 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-20 14:04 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel, Shiraz Hashim, Viresh Kumar
Cc: Stephen Warren, Anmar Oueja, Grant Likely, Linus Walleij
From: Linus Walleij <linus.walleij@linaro.org>
If we try to create a range for a certain GPIO chip and the
target pin controller is not yet available it may return
a probe deferral error code, so handle this all the way
our by checking the error code.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpiolib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index a59d13d..317ff04 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1218,10 +1218,11 @@ int gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name,
pin_range->range.npins = npins;
pin_range->pctldev = pinctrl_find_and_add_gpio_range(pinctl_name,
&pin_range->range);
- if (!pin_range->pctldev) {
+ if (IS_ERR(pin_range->pctldev)) {
pr_err("%s: GPIO chip: could not create pin range\n",
chip->label);
kfree(pin_range);
+ return PTR_ERR(pin_range->pctldev);
}
pr_debug("%s: GPIO chip: created GPIO range %d->%d ==> PIN %d->%d\n",
chip->label, offset, offset + npins - 1,
--
1.7.11.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/7] gpiolib: return any error code from range creation
2012-11-20 14:04 ` Linus Walleij
@ 2012-11-20 17:28 ` Stephen Warren
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2012-11-20 17:28 UTC (permalink / raw)
To: linux-arm-kernel
On 11/20/2012 07:04 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> If we try to create a range for a certain GPIO chip and the
> target pin controller is not yet available it may return
> a probe deferral error code, so handle this all the way
> our by checking the error code.
I think patches 3 and 4 need to be squashed together to avoid any "git
bisect" issues?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/7] gpiolib: return any error code from range creation
@ 2012-11-20 17:28 ` Stephen Warren
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2012-11-20 17:28 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel, linux-arm-kernel, Shiraz Hashim, Viresh Kumar,
Stephen Warren, Anmar Oueja, Grant Likely, Linus Walleij
On 11/20/2012 07:04 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> If we try to create a range for a certain GPIO chip and the
> target pin controller is not yet available it may return
> a probe deferral error code, so handle this all the way
> our by checking the error code.
I think patches 3 and 4 need to be squashed together to avoid any "git
bisect" issues?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/7] gpiolib: return any error code from range creation
2012-11-20 17:28 ` Stephen Warren
@ 2012-11-21 7:54 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-21 7:54 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 20, 2012 at 6:28 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 11/20/2012 07:04 AM, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@linaro.org>
>>
>> If we try to create a range for a certain GPIO chip and the
>> target pin controller is not yet available it may return
>> a probe deferral error code, so handle this all the way
>> our by checking the error code.
>
> I think patches 3 and 4 need to be squashed together to avoid any "git
> bisect" issues?
OK that's correct I'll fix...
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/7] gpiolib: return any error code from range creation
@ 2012-11-21 7:54 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-21 7:54 UTC (permalink / raw)
To: Stephen Warren
Cc: Linus Walleij, linux-kernel, linux-arm-kernel, Shiraz Hashim,
Viresh Kumar, Stephen Warren, Anmar Oueja, Grant Likely
On Tue, Nov 20, 2012 at 6:28 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 11/20/2012 07:04 AM, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@linaro.org>
>>
>> If we try to create a range for a certain GPIO chip and the
>> target pin controller is not yet available it may return
>> a probe deferral error code, so handle this all the way
>> our by checking the error code.
>
> I think patches 3 and 4 need to be squashed together to avoid any "git
> bisect" issues?
OK that's correct I'll fix...
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-21 7:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20 14:04 [PATCH 4/7] gpiolib: return any error code from range creation Linus Walleij
2012-11-20 14:04 ` Linus Walleij
2012-11-20 17:28 ` Stephen Warren
2012-11-20 17:28 ` Stephen Warren
2012-11-21 7:54 ` Linus Walleij
2012-11-21 7:54 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.