All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: habanero@linux.vnet.ibm.com
Cc: Ingo Molnar <mingo@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Mel Gorman <mgorman@suse.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Turner <pjt@google.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	Christoph Lameter <cl@linux.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Hugh Dickins <hughd@google.com>
Subject: Re: numa/core regressions fixed - more testers wanted
Date: Tue, 20 Nov 2012 22:22:58 -0500	[thread overview]
Message-ID: <50AC4912.7040503@redhat.com> (raw)
In-Reply-To: <1353462853.31820.93.camel@oc6622382223.ibm.com>

On 11/20/2012 08:54 PM, Andrew Theurer wrote:

> I can confirm single JVM JBB is working well for me.  I see a 30%
> improvement over autoNUMA.  What I can't make sense of is some perf
> stats (taken at 80 warehouses on 4 x WST-EX, 512GB memory):

AutoNUMA does not have native THP migration, that may explain some
of the difference.

> tips numa/core:
>
>       5,429,632,865 node-loads
>       3,806,419,082 node-load-misses(70.1%)
>       2,486,756,884 node-stores
>       2,042,557,277 node-store-misses(82.1%)
>       2,878,655,372 node-prefetches
>       2,201,441,900 node-prefetch-misses
>
> autoNUMA:
>
>       4,538,975,144 node-loads
>       2,666,374,830 node-load-misses(58.7%)
>       2,148,950,354 node-stores
>       1,682,942,931 node-store-misses(78.3%)
>       2,191,139,475 node-prefetches
>       1,633,752,109 node-prefetch-misses
>
> The percentage of misses is higher for numa/core.  I would have expected
> the performance increase be due to lower "node-misses", but perhaps I am
> misinterpreting the perf data.

Lack of native THP migration may be enough to explain the
performance difference, despite autonuma having better node
locality.

>> Next I'll work on making multi-JVM more of an improvement, and
>> I'll also address any incoming regression reports.
>
> I have issues with multiple KVM VMs running either JBB or
> dbench-in-tmpfs, and I suspect whatever I am seeing is similar to
> whatever multi-jvm in baremetal is.  What I typically see is no real
> convergence of a single node for resource usage for any of the VMs.  For
> example, when running 8 VMs, 10 vCPUs each, a VM may have the following
> resource usage:

This is an issue.  I have tried understanding the new local/shared
and shared task grouping code, but have not wrapped my mind around
that code yet.

I will have to look at that code a few more times, and ask more
questions of Ingo and Peter (and maybe ask some of the same questions
again - I see that some of my comments were addressed in the next
version of the patch, but the email never got a reply).

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: habanero@linux.vnet.ibm.com
Cc: Ingo Molnar <mingo@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Mel Gorman <mgorman@suse.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Turner <pjt@google.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	Christoph Lameter <cl@linux.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Hugh Dickins <hughd@google.com>
Subject: Re: numa/core regressions fixed - more testers wanted
Date: Tue, 20 Nov 2012 22:22:58 -0500	[thread overview]
Message-ID: <50AC4912.7040503@redhat.com> (raw)
In-Reply-To: <1353462853.31820.93.camel@oc6622382223.ibm.com>

On 11/20/2012 08:54 PM, Andrew Theurer wrote:

> I can confirm single JVM JBB is working well for me.  I see a 30%
> improvement over autoNUMA.  What I can't make sense of is some perf
> stats (taken at 80 warehouses on 4 x WST-EX, 512GB memory):

AutoNUMA does not have native THP migration, that may explain some
of the difference.

> tips numa/core:
>
>       5,429,632,865 node-loads
>       3,806,419,082 node-load-misses(70.1%)
>       2,486,756,884 node-stores
>       2,042,557,277 node-store-misses(82.1%)
>       2,878,655,372 node-prefetches
>       2,201,441,900 node-prefetch-misses
>
> autoNUMA:
>
>       4,538,975,144 node-loads
>       2,666,374,830 node-load-misses(58.7%)
>       2,148,950,354 node-stores
>       1,682,942,931 node-store-misses(78.3%)
>       2,191,139,475 node-prefetches
>       1,633,752,109 node-prefetch-misses
>
> The percentage of misses is higher for numa/core.  I would have expected
> the performance increase be due to lower "node-misses", but perhaps I am
> misinterpreting the perf data.

Lack of native THP migration may be enough to explain the
performance difference, despite autonuma having better node
locality.

>> Next I'll work on making multi-JVM more of an improvement, and
>> I'll also address any incoming regression reports.
>
> I have issues with multiple KVM VMs running either JBB or
> dbench-in-tmpfs, and I suspect whatever I am seeing is similar to
> whatever multi-jvm in baremetal is.  What I typically see is no real
> convergence of a single node for resource usage for any of the VMs.  For
> example, when running 8 VMs, 10 vCPUs each, a VM may have the following
> resource usage:

This is an issue.  I have tried understanding the new local/shared
and shared task grouping code, but have not wrapped my mind around
that code yet.

I will have to look at that code a few more times, and ask more
questions of Ingo and Peter (and maybe ask some of the same questions
again - I see that some of my comments were addressed in the next
version of the patch, but the email never got a reply).

-- 
All rights reversed

  reply	other threads:[~2012-11-21  3:23 UTC|newest]

Thread overview: 204+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19  2:14 [PATCH 00/27] Latest numa/core release, v16 Ingo Molnar
2012-11-19  2:14 ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 01/27] mm/generic: Only flush the local TLB in ptep_set_access_flags() Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 02/27] x86/mm: Only do a local tlb flush " Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 03/27] x86/mm: Introduce pte_accessible() Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 04/27] mm: Only flush the TLB when clearing an accessible pte Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 05/27] x86/mm: Completely drop the TLB flush from ptep_set_access_flags() Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 06/27] mm: Count the number of pages affected in change_protection() Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 07/27] mm: Optimize the TLB flush of sys_mprotect() and change_protection() users Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 08/27] sched, numa, mm: Add last_cpu to page flags Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 09/27] sched, mm, numa: Create generic NUMA fault infrastructure, with architectures overrides Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 10/27] sched: Make find_busiest_queue() a method Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 11/27] sched, numa, mm: Describe the NUMA scheduling problem formally Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 12/27] numa, mm: Support NUMA hinting page faults from gup/gup_fast Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 13/27] mm/migrate: Introduce migrate_misplaced_page() Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 14/27] sched, numa, mm, arch: Add variable locality exception Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 15/27] sched, numa, mm: Add credits for NUMA placement Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 16/27] sched, mm, x86: Add the ARCH_SUPPORTS_NUMA_BALANCING flag Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 17/27] sched, numa, mm: Add the scanning page fault machinery Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 18/27] sched: Add adaptive NUMA affinity support Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 19/27] sched: Implement constant, per task Working Set Sampling (WSS) rate Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 20/27] sched, numa, mm: Count WS scanning against present PTEs, not virtual memory ranges Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 21/27] sched: Implement slow start for working set sampling Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 22/27] sched, numa, mm: Interleave shared tasks Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 23/27] sched: Implement NUMA scanning backoff Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 24/27] sched: Improve convergence Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 25/27] sched: Introduce staged average NUMA faults Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 26/27] sched: Track groups of shared tasks Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19  2:14 ` [PATCH 27/27] sched: Use the best-buddy 'ideal cpu' in balancing decisions Ingo Molnar
2012-11-19  2:14   ` Ingo Molnar
2012-11-19 16:29 ` [PATCH 00/27] Latest numa/core release, v16 Mel Gorman
2012-11-19 16:29   ` Mel Gorman
2012-11-19 19:13   ` Ingo Molnar
2012-11-19 19:13     ` Ingo Molnar
2012-11-19 21:18     ` Mel Gorman
2012-11-19 21:18       ` Mel Gorman
2012-11-19 22:36       ` Ingo Molnar
2012-11-19 22:36         ` Ingo Molnar
2012-11-19 23:00         ` Mel Gorman
2012-11-19 23:00           ` Mel Gorman
2012-11-20  0:41           ` Rik van Riel
2012-11-20  0:41             ` Rik van Riel
2012-11-21 10:58             ` Mel Gorman
2012-11-21 10:58               ` Mel Gorman
2012-11-20  1:02         ` Linus Torvalds
2012-11-20  1:02           ` Linus Torvalds
2012-11-20  7:17           ` Ingo Molnar
2012-11-20  7:17             ` Ingo Molnar
2012-11-20  7:37             ` David Rientjes
2012-11-20  7:37               ` David Rientjes
2012-11-20  7:48               ` Ingo Molnar
2012-11-20  7:48                 ` Ingo Molnar
2012-11-20  8:01               ` Ingo Molnar
2012-11-20  8:01                 ` Ingo Molnar
2012-11-20  8:11                 ` David Rientjes
2012-11-20  8:11                   ` David Rientjes
2012-11-21 11:14               ` Mel Gorman
2012-11-21 11:14                 ` Mel Gorman
2012-11-20 10:20             ` Mel Gorman
2012-11-20 10:20               ` Mel Gorman
2012-11-20 10:47               ` Mel Gorman
2012-11-20 10:47                 ` Mel Gorman
2012-11-20 15:29             ` [PATCH] mm, numa: Turn 4K pte NUMA faults into effective hugepage ones Ingo Molnar
2012-11-20 15:29               ` Ingo Molnar
2012-11-20 16:09               ` [PATCH, v2] " Ingo Molnar
2012-11-20 16:09                 ` Ingo Molnar
2012-11-20 16:31                 ` Rik van Riel
2012-11-20 16:31                   ` Rik van Riel
2012-11-20 16:52                   ` Ingo Molnar
2012-11-20 16:52                     ` Ingo Molnar
2012-11-21 12:08                     ` Mel Gorman
2012-11-21 12:08                       ` Mel Gorman
2012-11-21  8:12                   ` Ingo Molnar
2012-11-21  8:12                     ` Ingo Molnar
2012-11-21  2:41                 ` David Rientjes
2012-11-21  2:41                   ` David Rientjes
2012-11-21  9:34                   ` Ingo Molnar
2012-11-21  9:34                     ` Ingo Molnar
2012-11-21 11:40                 ` Mel Gorman
2012-11-21 11:40                   ` Mel Gorman
2012-11-23  1:26                 ` Alex Shi
2012-11-23  1:26                   ` Alex Shi
2012-11-20 17:56               ` numa/core regressions fixed - more testers wanted Ingo Molnar
2012-11-20 17:56                 ` Ingo Molnar
2012-11-21  1:54                 ` Andrew Theurer
2012-11-21  1:54                   ` Andrew Theurer
2012-11-21  3:22                   ` Rik van Riel [this message]
2012-11-21  3:22                     ` Rik van Riel
2012-11-21  4:10                     ` Hugh Dickins
2012-11-21  4:10                       ` Hugh Dickins
2012-11-21 12:45                       ` Hillf Danton
2012-11-21 17:59                       ` Andrew Theurer
2012-11-21 17:59                         ` Andrew Theurer
2012-11-21 11:52                   ` Mel Gorman
2012-11-21 11:52                     ` Mel Gorman
2012-11-21 22:15                     ` Andrew Theurer
2012-11-21 22:15                       ` Andrew Theurer
2012-11-21  3:33                 ` David Rientjes
2012-11-21  3:33                   ` David Rientjes
2012-11-21  9:38                   ` Ingo Molnar
2012-11-21  9:38                     ` Ingo Molnar
2012-11-21 11:06                   ` Ingo Molnar
2012-11-21 11:06                     ` Ingo Molnar
2012-11-21  8:39                 ` Alex Shi
2012-11-21  8:39                   ` Alex Shi
2012-11-22  1:21                   ` Ingo Molnar
2012-11-22  1:21                     ` Ingo Molnar
2012-11-23 13:31                     ` Ingo Molnar
2012-11-23 13:31                       ` Ingo Molnar
2012-11-23 15:23                       ` Alex Shi
2012-11-23 15:23                         ` Alex Shi
2012-11-26  2:11                       ` Alex Shi
2012-11-26  2:11                         ` Alex Shi
2012-11-28 14:21                         ` Alex Shi
2012-11-28 14:21                           ` Alex Shi
2012-11-20 10:40         ` [PATCH 00/27] Latest numa/core release, v16 Ingo Molnar
2012-11-20 10:40           ` Ingo Molnar
2012-11-20 11:40           ` Mel Gorman
2012-11-20 11:40             ` Mel Gorman
2012-11-21 10:38     ` Mel Gorman
2012-11-21 10:38       ` Mel Gorman
2012-11-21 19:37       ` Andrea Arcangeli
2012-11-21 19:37         ` Andrea Arcangeli
2012-11-21 19:56         ` Mel Gorman
2012-11-21 19:56           ` Mel Gorman
2012-11-19 20:07   ` Ingo Molnar
2012-11-19 20:07     ` Ingo Molnar
2012-11-19 21:37     ` Mel Gorman
2012-11-19 21:37       ` Mel Gorman
2012-11-20  0:50   ` David Rientjes
2012-11-20  0:50     ` David Rientjes
2012-11-20  1:05     ` David Rientjes
2012-11-20  1:05       ` David Rientjes
2012-11-20  6:00       ` Ingo Molnar
2012-11-20  6:00         ` Ingo Molnar
2012-11-20  6:20         ` David Rientjes
2012-11-20  6:20           ` David Rientjes
2012-11-20  7:44           ` Ingo Molnar
2012-11-20  7:44             ` Ingo Molnar
2012-11-20  7:48             ` Paul Turner
2012-11-20  7:48               ` Paul Turner
2012-11-20  8:20             ` David Rientjes
2012-11-20  8:20               ` David Rientjes
2012-11-20  9:06               ` Ingo Molnar
2012-11-20  9:06                 ` Ingo Molnar
2012-11-20  9:41                 ` [patch] x86/vsyscall: Add Kconfig option to use native vsyscalls, switch to it Ingo Molnar
2012-11-20  9:41                   ` Ingo Molnar
2012-11-20 23:01                   ` Andy Lutomirski
2012-11-20 23:01                     ` Andy Lutomirski
2012-11-21  0:43                   ` David Rientjes
2012-11-21  0:43                     ` David Rientjes
2012-11-20 12:02                 ` [PATCH] x86/mm: Don't flush the TLB on #WP pmd fixups Ingo Molnar
2012-11-20 12:02                   ` Ingo Molnar
2012-11-20 12:31                   ` Ingo Molnar
2012-11-20 12:31                     ` Ingo Molnar
2012-11-21 11:47                     ` Mel Gorman
2012-11-21 11:47                       ` Mel Gorman
2012-11-21  1:22                   ` David Rientjes
2012-11-21  1:22                     ` David Rientjes
2012-11-22 23:22                   ` [tip:x86/mm] " tip-bot for Ingo Molnar
2012-11-21 17:02                 ` [PATCH 00/27] Latest numa/core release, v16 Linus Torvalds
2012-11-21 17:02                   ` Linus Torvalds
2012-11-21 17:10                   ` Ingo Molnar
2012-11-21 17:10                     ` Ingo Molnar
2012-11-21 17:20                     ` Ingo Molnar
2012-11-21 17:20                       ` Ingo Molnar
2012-11-22  4:31                       ` David Rientjes
2012-11-22  4:31                         ` David Rientjes
2012-11-21 17:40                     ` Ingo Molnar
2012-11-21 17:40                       ` Ingo Molnar
2012-11-21 22:04                     ` Linus Torvalds
2012-11-21 22:04                       ` Linus Torvalds
2012-11-21 22:46                       ` Ingo Molnar
2012-11-21 22:46                         ` Ingo Molnar
2012-11-21 17:45                   ` Rik van Riel
2012-11-21 17:45                     ` Rik van Riel
2012-11-21 18:04                   ` Ingo Molnar
2012-11-21 18:04                     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AC4912.7040503@redhat.com \
    --to=riel@redhat.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=habanero@linux.vnet.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=pjt@google.com \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.