All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"wg@grandegger.com" <wg@grandegger.com>,
	"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"Cousson, Benoit" <b-cousson@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>
Subject: Re: [PATCH v3] can: c_can: Add d_can raminit support
Date: Wed, 21 Nov 2012 11:12:53 +0100	[thread overview]
Message-ID: <50ACA925.60900@pengutronix.de> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA77E29@DBDE01.ent.ti.com>

[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]

On 11/21/2012 11:07 AM, AnilKumar, Chimata wrote:
> On Wed, Nov 21, 2012 at 15:01:22, Marc Kleine-Budde wrote:
>> From: AnilKumar Ch <anilkumar@ti.com>
>>
>> Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM,
>> which holds all the message objects during transmission or
>> receiving of data. This initialization/de-initialization should
>> be done in synchronous with D_CAN clock.
>>
>> In case of AM335X-EVM (current user of D_CAN driver) message RAM is
>> controlled through control module register for both instances. So
>> control module register details is required to initialization or
>> de-initialization of message RAM according to instance number.
>>
>> Control module memory resource is obtained from D_CAN dt node and
>> instance number obtained from device tree aliases node.
>>
>> This patch was tested on AM335x-EVM along with pinctrl data addition
>> patch, d_can dt aliases addition and control module data addition.
>> pinctrl data addition is not added to am335x-evm.dts (only supports
>> CPLD profile#0) because d_can1 is supported under CPLD profile#1.
>>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> [mkl: fix instance for non DT in probe, cleaned up raminit]
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> Hello,
>>
>> compile time tested only - please test on real HW.
> 
> Hi Marc,
> 
> I tested this patch, its working.

Tnx, pushed to linux-can-next/master

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] can: c_can: Add d_can raminit support
Date: Wed, 21 Nov 2012 11:12:53 +0100	[thread overview]
Message-ID: <50ACA925.60900@pengutronix.de> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA77E29@DBDE01.ent.ti.com>

On 11/21/2012 11:07 AM, AnilKumar, Chimata wrote:
> On Wed, Nov 21, 2012 at 15:01:22, Marc Kleine-Budde wrote:
>> From: AnilKumar Ch <anilkumar@ti.com>
>>
>> Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM,
>> which holds all the message objects during transmission or
>> receiving of data. This initialization/de-initialization should
>> be done in synchronous with D_CAN clock.
>>
>> In case of AM335X-EVM (current user of D_CAN driver) message RAM is
>> controlled through control module register for both instances. So
>> control module register details is required to initialization or
>> de-initialization of message RAM according to instance number.
>>
>> Control module memory resource is obtained from D_CAN dt node and
>> instance number obtained from device tree aliases node.
>>
>> This patch was tested on AM335x-EVM along with pinctrl data addition
>> patch, d_can dt aliases addition and control module data addition.
>> pinctrl data addition is not added to am335x-evm.dts (only supports
>> CPLD profile#0) because d_can1 is supported under CPLD profile#1.
>>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> [mkl: fix instance for non DT in probe, cleaned up raminit]
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> Hello,
>>
>> compile time tested only - please test on real HW.
> 
> Hi Marc,
> 
> I tested this patch, its working.

Tnx, pushed to linux-can-next/master

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121121/f29a9e0a/attachment-0001.sig>

  reply	other threads:[~2012-11-21 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  9:31 [PATCH v3] can: c_can: Add d_can raminit support Marc Kleine-Budde
2012-11-21  9:31 ` Marc Kleine-Budde
2012-11-21 10:07 ` AnilKumar, Chimata
2012-11-21 10:07   ` AnilKumar, Chimata
2012-11-21 10:12   ` Marc Kleine-Budde [this message]
2012-11-21 10:12     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ACA925.60900@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=anilkumar@ti.com \
    --cc=b-cousson@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.