From: Cyril Roelandt <tipecaml@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
lenb@kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] acpi_system_write_wakeup_device(): fix error check for unsigned variable.
Date: Thu, 22 Nov 2012 00:05:30 +0000 [thread overview]
Message-ID: <50AD6C4A.4030809@gmail.com> (raw)
In-Reply-To: <1732852.VDXGV3Ao2T@vostro.rjw.lan>
On 11/21/2012 01:44 AM, Rafael J. Wysocki wrote:
> On Saturday, November 17, 2012 02:54:23 AM Cyril Roelandt wrote:
>> The LEN variable is unsigned, therefore checking whether it is less than 0 is
>> useless.
>>
>> Signed-off-by: Cyril Roelandt<tipecaml@gmail.com>
>> ---
>> drivers/acpi/proc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
>> index 27adb09..37871a7 100644
>> --- a/drivers/acpi/proc.c
>> +++ b/drivers/acpi/proc.c
>> @@ -366,8 +366,6 @@ acpi_system_write_wakeup_device(struct file *file,
>>
>> if (len> 4)
>> len = 4;
>> - if (len< 0)
>> - return -EFAULT;
>
> I would prefer to check if count< 0 instead.
>
count has type size_t, so it is also an unsigned variable. I think that
acpi_system_write_wakeup_device really cannot be called with a "count"
parameter that is less than 0.
WBR,
Cyril Roelandt.
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Roelandt <tipecaml@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
lenb@kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] acpi_system_write_wakeup_device(): fix error check for unsigned variable.
Date: Thu, 22 Nov 2012 01:05:30 +0100 [thread overview]
Message-ID: <50AD6C4A.4030809@gmail.com> (raw)
In-Reply-To: <1732852.VDXGV3Ao2T@vostro.rjw.lan>
On 11/21/2012 01:44 AM, Rafael J. Wysocki wrote:
> On Saturday, November 17, 2012 02:54:23 AM Cyril Roelandt wrote:
>> The LEN variable is unsigned, therefore checking whether it is less than 0 is
>> useless.
>>
>> Signed-off-by: Cyril Roelandt<tipecaml@gmail.com>
>> ---
>> drivers/acpi/proc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
>> index 27adb09..37871a7 100644
>> --- a/drivers/acpi/proc.c
>> +++ b/drivers/acpi/proc.c
>> @@ -366,8 +366,6 @@ acpi_system_write_wakeup_device(struct file *file,
>>
>> if (len> 4)
>> len = 4;
>> - if (len< 0)
>> - return -EFAULT;
>
> I would prefer to check if count< 0 instead.
>
count has type size_t, so it is also an unsigned variable. I think that
acpi_system_write_wakeup_device really cannot be called with a "count"
parameter that is less than 0.
WBR,
Cyril Roelandt.
next prev parent reply other threads:[~2012-11-22 0:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 1:54 [PATCH] acpi_system_write_wakeup_device(): fix error check for unsigned variable Cyril Roelandt
2012-11-17 1:54 ` Cyril Roelandt
2012-11-21 0:44 ` Rafael J. Wysocki
2012-11-21 0:44 ` Rafael J. Wysocki
2012-11-22 0:05 ` Cyril Roelandt [this message]
2012-11-22 0:05 ` Cyril Roelandt
2012-11-22 0:23 ` Rafael J. Wysocki
2012-11-22 0:23 ` Rafael J. Wysocki
2012-11-22 0:30 ` Cyril Roelandt
2012-11-22 0:30 ` Cyril Roelandt
2012-11-22 0:34 ` [PATCH v2] " Cyril Roelandt
2012-11-22 0:34 ` Cyril Roelandt
2012-11-22 22:40 ` Rafael J. Wysocki
2012-11-22 22:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AD6C4A.4030809@gmail.com \
--to=tipecaml@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.