From: Tushar Behera <tushar.behera-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Shubhrajyoti Datta
<omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup
Date: Fri, 23 Nov 2012 12:14:50 +0530 [thread overview]
Message-ID: <50AF1B62.1000209@linaro.org> (raw)
In-Reply-To: <CAM=Q2cs=oYq4e17LXxUEhATiYLAjnzoTH-+nsO5KNQwGj2qSBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 11/23/2012 11:45 AM, Shubhrajyoti Datta wrote:
> On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera
> <tushar.behera-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> This patchset cleans up the probe function of i2c-s3c2410 driver.
>> These have been tested on Exynos4210 based Origen board.
>>
>> Tushar Behera (7):
>> i2c: s3c2410: Remove unnecessary label err_noclk
>> i2c: s3c2410: Convert to use devm_clk_get()
>> i2c: s3c2410: Convert to use devm_request_mem_region()
>> i2c: s3c2410: Convert to use devm_ioremap()
>> i2c: s3c2410: Convert to use devm_request_irq()
>
> You may want to consider request_and_ioremap.
>
Thanks. I will redo the patchset and submit again.
>
>> i2c: s3c2410: Move location of clk_prepare_enable() call in probe
>> function
>> i2c: s3c2410: Remove err_cpufreq label
>>
>> drivers/i2c/busses/i2c-s3c2410.c | 74 ++++++++++++--------------------------
>> 1 files changed, 23 insertions(+), 51 deletions(-)
>>
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
WARNING: multiple messages have this Message-ID (diff)
From: Tushar Behera <tushar.behera@linaro.org>
To: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, w.sang@pengutronix.de,
kgene.kim@samsung.com, patches@linaro.org
Subject: Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup
Date: Fri, 23 Nov 2012 12:14:50 +0530 [thread overview]
Message-ID: <50AF1B62.1000209@linaro.org> (raw)
In-Reply-To: <CAM=Q2cs=oYq4e17LXxUEhATiYLAjnzoTH-+nsO5KNQwGj2qSBA@mail.gmail.com>
On 11/23/2012 11:45 AM, Shubhrajyoti Datta wrote:
> On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera
> <tushar.behera@linaro.org> wrote:
>> This patchset cleans up the probe function of i2c-s3c2410 driver.
>> These have been tested on Exynos4210 based Origen board.
>>
>> Tushar Behera (7):
>> i2c: s3c2410: Remove unnecessary label err_noclk
>> i2c: s3c2410: Convert to use devm_clk_get()
>> i2c: s3c2410: Convert to use devm_request_mem_region()
>> i2c: s3c2410: Convert to use devm_ioremap()
>> i2c: s3c2410: Convert to use devm_request_irq()
>
> You may want to consider request_and_ioremap.
>
Thanks. I will redo the patchset and submit again.
>
>> i2c: s3c2410: Move location of clk_prepare_enable() call in probe
>> function
>> i2c: s3c2410: Remove err_cpufreq label
>>
>> drivers/i2c/busses/i2c-s3c2410.c | 74 ++++++++++++--------------------------
>> 1 files changed, 23 insertions(+), 51 deletions(-)
>>
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
next prev parent reply other threads:[~2012-11-23 6:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 5:59 [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup Tushar Behera
2012-11-23 5:59 ` [PATCH 1/7] i2c: s3c2410: Remove unnecessary label err_noclk Tushar Behera
2012-11-23 5:59 ` [PATCH 2/7] i2c: s3c2410: Convert to use devm_clk_get() Tushar Behera
[not found] ` <1353650353-17576-1-git-send-email-tushar.behera-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-11-23 5:59 ` [PATCH 3/7] i2c: s3c2410: Convert to use devm_request_mem_region() Tushar Behera
2012-11-23 5:59 ` Tushar Behera
2012-11-23 5:59 ` [PATCH 7/7] i2c: s3c2410: Remove err_cpufreq label Tushar Behera
2012-11-23 5:59 ` Tushar Behera
2012-11-23 6:15 ` [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup Shubhrajyoti Datta
2012-11-23 6:15 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cs=oYq4e17LXxUEhATiYLAjnzoTH-+nsO5KNQwGj2qSBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-23 6:44 ` Tushar Behera [this message]
2012-11-23 6:44 ` Tushar Behera
2012-11-23 5:59 ` [PATCH 4/7] i2c: s3c2410: Convert to use devm_ioremap() Tushar Behera
[not found] ` <1353650353-17576-5-git-send-email-tushar.behera-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-11-23 6:14 ` Sachin Kamat
2012-11-23 6:14 ` Sachin Kamat
2012-11-23 6:43 ` Tushar Behera
2012-11-23 5:59 ` [PATCH 5/7] i2c: s3c2410: Convert to use devm_request_irq() Tushar Behera
2012-11-23 5:59 ` [PATCH 6/7] i2c: s3c2410: Move location of clk_prepare_enable() call in probe function Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AF1B62.1000209@linaro.org \
--to=tushar.behera-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.