All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Zhang <markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding
	<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: Dave Airlie <airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH] drm: tegra: Use framebuffer pitch as line stride
Date: Mon, 26 Nov 2012 15:01:34 +0800	[thread overview]
Message-ID: <50B313CE.9090702@nvidia.com> (raw)
In-Reply-To: <1353613037-15808-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>

Tested-by: Mark Zhang <markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On my Tegra 3 cardhu.

Mark
On 11/23/2012 03:37 AM, Thierry Reding wrote:
> Instead of using the stride derived from the display mode, use the pitch
> associated with the currently active framebuffer. This fixes a bug where
> the LCD display content would be skewed when enabling HDMI with a video
> mode different from that of the LCD.
> 
> Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
> ---
>  drivers/gpu/drm/tegra/dc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index 94686e5..41cde76 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -218,7 +218,7 @@ static int tegra_crtc_mode_set(struct drm_crtc *crtc,
>  	}
>  
>  	bpp = crtc->fb->bits_per_pixel / 8;
> -	win.stride = win.outw * bpp;
> +	win.stride = crtc->fb->pitches[0];
>  
>  	/* program window registers */
>  	value = tegra_dc_readl(dc, DC_CMD_DISPLAY_WINDOW_HEADER);
> 

  parent reply	other threads:[~2012-11-26  7:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22 19:37 [PATCH] drm: tegra: Use framebuffer pitch as line stride Thierry Reding
     [not found] ` <1353613037-15808-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-11-23  5:54   ` Terje Bergström
2012-11-23  8:11   ` Terje Bergström
2012-11-26  7:01   ` Mark Zhang [this message]
2012-11-26 22:37   ` Stephen Warren
     [not found]     ` <50B3EF29.6000308-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-27  3:16       ` Mark Zhang
     [not found]         ` <50B43096.4060302-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-27 18:17           ` Stephen Warren
     [not found]             ` <50B503C5.6010208-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-27 21:39               ` Stephen Warren
     [not found]                 ` <50B53312.7040000-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-27 21:57                   ` Lucas Stach
2012-11-28  6:37                   ` Mark Zhang
     [not found]                     ` <50B5B120.1090902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-04  3:00                       ` Mark Zhang
     [not found]                         ` <50BD6753.20404-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-04  3:50                           ` Stephen Warren
     [not found]                             ` <50BD72EB.5010107-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-04  4:11                               ` Mark Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B313CE.9090702@nvidia.com \
    --to=markz-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
    --cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.