From: Len Brown <lenb@kernel.org>
To: Preeti Murthy <preeti.lkml@gmail.com>
Cc: Julius Werner <jwerner@chromium.org>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Kevin Hilman <khilman@ti.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>,
Trinabh Gupta <g.trinabh@gmail.com>,
Sameer Nanda <snanda@chromium.org>,
Lists Linaro-dev <linaro-dev@lists.linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock
Date: Tue, 27 Nov 2012 01:14:31 -0500 [thread overview]
Message-ID: <50B45A47.9050600@kernel.org> (raw)
In-Reply-To: <CAM4v1pPhaP=pVnFMXUU_nmrOxhY5yPNtbBdQsT5MH37MndK6LQ@mail.gmail.com>
On 11/15/2012 04:04 AM, Preeti Murthy wrote:
> Hi all,
>
> The code looks correct and inviting to me as it has led to good cleanups.
> I dont think passing 0 as the argument to the function
> sched_clock_idle_wakeup_event()
> should lead to problems,as it does not do anything useful with the
> passed arguments.
>
> My only curiosity is what was the purpose of passing idle residency time to
> sched_clock_idle_wakeup_event() when this data could always be retrieved from
> dev->last_residency for each cpu,which gets almost immediately updated.
sched_clock_idle_wakeup_event() is part of the scheduler.
The scheduler doesn't know what a cpuidle_device is, and
probably should not grow such a dependency.
cheers,
-Len Brown, Intel Open Source Technology Center
> But this does not seem to come in way of this patch for now.Anyway I
> have added Peter to
> the list so that he can opine about this issue if possible and needed.
>
> Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
>
>
> Regards
> Preeti U Murthy
>
WARNING: multiple messages have this Message-ID (diff)
From: Len Brown <lenb@kernel.org>
To: Preeti Murthy <preeti.lkml@gmail.com>
Cc: Kevin Hilman <khilman@ti.com>,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>,
Trinabh Gupta <g.trinabh@gmail.com>,
Lists Linaro-dev <linaro-dev@lists.linaro.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-pm@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-acpi@vger.kernel.org,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Julius Werner <jwerner@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Sameer Nanda <snanda@chromium.org>
Subject: Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock
Date: Tue, 27 Nov 2012 01:14:31 -0500 [thread overview]
Message-ID: <50B45A47.9050600@kernel.org> (raw)
In-Reply-To: <CAM4v1pPhaP=pVnFMXUU_nmrOxhY5yPNtbBdQsT5MH37MndK6LQ@mail.gmail.com>
On 11/15/2012 04:04 AM, Preeti Murthy wrote:
> Hi all,
>
> The code looks correct and inviting to me as it has led to good cleanups.
> I dont think passing 0 as the argument to the function
> sched_clock_idle_wakeup_event()
> should lead to problems,as it does not do anything useful with the
> passed arguments.
>
> My only curiosity is what was the purpose of passing idle residency time to
> sched_clock_idle_wakeup_event() when this data could always be retrieved from
> dev->last_residency for each cpu,which gets almost immediately updated.
sched_clock_idle_wakeup_event() is part of the scheduler.
The scheduler doesn't know what a cpuidle_device is, and
probably should not grow such a dependency.
cheers,
-Len Brown, Intel Open Source Technology Center
> But this does not seem to come in way of this patch for now.Anyway I
> have added Peter to
> the list so that he can opine about this issue if possible and needed.
>
> Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
>
>
> Regards
> Preeti U Murthy
>
next prev parent reply other threads:[~2012-11-27 6:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 21:52 [PATCH] cpuidle: Measure idle state durations with monotonic clock Julius Werner
2012-11-13 21:52 ` Julius Werner
2012-11-14 9:06 ` Deepthi Dharwar
2012-11-14 9:06 ` Deepthi Dharwar
2012-11-14 10:57 ` Daniel Lezcano
2012-11-14 10:57 ` Daniel Lezcano
2012-11-14 10:57 ` Daniel Lezcano
2012-11-14 11:05 ` Daniel Lezcano
2012-11-14 11:05 ` Daniel Lezcano
2012-11-14 17:15 ` Julius Werner
2012-11-14 17:15 ` Julius Werner
2012-11-15 1:56 ` Julius Werner
2012-11-15 1:56 ` Julius Werner
2012-11-15 9:04 ` Preeti Murthy
2012-11-15 9:04 ` Preeti Murthy
2012-11-27 6:14 ` Len Brown [this message]
2012-11-27 6:14 ` Len Brown
[not found] ` <1352944590-8776-1-git-send-email-jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-11-15 10:52 ` Daniel Lezcano
2012-11-15 10:52 ` Daniel Lezcano
2012-11-15 10:52 ` Daniel Lezcano
2012-11-21 0:17 ` Rafael J. Wysocki
2012-11-21 0:17 ` Rafael J. Wysocki
2012-11-27 6:15 ` Len Brown
2012-11-27 6:15 ` Len Brown
2012-11-27 19:12 ` Rafael J. Wysocki
2012-11-27 19:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B45A47.9050600@kernel.org \
--to=lenb@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=daniel.lezcano@linaro.org \
--cc=deepthi@linux.vnet.ibm.com \
--cc=g.trinabh@gmail.com \
--cc=jwerner@chromium.org \
--cc=khilman@ti.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=preeti.lkml@gmail.com \
--cc=rjw@sisk.pl \
--cc=snanda@chromium.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.