From: Liam Girdwood <lrg@ti.com>
To: Oskar Schirmer <oskar@scara.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Zeng Zhaoming <zengzm.kernel@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source
Date: Wed, 28 Nov 2012 09:58:22 +0000 [thread overview]
Message-ID: <50B5E03E.2080308@ti.com> (raw)
In-Reply-To: <1354094459-32466-1-git-send-email-oskar@scara.com>
On 28/11/12 09:20, Oskar Schirmer wrote:
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so the setting of 0x0008 does not make much sense.
> Instead, bit 4 should be set as is with power up, to reflect
> routing of I2S_IN to DAC correctly.
>
> Looks much like an off by one error.
Could you resend this to alsa-devel and CC maintainers.
Thanks
Liam
next prev parent reply other threads:[~2012-11-28 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 9:20 [PATCH] sound/sgtl5000: fix initial setting for DAC data source Oskar Schirmer
2012-11-28 9:58 ` Liam Girdwood [this message]
2012-11-28 10:14 ` Oskar Schirmer
2012-11-28 13:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5E03E.2080308@ti.com \
--to=lrg@ti.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@scara.com \
--cc=w.sang@pengutronix.de \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.