* [PATCH] sound/sgtl5000: fix initial setting for DAC data source
@ 2012-11-28 9:20 Oskar Schirmer
2012-11-28 9:58 ` Liam Girdwood
0 siblings, 1 reply; 4+ messages in thread
From: Oskar Schirmer @ 2012-11-28 9:20 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Andrew Morton, Liam Girdwood, Fabio Estevam,
Zeng Zhaoming, Oskar Schirmer
According to documentation bit 3:2 in register SSS_CTRL are
reserved and zero, so the setting of 0x0008 does not make much sense.
Instead, bit 4 should be set as is with power up, to reflect
routing of I2S_IN to DAC correctly.
Looks much like an off by one error.
Signed-off-by: Oskar Schirmer <oskar@scara.com>
---
sound/soc/codecs/sgtl5000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index df2f99d..5b37891 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -37,7 +37,7 @@
static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET] = {
[SGTL5000_CHIP_CLK_CTRL] = 0x0008,
[SGTL5000_CHIP_I2S_CTRL] = 0x0010,
- [SGTL5000_CHIP_SSS_CTRL] = 0x0008,
+ [SGTL5000_CHIP_SSS_CTRL] = 0x0010,
[SGTL5000_CHIP_DAC_VOL] = 0x3c3c,
[SGTL5000_CHIP_PAD_STRENGTH] = 0x015f,
[SGTL5000_CHIP_ANA_HP_CTRL] = 0x1818,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source
2012-11-28 9:20 [PATCH] sound/sgtl5000: fix initial setting for DAC data source Oskar Schirmer
@ 2012-11-28 9:58 ` Liam Girdwood
2012-11-28 10:14 ` Oskar Schirmer
0 siblings, 1 reply; 4+ messages in thread
From: Liam Girdwood @ 2012-11-28 9:58 UTC (permalink / raw)
To: Oskar Schirmer
Cc: Wolfram Sang, linux-kernel, Andrew Morton, Fabio Estevam,
Zeng Zhaoming, Mark Brown
On 28/11/12 09:20, Oskar Schirmer wrote:
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so the setting of 0x0008 does not make much sense.
> Instead, bit 4 should be set as is with power up, to reflect
> routing of I2S_IN to DAC correctly.
>
> Looks much like an off by one error.
Could you resend this to alsa-devel and CC maintainers.
Thanks
Liam
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] sound/sgtl5000: fix initial setting for DAC data source
2012-11-28 9:58 ` Liam Girdwood
@ 2012-11-28 10:14 ` Oskar Schirmer
2012-11-28 13:59 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Oskar Schirmer @ 2012-11-28 10:14 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Andrew Morton, Liam Girdwood, Fabio Estevam,
Zeng Zhaoming, alsa-devel, Jaroslav Kysela, Takashi Iwai,
Oskar Schirmer
According to documentation bit 3:2 in register SSS_CTRL are
reserved and zero, so the setting of 0x0008 does not make much sense.
Instead, bit 4 should be set as is with power up, to reflect
routing of I2S_IN to DAC correctly.
Looks much like an off by one error.
Signed-off-by: Oskar Schirmer <oskar@scara.com>
---
sound/soc/codecs/sgtl5000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index df2f99d..5b37891 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -37,7 +37,7 @@
static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET] = {
[SGTL5000_CHIP_CLK_CTRL] = 0x0008,
[SGTL5000_CHIP_I2S_CTRL] = 0x0010,
- [SGTL5000_CHIP_SSS_CTRL] = 0x0008,
+ [SGTL5000_CHIP_SSS_CTRL] = 0x0010,
[SGTL5000_CHIP_DAC_VOL] = 0x3c3c,
[SGTL5000_CHIP_PAD_STRENGTH] = 0x015f,
[SGTL5000_CHIP_ANA_HP_CTRL] = 0x1818,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source
2012-11-28 10:14 ` Oskar Schirmer
@ 2012-11-28 13:59 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-11-28 13:59 UTC (permalink / raw)
To: Oskar Schirmer
Cc: Wolfram Sang, linux-kernel, Andrew Morton, Liam Girdwood,
Fabio Estevam, Zeng Zhaoming, alsa-devel, Jaroslav Kysela,
Takashi Iwai
On Wed, Nov 28, 2012 at 10:14:28AM +0000, Oskar Schirmer wrote:
You've somehow decided to CC half the world but still haven't managed
to CC the maintainers like Liam asked (and as is covered in
SubmittingPatches)...
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so the setting of 0x0008 does not make much sense.
> Instead, bit 4 should be set as is with power up, to reflect
> routing of I2S_IN to DAC correctly.
> Looks much like an off by one error.
What does "as is with power up" mean? This is a register defaults
table, it should reflect what is in the register defaults. The meaning
of the field and the desired configuration for runtime is not relevant
here, the only thing that matters is what the default value of the
register is.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-28 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-28 9:20 [PATCH] sound/sgtl5000: fix initial setting for DAC data source Oskar Schirmer
2012-11-28 9:58 ` Liam Girdwood
2012-11-28 10:14 ` Oskar Schirmer
2012-11-28 13:59 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.