From: Paolo Bonzini <pbonzini@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] libcacard: build vscclient from root only
Date: Wed, 28 Nov 2012 11:09:46 +0100 [thread overview]
Message-ID: <50B5E2EA.1010708@redhat.com> (raw)
In-Reply-To: <1354094762-9538-1-git-send-email-alevy@redhat.com>
Il 28/11/2012 10:26, Alon Levy ha scritto:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> libcacard/Makefile | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 7bce286..98c971d 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -1,3 +1,7 @@
> +ifeq ($(BUILD_DIR),)
> + BUILD_DIR=$(CURDIR)/../
> +endif
> +
> -include ../config-host.mak
> -include $(SRC_PATH)/rules.mak
> -include $(SRC_PATH)/Makefile.objs
> @@ -49,12 +53,12 @@ libcacard.pc: $(libcacard_srcpath)/libcacard.pc.in
>
> .PHONY: install-libcacard
>
> -install-libcacard: libcacard.pc libcacard.la vscclient
> +install-libcacard: libcacard.pc libcacard.la ../vscclient
> $(INSTALL_DIR) "$(DESTDIR)$(libdir)"
> $(INSTALL_DIR) "$(DESTDIR)$(libdir)/pkgconfig"
> $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
> $(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> - $(LIBTOOL) --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> + $(LIBTOOL) --mode=install $(INSTALL_PROG) ../vscclient "$(DESTDIR)$(bindir)"
> $(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
> $(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
> for inc in *.h; do \
>
Can you instead move all the vscclient rules to libcacard/Makefile
(including building the program as libcacard/vscclient)?
Paolo
prev parent reply other threads:[~2012-11-28 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 9:26 [Qemu-devel] [PATCH] libcacard: build vscclient from root only Alon Levy
2012-11-28 10:09 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5E2EA.1010708@redhat.com \
--to=pbonzini@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.