From: Leif Lindholm <leif.lindholm@arm.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
Subject: Re: [PATCH] Typo in types.h
Date: Wed, 28 Nov 2012 12:47:24 +0000 [thread overview]
Message-ID: <50B607DC.50500@arm.com> (raw)
In-Reply-To: <50B6031C.4010303@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
On 28/11/12 12:27, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 26.11.2012 18:44, Leif Lindholm wrote:
>> & -> &&
>>
>> Current version functionally correct, but reads a bit funny.
>
> Please add a correct ChangeLog entry.
Complete patch attached.
/
Leif
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: types_h.patch --]
[-- Type: text/x-patch; name=types_h.patch, Size: 955 bytes --]
=== modified file 'ChangeLog'
--- ChangeLog 2012-10-28 10:55:22 +0000
+++ ChangeLog 2012-11-28 12:42:39 +0000
@@ -1,3 +1,8 @@
+2012-11-28 Leif Lindholm <leif.lindholm@arm.com>
+
+ * include/grub/types.h: Fix functionality unaffecting typo in
+ GRUB_TARGET_WORDSIZE conditional macro.
+
2012-10-28 Grégoire Sutre <gregoire.sutre@gmail.com>
* util/grub.d/10_netbsd.in: Fix tab indentation and make sure
=== modified file 'include/grub/types.h'
--- include/grub/types.h 2012-06-07 12:07:02 +0000
+++ include/grub/types.h 2012-11-26 17:40:33 +0000
@@ -50,7 +50,7 @@
# error "This architecture is not supported because sizeof(void *) != 4 and sizeof(void *) != 8"
#endif
-#if !defined (GRUB_UTIL) & !defined (GRUB_TARGET_WORDSIZE)
+#if !defined (GRUB_UTIL) && !defined (GRUB_TARGET_WORDSIZE)
# if GRUB_TARGET_SIZEOF_VOID_P == 4
# define GRUB_TARGET_WORDSIZE 32
# elif GRUB_TARGET_SIZEOF_VOID_P == 8
prev parent reply other threads:[~2012-11-28 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 17:44 [PATCH] Typo in types.h Leif Lindholm
2012-11-28 12:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-11-28 12:47 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B607DC.50500@arm.com \
--to=leif.lindholm@arm.com \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.