* [PATCH] Typo in types.h
@ 2012-11-26 17:44 Leif Lindholm
2012-11-28 12:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2012-11-26 17:44 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 91 bytes --]
& -> &&
Current version functionally correct, but reads a bit funny.
Regards,
Leif
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: types_h.patch --]
[-- Type: text/x-patch; name=types_h.patch, Size: 513 bytes --]
=== modified file 'include/grub/types.h'
--- include/grub/types.h 2012-06-07 12:07:02 +0000
+++ include/grub/types.h 2012-11-26 17:40:33 +0000
@@ -50,7 +50,7 @@
# error "This architecture is not supported because sizeof(void *) != 4 and sizeof(void *) != 8"
#endif
-#if !defined (GRUB_UTIL) & !defined (GRUB_TARGET_WORDSIZE)
+#if !defined (GRUB_UTIL) && !defined (GRUB_TARGET_WORDSIZE)
# if GRUB_TARGET_SIZEOF_VOID_P == 4
# define GRUB_TARGET_WORDSIZE 32
# elif GRUB_TARGET_SIZEOF_VOID_P == 8
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Typo in types.h
2012-11-26 17:44 [PATCH] Typo in types.h Leif Lindholm
@ 2012-11-28 12:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-11-28 12:47 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-11-28 12:27 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
On 26.11.2012 18:44, Leif Lindholm wrote:
> & -> &&
>
> Current version functionally correct, but reads a bit funny.
>
Please add a correct ChangeLog entry.
> Regards,
>
> Leif
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Typo in types.h
2012-11-28 12:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2012-11-28 12:47 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2012-11-28 12:47 UTC (permalink / raw)
To: The development of GNU GRUB
Cc: Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
On 28/11/12 12:27, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 26.11.2012 18:44, Leif Lindholm wrote:
>> & -> &&
>>
>> Current version functionally correct, but reads a bit funny.
>
> Please add a correct ChangeLog entry.
Complete patch attached.
/
Leif
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: types_h.patch --]
[-- Type: text/x-patch; name=types_h.patch, Size: 955 bytes --]
=== modified file 'ChangeLog'
--- ChangeLog 2012-10-28 10:55:22 +0000
+++ ChangeLog 2012-11-28 12:42:39 +0000
@@ -1,3 +1,8 @@
+2012-11-28 Leif Lindholm <leif.lindholm@arm.com>
+
+ * include/grub/types.h: Fix functionality unaffecting typo in
+ GRUB_TARGET_WORDSIZE conditional macro.
+
2012-10-28 Grégoire Sutre <gregoire.sutre@gmail.com>
* util/grub.d/10_netbsd.in: Fix tab indentation and make sure
=== modified file 'include/grub/types.h'
--- include/grub/types.h 2012-06-07 12:07:02 +0000
+++ include/grub/types.h 2012-11-26 17:40:33 +0000
@@ -50,7 +50,7 @@
# error "This architecture is not supported because sizeof(void *) != 4 and sizeof(void *) != 8"
#endif
-#if !defined (GRUB_UTIL) & !defined (GRUB_TARGET_WORDSIZE)
+#if !defined (GRUB_UTIL) && !defined (GRUB_TARGET_WORDSIZE)
# if GRUB_TARGET_SIZEOF_VOID_P == 4
# define GRUB_TARGET_WORDSIZE 32
# elif GRUB_TARGET_SIZEOF_VOID_P == 8
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-28 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-26 17:44 [PATCH] Typo in types.h Leif Lindholm
2012-11-28 12:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-11-28 12:47 ` Leif Lindholm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.