Re: [PATCH v5 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

[Daniel Mack <zonque@gmail.com>]

On 29.11.2012 13:36, Philip, Avinash wrote:
> On Wed, Nov 28, 2012 at 22:28:59, Daniel Mack wrote:
> [...]
>> +	if (!of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
>> +		for (val = 0; val < ARRAY_SIZE(nand_ecc_opts); val++)
>> +			if (!strcasecmp(s, nand_ecc_opts[val])) {
>> +				gpmc_nand_data->ecc_opt = val;
>> +				break;
>> +			}
>> +
>> +		/*
>> +		 *  AM335x RBL compatibility mode - dependns on runtime
>> +		 * detection of the error location module.
>> +		 */
>> +		if (!strcasecmp(s, "bch8-am335xrbl-compatible")) {
>> +			gpmc_nand_data->ecc_opt = OMAP_ECC_BCH8_CODE_HW;
>> +			gpmc_nand_data->is_elm_used = true;
> 
> Remove is_elm_used from struct omap_nand_platform_data. Now this data
> populated as part of run time detection of elm module. So please remove
> The usage of is_elm_used;

So why do we need "bch8-am335xrbl-compatible" as special case then?

I thought the whole idea here is to tell the driver we want bch8 *and*
the usage of the elm, instead of falling back to the (incompatible)
software mode? If I remove that assignment, "bch8-am335xrbl-compatible"
is the same than "bch8".

Which detail am I missing? :)


Daniel