* [PATCH] gspca - stv06xx: Fix a regression with the bridge/sensor vv6410
@ 2012-11-22 11:59 Jean-Francois Moine
2012-11-29 14:25 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Francois Moine @ 2012-11-22 11:59 UTC (permalink / raw)
To: Linux Media Mailing List, Hans de Goede
From: Jean-François Moine <moinejf@free.fr>
Setting the H and V flip controls at webcam connection time prevents
the webcam to work correctly.
This patch checks if the webcam is streaming before setting the flips.
It does not set the flips (nor other controls) at webcam start time.
Tested-by: Philippe ROUBACH <philippe.roubach@free.fr>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
--- a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
+++ b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
@@ -52,9 +52,13 @@
switch (ctrl->id) {
case V4L2_CID_HFLIP:
+ if (!gspca_dev->streaming)
+ return 0;
err = vv6410_set_hflip(gspca_dev, ctrl->val);
break;
case V4L2_CID_VFLIP:
+ if (!gspca_dev->streaming)
+ return 0;
err = vv6410_set_vflip(gspca_dev, ctrl->val);
break;
case V4L2_CID_GAIN:
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gspca - stv06xx: Fix a regression with the bridge/sensor vv6410
2012-11-22 11:59 [PATCH] gspca - stv06xx: Fix a regression with the bridge/sensor vv6410 Jean-Francois Moine
@ 2012-11-29 14:25 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2012-11-29 14:25 UTC (permalink / raw)
To: Jean-Francois Moine; +Cc: Linux Media Mailing List
Hi,
Thanks for the patch I've added this to my tree, and it is part
of the pull-request I just send to Mauro for 3.8
Regards,
Hans
On 11/22/2012 12:59 PM, Jean-Francois Moine wrote:
> From: Jean-François Moine <moinejf@free.fr>
>
> Setting the H and V flip controls at webcam connection time prevents
> the webcam to work correctly.
>
> This patch checks if the webcam is streaming before setting the flips.
> It does not set the flips (nor other controls) at webcam start time.
>
> Tested-by: Philippe ROUBACH <philippe.roubach@free.fr>
> Signed-off-by: Jean-François Moine <moinejf@free.fr>
>
> --- a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> +++ b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> @@ -52,9 +52,13 @@
>
> switch (ctrl->id) {
> case V4L2_CID_HFLIP:
> + if (!gspca_dev->streaming)
> + return 0;
> err = vv6410_set_hflip(gspca_dev, ctrl->val);
> break;
> case V4L2_CID_VFLIP:
> + if (!gspca_dev->streaming)
> + return 0;
> err = vv6410_set_vflip(gspca_dev, ctrl->val);
> break;
> case V4L2_CID_GAIN:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-29 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-22 11:59 [PATCH] gspca - stv06xx: Fix a regression with the bridge/sensor vv6410 Jean-Francois Moine
2012-11-29 14:25 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.