* [PATCH, FIXED] drm/vmwgfx: always use ttm_bo_is_reserved
@ 2012-11-30 8:18 Maarten Lankhorst
2012-11-30 8:53 ` Thomas Hellstrom
0 siblings, 1 reply; 2+ messages in thread
From: Maarten Lankhorst @ 2012-11-30 8:18 UTC (permalink / raw)
To: Thomas Hellstrom; +Cc: dri-devel
This was missed during the initial conversion, most likely due to the refactoring here.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
---
Woops, forgot to stg refresh before sending, fixed. :-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
index 93dffe3..ddc8db8 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
@@ -939,13 +939,13 @@ void vmw_resource_unreserve(struct vmw_resource *res,
if (new_backup && new_backup != res->backup) {
if (res->backup) {
- BUG_ON(atomic_read(&res->backup->base.reserved) == 0);
+ BUG_ON(!ttm_bo_is_reserved(&res->backup->base));
list_del_init(&res->mob_head);
vmw_dmabuf_unreference(&res->backup);
}
res->backup = vmw_dmabuf_reference(new_backup);
- BUG_ON(atomic_read(&new_backup->base.reserved) == 0);
+ BUG_ON(!ttm_bo_is_reserved(&new_backup->base));
list_add_tail(&res->mob_head, &new_backup->res_list);
}
if (new_backup)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH, FIXED] drm/vmwgfx: always use ttm_bo_is_reserved
2012-11-30 8:18 [PATCH, FIXED] drm/vmwgfx: always use ttm_bo_is_reserved Maarten Lankhorst
@ 2012-11-30 8:53 ` Thomas Hellstrom
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Hellstrom @ 2012-11-30 8:53 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: dri-devel
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
On 11/30/2012 09:18 AM, Maarten Lankhorst wrote:
> This was missed during the initial conversion, most likely due to the refactoring here.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> ---
> Woops, forgot to stg refresh before sending, fixed. :-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
> index 93dffe3..ddc8db8 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
> @@ -939,13 +939,13 @@ void vmw_resource_unreserve(struct vmw_resource *res,
> if (new_backup && new_backup != res->backup) {
>
> if (res->backup) {
> - BUG_ON(atomic_read(&res->backup->base.reserved) == 0);
> + BUG_ON(!ttm_bo_is_reserved(&res->backup->base));
> list_del_init(&res->mob_head);
> vmw_dmabuf_unreference(&res->backup);
> }
>
> res->backup = vmw_dmabuf_reference(new_backup);
> - BUG_ON(atomic_read(&new_backup->base.reserved) == 0);
> + BUG_ON(!ttm_bo_is_reserved(&new_backup->base));
> list_add_tail(&res->mob_head, &new_backup->res_list);
> }
> if (new_backup)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-30 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-30 8:18 [PATCH, FIXED] drm/vmwgfx: always use ttm_bo_is_reserved Maarten Lankhorst
2012-11-30 8:53 ` Thomas Hellstrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.