From: Boaz Harrosh <bharrosh@panasas.com>
To: <osd-dev@open-osd.org>
Cc: Idan Kedar <idank@tonian.com>, <linux-fsdevel@vger.kernel.org>
Subject: [PATCH] exofs: Remove dead code in read_exec
Date: Fri, 30 Nov 2012 16:28:03 +0200 [thread overview]
Message-ID: <50B8C273.1040702@panasas.com> (raw)
In-Reply-To: <50B8BF8D.8050704@panasas.com>
The if (!pcol->read_4_write) at the error path is redundant
because all goto err; are after the if (pcol->read_4_write)
bale out.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/exofs/inode.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
index 87f05d9..449da05 100644
--- a/fs/exofs/inode.c
+++ b/fs/exofs/inode.c
@@ -364,9 +364,7 @@ err:
if (!pcol_copy) /* Failed before ownership transfer */
pcol_copy = pcol;
- if (!pcol->read_4_write)
- _unlock_pcol_pages(pcol_copy, ret, READ);
-
+ _unlock_pcol_pages(pcol_copy, ret, READ);
pcol_free(pcol_copy);
kfree(pcol_copy);
return ret;
--
1.7.10.2.677.gb6bc67f
next prev parent reply other threads:[~2012-11-30 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 14:49 [PATCH] exofs: clean up the correct page collection on write error Idan Kedar
2012-11-30 14:10 ` Boaz Harrosh
2012-11-30 14:15 ` Boaz Harrosh
2012-11-30 14:26 ` [PATCH] exofs: don't leak io_state and pages on read error Boaz Harrosh
2012-11-30 14:28 ` Boaz Harrosh [this message]
2012-12-02 9:57 ` [PATCH] exofs: clean up the correct page collection on write error Idan Kedar
2012-12-02 12:58 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8C273.1040702@panasas.com \
--to=bharrosh@panasas.com \
--cc=idank@tonian.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.