From: Boaz Harrosh <bharrosh@panasas.com>
To: Idan Kedar <idank@tonian.com>
Cc: <linux-fsdevel@vger.kernel.org>, <osd-dev@open-osd.org>,
<solo@tonian.com>, <bhalevy@tonian.com>, <ilya@tonian.com>
Subject: Re: [PATCH] exofs: clean up the correct page collection on write error
Date: Fri, 30 Nov 2012 16:15:41 +0200 [thread overview]
Message-ID: <50B8BF8D.8050704@panasas.com> (raw)
In-Reply-To: <50B8BE60.6090009@panasas.com>
On 11/30/2012 04:10 PM, Boaz Harrosh wrote:
> On 11/26/2012 04:49 PM, Idan Kedar wrote:
>> if ore_write() fails, we would unlock the pages of pcol, which is now
>> empty, rather than pcol_copy which owns the pages when ore_write() is
>> called. this means that no pages will actually be unlocked
>> (pcol.nr_pages == 0) and the writing process (more accurately, the
>> syncing process) will hang waiting for a writeback notification that
>> never comes.
>>
>> moreover, if ore_write() fails, pcol_free() is called for pcol, whereas
>> pcol_copy is the object owning the ore_io_state, thus leaking the
>> ore_io_state.
>>
>> Signed-off-by: Idan Kedar <idank@tonian.com>
>
> Thanks Idan, good catch.
>
> I have simplified your patch a bit, see below. But basically it
> is all the same. Please check me out
>
I forgot to ask do you need this for stable?
Boaz
next prev parent reply other threads:[~2012-11-30 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 14:49 [PATCH] exofs: clean up the correct page collection on write error Idan Kedar
2012-11-30 14:10 ` Boaz Harrosh
2012-11-30 14:15 ` Boaz Harrosh [this message]
2012-11-30 14:26 ` [PATCH] exofs: don't leak io_state and pages on read error Boaz Harrosh
2012-11-30 14:28 ` [PATCH] exofs: Remove dead code in read_exec Boaz Harrosh
2012-12-02 9:57 ` [PATCH] exofs: clean up the correct page collection on write error Idan Kedar
2012-12-02 12:58 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8BF8D.8050704@panasas.com \
--to=bharrosh@panasas.com \
--cc=bhalevy@tonian.com \
--cc=idank@tonian.com \
--cc=ilya@tonian.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=solo@tonian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.