From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Subject: Re: [PATCH 1/4] cgroup: warn about broken hierarchies only after css_online
Date: Fri, 30 Nov 2012 19:13:54 +0400 [thread overview]
Message-ID: <50B8CD32.4080807@parallels.com> (raw)
In-Reply-To: <20121130151158.GB3873-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
On 11/30/2012 07:11 PM, Tejun Heo wrote:
> On Fri, Nov 30, 2012 at 05:31:23PM +0400, Glauber Costa wrote:
>> If everything goes right, it shouldn't really matter if we are spitting
>> this warning after css_alloc or css_online. If we fail between then,
>> there are some ill cases where we would previously see the message and
>> now we won't (like if the files fail to be created).
>>
>> I believe it really shouldn't matter: this message is intended in spirit
>> to be shown when creation succeeds, but with insane settings.
>>
>> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
>
> Applied to cgroup/for-3.8. Thanks!
>
We just need to be careful because when we merge it with morton's, more
bits will need converting.
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Tejun Heo <tj@kernel.org>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
kamezawa.hiroyu@jp.fujitsu.com,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH 1/4] cgroup: warn about broken hierarchies only after css_online
Date: Fri, 30 Nov 2012 19:13:54 +0400 [thread overview]
Message-ID: <50B8CD32.4080807@parallels.com> (raw)
In-Reply-To: <20121130151158.GB3873@htj.dyndns.org>
On 11/30/2012 07:11 PM, Tejun Heo wrote:
> On Fri, Nov 30, 2012 at 05:31:23PM +0400, Glauber Costa wrote:
>> If everything goes right, it shouldn't really matter if we are spitting
>> this warning after css_alloc or css_online. If we fail between then,
>> there are some ill cases where we would previously see the message and
>> now we won't (like if the files fail to be created).
>>
>> I believe it really shouldn't matter: this message is intended in spirit
>> to be shown when creation succeeds, but with insane settings.
>>
>> Signed-off-by: Glauber Costa <glommer@parallels.com>
>
> Applied to cgroup/for-3.8. Thanks!
>
We just need to be careful because when we merge it with morton's, more
bits will need converting.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-30 15:13 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 13:31 [PATCH 0/4] replace cgroup_lock with local lock in memcg Glauber Costa
2012-11-30 13:31 ` [PATCH 1/4] cgroup: warn about broken hierarchies only after css_online Glauber Costa
[not found] ` <1354282286-32278-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-30 15:11 ` Tejun Heo
2012-11-30 15:11 ` Tejun Heo
[not found] ` <20121130151158.GB3873-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-11-30 15:13 ` Glauber Costa [this message]
2012-11-30 15:13 ` Glauber Costa
[not found] ` <50B8CD32.4080807-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-30 15:45 ` Tejun Heo
2012-11-30 15:45 ` Tejun Heo
[not found] ` <20121130154504.GD3873-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-11-30 15:49 ` Michal Hocko
2012-11-30 15:49 ` Michal Hocko
2012-11-30 15:57 ` Glauber Costa
2012-11-30 13:31 ` [PATCH 2/4] memcg: prevent changes to move_charge_at_immigrate during task attach Glauber Costa
2012-11-30 15:19 ` Tejun Heo
2012-11-30 15:29 ` Glauber Costa
[not found] ` <1354282286-32278-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-12-04 9:29 ` Michal Hocko
2012-12-04 9:29 ` Michal Hocko
2012-11-30 13:31 ` [PATCH 3/4] memcg: split part of memcg creation to css_online Glauber Costa
[not found] ` <1354282286-32278-4-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-12-03 17:32 ` Michal Hocko
2012-12-03 17:32 ` Michal Hocko
[not found] ` <20121203173205.GI17093-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-04 8:05 ` Glauber Costa
2012-12-04 8:05 ` Glauber Costa
[not found] ` <50BDAEC1.8040805-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-12-04 8:17 ` Michal Hocko
2012-12-04 8:17 ` Michal Hocko
[not found] ` <20121204081756.GA31319-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-04 8:32 ` Glauber Costa
2012-12-04 8:32 ` Glauber Costa
[not found] ` <50BDB511.5070107-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-12-04 8:52 ` Michal Hocko
2012-12-04 8:52 ` Michal Hocko
2012-11-30 13:31 ` [PATCH 4/4] memcg: replace cgroup_lock with memcg specific memcg_lock Glauber Costa
[not found] ` <1354282286-32278-5-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-12-03 17:15 ` Michal Hocko
2012-12-03 17:15 ` Michal Hocko
[not found] ` <20121203171532.GG17093-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-03 17:30 ` Michal Hocko
2012-12-03 17:30 ` Michal Hocko
[not found] ` <20121203173002.GH17093-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-04 7:49 ` Glauber Costa
2012-12-04 7:49 ` Glauber Costa
2012-12-04 7:58 ` Glauber Costa
[not found] ` <50BDAD38.6030200-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-12-04 8:23 ` Michal Hocko
2012-12-04 8:23 ` Michal Hocko
[not found] ` <20121204082316.GB31319-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-04 8:31 ` Glauber Costa
2012-12-04 8:31 ` Glauber Costa
[not found] ` <50BDB4E3.4040107-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-12-04 8:45 ` Michal Hocko
2012-12-04 8:45 ` Michal Hocko
[not found] ` <20121204084544.GC31319-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-04 14:52 ` Tejun Heo
2012-12-04 14:52 ` Tejun Heo
[not found] ` <20121204145221.GA3885-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-12-04 15:14 ` Michal Hocko
2012-12-04 15:14 ` Michal Hocko
[not found] ` <20121204151420.GL31319-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-04 15:22 ` Tejun Heo
2012-12-04 15:22 ` Tejun Heo
[not found] ` <20121204152225.GC3885-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-12-05 14:35 ` Michal Hocko
2012-12-05 14:35 ` Michal Hocko
[not found] ` <20121205143537.GC9714-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-05 14:41 ` Tejun Heo
2012-12-05 14:41 ` Tejun Heo
[not found] ` <1354282286-32278-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-30 15:52 ` [PATCH 0/4] replace cgroup_lock with local lock in memcg Tejun Heo
2012-11-30 15:52 ` Tejun Heo
2012-11-30 15:59 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8CD32.4080807@parallels.com \
--to=glommer-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.