All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: anthony@codemonkey.ws, mtosatti@redhat.com,
	Avi Kivity <avi@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState
Date: Sun, 02 Dec 2012 05:56:37 +0100	[thread overview]
Message-ID: <50BADF85.7060805@suse.de> (raw)
In-Reply-To: <1354423851-24818-2-git-send-email-afaerber@suse.de>

Am 02.12.2012 05:50, schrieb Andreas Färber:
> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h
> index 61b7698..6c66fc0 100644
> --- a/include/qemu/cpu.h
> +++ b/include/qemu/cpu.h
> @@ -77,6 +77,10 @@ struct CPUState {
>      bool stop;
>      bool stopped;
>  
> +#if !defined(CONFIG_USER_ONLY)
> +    int kvm_fd;
> +#endif
> +
>      /* TODO Move common fields from CPUArchState here. */
>  };
>  

First nit found myself: I strive to set good examples, so this field
addition should've been accompanied by a documentation update. ;)

I'll defer a v2 until other people have had a chance to review though.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: anthony@codemonkey.ws, mtosatti@redhat.com,
	Avi Kivity <avi@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState
Date: Sun, 02 Dec 2012 05:56:37 +0100	[thread overview]
Message-ID: <50BADF85.7060805@suse.de> (raw)
In-Reply-To: <1354423851-24818-2-git-send-email-afaerber@suse.de>

Am 02.12.2012 05:50, schrieb Andreas Färber:
> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h
> index 61b7698..6c66fc0 100644
> --- a/include/qemu/cpu.h
> +++ b/include/qemu/cpu.h
> @@ -77,6 +77,10 @@ struct CPUState {
>      bool stop;
>      bool stopped;
>  
> +#if !defined(CONFIG_USER_ONLY)
> +    int kvm_fd;
> +#endif
> +
>      /* TODO Move common fields from CPUArchState here. */
>  };
>  

First nit found myself: I strive to set good examples, so this field
addition should've been accompanied by a documentation update. ;)

I'll defer a v2 until other people have had a chance to review though.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-12-02  4:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-02  4:50 [PATCH qom-cpu 00/11] QOM CPUState, part 6: CPU_COMMON for KVM Andreas Färber
2012-12-02  4:50 ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:56   ` Andreas Färber [this message]
2012-12-02  4:56     ` Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 02/11] kvm: Pass CPUState to kvm_arch_* Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 03/11] kvm: Pass CPUState to kvm_vcpu_ioctl() Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 04/11] ppc: Pass PowerPCCPU to ppc_set_irq() Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 05/11] ppc: Pass PowerPCCPU to [h]decr callbacks Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 06/11] ppc: Pass PowerPCCPU to [h]decr timer callbacks Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 07/11] ppc_booke: Pass PowerPCCPU to {decr,fit,wdt} " Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] [PATCH qom-cpu 07/11] ppc_booke: Pass PowerPCCPU to {decr, fit, wdt} " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 08/11] ppc4xx_devs: Return PowerPCCPU from ppc4xx_init() Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 09/11] ppc_booke: Pass PowerPCCPU to ppc_booke_timers_init() Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 10/11] cpu: Move kvm_state field into CPUState Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber
2012-12-02  4:50 ` [PATCH qom-cpu 11/11] cpu: Move kvm_run " Andreas Färber
2012-12-02  4:50   ` [Qemu-devel] " Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50BADF85.7060805@suse.de \
    --to=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.