* [PATCH -next v2] [SCSI] csiostor: convert to use simple_open()
@ 2012-12-03 6:22 Wei Yongjun
2012-12-03 6:53 ` Naresh Kumar Inna
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-12-03 6:22 UTC (permalink / raw)
To: JBottomley, naresh; +Cc: yongjun_wei, linux-scsi
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
This removes an open coded simple_open() function and
replaces file operations references to the function
with simple_open() instead.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/scsi/csiostor/csio_init.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c
index fdd408f..c9336b3 100644
--- a/drivers/scsi/csiostor/csio_init.c
+++ b/drivers/scsi/csiostor/csio_init.c
@@ -60,13 +60,6 @@ static struct scsi_transport_template *csio_fcoe_transport_vport;
/*
* debugfs support
*/
-static int
-csio_mem_open(struct inode *inode, struct file *file)
-{
- file->private_data = inode->i_private;
- return 0;
-}
-
static ssize_t
csio_mem_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
{
@@ -110,7 +103,7 @@ csio_mem_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
static const struct file_operations csio_mem_debugfs_fops = {
.owner = THIS_MODULE,
- .open = csio_mem_open,
+ .open = simple_open,
.read = csio_mem_read,
.llseek = default_llseek,
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] [SCSI] csiostor: convert to use simple_open()
2012-12-03 6:22 [PATCH -next v2] [SCSI] csiostor: convert to use simple_open() Wei Yongjun
@ 2012-12-03 6:53 ` Naresh Kumar Inna
0 siblings, 0 replies; 2+ messages in thread
From: Naresh Kumar Inna @ 2012-12-03 6:53 UTC (permalink / raw)
To: Wei Yongjun
Cc: JBottomley@parallels.com, yongjun_wei@trendmicro.com.cn,
linux-scsi@vger.kernel.org
On 12/3/2012 11:52 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> This removes an open coded simple_open() function and
> replaces file operations references to the function
> with simple_open() instead.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/scsi/csiostor/csio_init.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c
> index fdd408f..c9336b3 100644
> --- a/drivers/scsi/csiostor/csio_init.c
> +++ b/drivers/scsi/csiostor/csio_init.c
> @@ -60,13 +60,6 @@ static struct scsi_transport_template *csio_fcoe_transport_vport;
> /*
> * debugfs support
> */
> -static int
> -csio_mem_open(struct inode *inode, struct file *file)
> -{
> - file->private_data = inode->i_private;
> - return 0;
> -}
> -
> static ssize_t
> csio_mem_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
> {
> @@ -110,7 +103,7 @@ csio_mem_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
>
> static const struct file_operations csio_mem_debugfs_fops = {
> .owner = THIS_MODULE,
> - .open = csio_mem_open,
> + .open = simple_open,
> .read = csio_mem_read,
> .llseek = default_llseek,
> };
>
>
Acked-by: Naresh Kumar Inna <naresh@chelsio.com>
Thanks,
Naresh.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-03 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 6:22 [PATCH -next v2] [SCSI] csiostor: convert to use simple_open() Wei Yongjun
2012-12-03 6:53 ` Naresh Kumar Inna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.