From: Vaibhav Hiremath <hvaibhav@ti.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
b-cousson@ti.com, paul@pwsan.com, nfont@linux.vnet.ibm.com
Subject: Re: [PATCH 1/1] ARM: OMAP: fix build error in arch/arm/mach-omap2/timer.c
Date: Mon, 3 Dec 2012 16:53:06 +0530 [thread overview]
Message-ID: <50BC8B9A.6040104@ti.com> (raw)
In-Reply-To: <50B4EFB3.5060901@ti.com>
On 11/27/2012 10:22 PM, Jon Hunter wrote:
>
> On 11/27/2012 04:24 AM, Mugunthan V N wrote:
>> CC arch/arm/mach-omap2/timer.o
>> arch/arm/mach-omap2/timer.c: In function 'omap_get_timer_dt':
>> arch/arm/mach-omap2/timer.c:195:3: error: implicit declaration of function 'prom_add_property'
>> make[1]: *** [arch/arm/mach-omap2/timer.o] Error 1
>> make: *** [arch/arm/mach-omap2] Error 2
>
> Thanks for sending. You may wish to mentioned that this is seen on
> today's linux-next (I am seeing the same problem).
>
>> fix for build break as the functions "prom_*_property" is renamed to
>> of_*_property by the below patch
>>
>> commit 79d1c712958f94372482ad74578b00f44e744c12
>> Author: Nathan Fontenot <nfont@linux.vnet.ibm.com>
>> Date: Tue Oct 2 16:58:46 2012 +0000
>>
>> powerpc+of: Rename the drivers/of prom_* functions to of_*
>>
>> Rename the prom_*_property routines of the generic OF code to of_*_property.
>> This brings them in line with the naming used by the rest of the OF code.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> ---
>> arch/arm/mach-omap2/timer.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
>> index 099e406..5fd5e23 100644
>> --- a/arch/arm/mach-omap2/timer.c
>> +++ b/arch/arm/mach-omap2/timer.c
>> @@ -192,7 +192,7 @@ static struct device_node * __init omap_get_timer_dt(struct of_device_id *match,
>> continue;
>> }
>>
>> - prom_add_property(np, &device_disabled);
>> + of_add_property(np, &device_disabled);
>> return np;
>> }
>
> I tested this on the AM335x device and it is working fine. So ...
>
> Acked-by: Jon Hunter <jon-hunter@ti.com>
> Tested-by: Jon Hunter <jon-hunter@ti.com>
>
This patch still not made its way to linux-next, so still build is
broken for all OMAP platforms.
Thanks,
Vaibhav
> Cheers
> Jon
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: hvaibhav@ti.com (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: OMAP: fix build error in arch/arm/mach-omap2/timer.c
Date: Mon, 3 Dec 2012 16:53:06 +0530 [thread overview]
Message-ID: <50BC8B9A.6040104@ti.com> (raw)
In-Reply-To: <50B4EFB3.5060901@ti.com>
On 11/27/2012 10:22 PM, Jon Hunter wrote:
>
> On 11/27/2012 04:24 AM, Mugunthan V N wrote:
>> CC arch/arm/mach-omap2/timer.o
>> arch/arm/mach-omap2/timer.c: In function 'omap_get_timer_dt':
>> arch/arm/mach-omap2/timer.c:195:3: error: implicit declaration of function 'prom_add_property'
>> make[1]: *** [arch/arm/mach-omap2/timer.o] Error 1
>> make: *** [arch/arm/mach-omap2] Error 2
>
> Thanks for sending. You may wish to mentioned that this is seen on
> today's linux-next (I am seeing the same problem).
>
>> fix for build break as the functions "prom_*_property" is renamed to
>> of_*_property by the below patch
>>
>> commit 79d1c712958f94372482ad74578b00f44e744c12
>> Author: Nathan Fontenot <nfont@linux.vnet.ibm.com>
>> Date: Tue Oct 2 16:58:46 2012 +0000
>>
>> powerpc+of: Rename the drivers/of prom_* functions to of_*
>>
>> Rename the prom_*_property routines of the generic OF code to of_*_property.
>> This brings them in line with the naming used by the rest of the OF code.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> ---
>> arch/arm/mach-omap2/timer.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
>> index 099e406..5fd5e23 100644
>> --- a/arch/arm/mach-omap2/timer.c
>> +++ b/arch/arm/mach-omap2/timer.c
>> @@ -192,7 +192,7 @@ static struct device_node * __init omap_get_timer_dt(struct of_device_id *match,
>> continue;
>> }
>>
>> - prom_add_property(np, &device_disabled);
>> + of_add_property(np, &device_disabled);
>> return np;
>> }
>
> I tested this on the AM335x device and it is working fine. So ...
>
> Acked-by: Jon Hunter <jon-hunter@ti.com>
> Tested-by: Jon Hunter <jon-hunter@ti.com>
>
This patch still not made its way to linux-next, so still build is
broken for all OMAP platforms.
Thanks,
Vaibhav
> Cheers
> Jon
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-12-03 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 10:24 [PATCH 1/1] ARM: OMAP: fix build error in arch/arm/mach-omap2/timer.c Mugunthan V N
2012-11-27 10:24 ` Mugunthan V N
2012-11-27 16:52 ` Jon Hunter
2012-11-27 16:52 ` Jon Hunter
2012-12-03 11:23 ` Vaibhav Hiremath [this message]
2012-12-03 11:23 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BC8B9A.6040104@ti.com \
--to=hvaibhav@ti.com \
--cc=b-cousson@ti.com \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.