Use of BBPATH in a layer.conf file.

Use of BBPATH in a layer.conf file.

[Scott Garman]

Hey folks,

Robert Day has brought up an inconsistency in the way we append to 
BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different 
ordering in meta-yocto's layer.conf, I will submit a patch to make this 
more consistent.

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center

Re: Use of BBPATH in a layer.conf file.

[Paul Eggleton]

On Sunday 02 December 2012 14:51:28 Scott Garman wrote:
> Robert Day has brought up an inconsistency in the way we append to
> BBPATH within a couple of our layer.conf files.
> 
> In meta-hob, meta-yocto-bsp, and meta-intel, we do:
> 
> BBPATH := "${BBPATH}:${LAYERDIR}"
> 
> but in meta-yocto, we do:
> 
> BBPATH := "${LAYERDIR}:${BBPATH}"
> 
> Unless someone explains to me that it's necessary to use this different
> ordering in meta-yocto's layer.conf, I will submit a patch to make this
> more consistent.

I think it actually ought to be:

BBPATH .= ":${LAYERDIR}"

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: Use of BBPATH in a layer.conf file.

[Scott Garman]

On 12/02/2012 03:24 PM, Paul Eggleton wrote:
> On Sunday 02 December 2012 14:51:28 Scott Garman wrote:
>> Robert Day has brought up an inconsistency in the way we append to
>> BBPATH within a couple of our layer.conf files.
>>
>> In meta-hob, meta-yocto-bsp, and meta-intel, we do:
>>
>> BBPATH := "${BBPATH}:${LAYERDIR}"
>>
>> but in meta-yocto, we do:
>>
>> BBPATH := "${LAYERDIR}:${BBPATH}"
>>
>> Unless someone explains to me that it's necessary to use this different
>> ordering in meta-yocto's layer.conf, I will submit a patch to make this
>> more consistent.
>
> I think it actually ought to be:
>
> BBPATH .= ":${LAYERDIR}"

Oh? Would this apply just to meta-yocto or all layer.conf files?

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center

Re: Use of BBPATH in a layer.conf file.

[Paul Eggleton]

On Sunday 02 December 2012 15:35:54 you wrote:
> On 12/02/2012 03:24 PM, Paul Eggleton wrote:
> > On Sunday 02 December 2012 14:51:28 Scott Garman wrote:
> >> Robert Day has brought up an inconsistency in the way we append to
> >> BBPATH within a couple of our layer.conf files.
> >> 
> >> In meta-hob, meta-yocto-bsp, and meta-intel, we do:
> >> 
> >> BBPATH := "${BBPATH}:${LAYERDIR}"
> >> 
> >> but in meta-yocto, we do:
> >> 
> >> BBPATH := "${LAYERDIR}:${BBPATH}"
> >> 
> >> Unless someone explains to me that it's necessary to use this different
> >> ordering in meta-yocto's layer.conf, I will submit a patch to make this
> >> more consistent.
> > 
> > I think it actually ought to be:
> > 
> > BBPATH .= ":${LAYERDIR}"
> 
> Oh? Would this apply just to meta-yocto or all layer.conf files?

All, really. Functionally it makes no real difference, but I think it's 
preferred stylistically based on previous discussions.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: Use of BBPATH in a layer.conf file.

[Robert P. J. Day]

On Sun, 2 Dec 2012, Paul Eggleton wrote:

> On Sunday 02 December 2012 15:35:54 you wrote:
> > On 12/02/2012 03:24 PM, Paul Eggleton wrote:
> > > On Sunday 02 December 2012 14:51:28 Scott Garman wrote:
> > >> Robert Day has brought up an inconsistency in the way we append to
> > >> BBPATH within a couple of our layer.conf files.
> > >>
> > >> In meta-hob, meta-yocto-bsp, and meta-intel, we do:
> > >>
> > >> BBPATH := "${BBPATH}:${LAYERDIR}"
> > >>
> > >> but in meta-yocto, we do:
> > >>
> > >> BBPATH := "${LAYERDIR}:${BBPATH}"
> > >>
> > >> Unless someone explains to me that it's necessary to use this different
> > >> ordering in meta-yocto's layer.conf, I will submit a patch to make this
> > >> more consistent.
> > >
> > > I think it actually ought to be:
> > >
> > > BBPATH .= ":${LAYERDIR}"
> >
> > Oh? Would this apply just to meta-yocto or all layer.conf files?
>
> All, really. Functionally it makes no real difference, but I think it's
> preferred stylistically based on previous discussions.

  hang on ... i thought the ordering of BBPATH would affect the
processing of "include" directives.  no?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: Use of BBPATH in a layer.conf file.

[Paul Eggleton]

On Monday 03 December 2012 03:16:10 Robert P. J. Day wrote:
> On Sun, 2 Dec 2012, Paul Eggleton wrote:
> > On Sunday 02 December 2012 15:35:54 you wrote:
> > > On 12/02/2012 03:24 PM, Paul Eggleton wrote:
> > > > On Sunday 02 December 2012 14:51:28 Scott Garman wrote:
> > > >> Robert Day has brought up an inconsistency in the way we append to
> > > >> BBPATH within a couple of our layer.conf files.
> > > >> 
> > > >> In meta-hob, meta-yocto-bsp, and meta-intel, we do:
> > > >> 
> > > >> BBPATH := "${BBPATH}:${LAYERDIR}"
> > > >> 
> > > >> but in meta-yocto, we do:
> > > >> 
> > > >> BBPATH := "${LAYERDIR}:${BBPATH}"
> > > >> 
> > > >> Unless someone explains to me that it's necessary to use this
> > > >> different
> > > >> ordering in meta-yocto's layer.conf, I will submit a patch to make
> > > >> this
> > > >> more consistent.
> > > > 
> > > > I think it actually ought to be:
> > > > 
> > > > BBPATH .= ":${LAYERDIR}"
> > > 
> > > Oh? Would this apply just to meta-yocto or all layer.conf files?
> > 
> > All, really. Functionally it makes no real difference, but I think it's
> > preferred stylistically based on previous discussions.
> 
>   hang on ... i thought the ordering of BBPATH would affect the
> processing of "include" directives.  no?

Yes, it does. What I mean is, functionally _within layer.conf_ the following 
two are equivalent:

BBPATH := "${BBPATH}:${LAYERDIR}"

BBPATH .= ":${LAYERDIR}"

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: Use of BBPATH in a layer.conf file.

[Tomas Frydrych]

On 02/12/12 22:51, Scott Garman wrote:
> Robert Day has brought up an inconsistency in the way we append to
> BBPATH within a couple of our layer.conf files.
> 
> In meta-hob, meta-yocto-bsp, and meta-intel, we do:
> 
> BBPATH := "${BBPATH}:${LAYERDIR}"
> 
> but in meta-yocto, we do:
> 
> BBPATH := "${LAYERDIR}:${BBPATH}"
> 
> Unless someone explains to me that it's necessary to use this different
> ordering in meta-yocto's layer.conf, I will submit a patch to make this
> more consistent.

This meta-yocto setup is intentional (there was thread about that a
while back). meta-yocto is a distro layer, and for any distro layer it
is reasonable to enforce its own precedence over any other layers is may
use, and meta-yocto chooses to do this. Non-distro layers, including all
bsp layers, are expected to always use an append operation so that they
can be stacked together.

Tomas

-- 
http://sleepfive.com

Re: Use of BBPATH in a layer.conf file.

[Scott Garman]

On 12/03/2012 09:43 AM, Tomas Frydrych wrote:
> On 02/12/12 22:51, Scott Garman wrote:
>> Robert Day has brought up an inconsistency in the way we append to
>> BBPATH within a couple of our layer.conf files.
>>
>> In meta-hob, meta-yocto-bsp, and meta-intel, we do:
>>
>> BBPATH := "${BBPATH}:${LAYERDIR}"
>>
>> but in meta-yocto, we do:
>>
>> BBPATH := "${LAYERDIR}:${BBPATH}"
>>
>> Unless someone explains to me that it's necessary to use this different
>> ordering in meta-yocto's layer.conf, I will submit a patch to make this
>> more consistent.
>
> This meta-yocto setup is intentional (there was thread about that a
> while back). meta-yocto is a distro layer, and for any distro layer it
> is reasonable to enforce its own precedence over any other layers is may
> use, and meta-yocto chooses to do this. Non-distro layers, including all
> bsp layers, are expected to always use an append operation so that they
> can be stacked together.

Thanks for the concise explanation.

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center