[meta-fsl-arm][PATCH] fsl-eula-unpack: Avoid unbound local exception.

[meta-fsl-arm][PATCH] fsl-eula-unpack: Avoid unbound local exception.

[alex]

From: Alex Gonzalez <alex@lindusembedded.com>

I have verified the build with imx53qsb and fsl-image-gui on the denzil
branch, and checked that firmware-imx is correctly compiled, packaged
and installed. The master branch has some unrelated issues when building
either fsl-image-gui or core-image-base at the moment.

Alex Gonzalez (1):
  fsl-eula-unpack: Avoid unbound local exception.

 classes/fsl-eula-unpack.bbclass |    1 +
 1 file changed, 1 insertion(+)

[meta-fsl-arm][PATCH] fsl-eula-unpack: Avoid unbound local exception.

[alex]

From: Alex Gonzalez <alex@lindusembedded.com>

This commit fixes an unbound local exception caused by save_cwd not
being defined when fsl-eula is not true.
---
 classes/fsl-eula-unpack.bbclass |    1 +
 1 file changed, 1 insertion(+)

diff --git a/classes/fsl-eula-unpack.bbclass b/classes/fsl-eula-unpack.bbclass
index 7a6a554..6660a88 100644
--- a/classes/fsl-eula-unpack.bbclass
+++ b/classes/fsl-eula-unpack.bbclass
@@ -18,6 +18,7 @@ python fsl_bin_do_unpack() {
     fetcher = bb.fetch2.Fetch(src_uri, localdata)
 
     for url in fetcher.ud.values():
+        save_cwd = os.getcwd()
         # Check for supported fetchers
         if url.type in ['http', 'https', 'ftp', 'file']:
             if url.parm.get('fsl-eula', False):

Re: [meta-fsl-arm][PATCH] fsl-eula-unpack: Avoid unbound local exception.

[Daiane Angolini]

On 12/04/2012 08:22 AM, alex@lindusembedded.com wrote:
> From: Alex Gonzalez <alex@lindusembedded.com>
>
> This commit fixes an unbound local exception caused by save_cwd not
> being defined when fsl-eula is not true.
> ---
Thanks a lot for the patch.

Which board did you test?
(I will test for another one)

Daiane

>   classes/fsl-eula-unpack.bbclass |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/classes/fsl-eula-unpack.bbclass b/classes/fsl-eula-unpack.bbclass
> index 7a6a554..6660a88 100644
> --- a/classes/fsl-eula-unpack.bbclass
> +++ b/classes/fsl-eula-unpack.bbclass
> @@ -18,6 +18,7 @@ python fsl_bin_do_unpack() {
>       fetcher = bb.fetch2.Fetch(src_uri, localdata)
>
>       for url in fetcher.ud.values():
> +        save_cwd = os.getcwd()
>           # Check for supported fetchers
>           if url.type in ['http', 'https', 'ftp', 'file']:
>               if url.parm.get('fsl-eula', False):
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>

Re: [meta-fsl-arm][PATCH] fsl-eula-unpack: Avoid unbound local exception.

[Alex Gonzalez]

I tested on the imx53 QSB.
Alex

On Tue, Dec 4, 2012 at 11:41 AM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 12/04/2012 08:22 AM, alex@lindusembedded.com wrote:
>>
>> From: Alex Gonzalez <alex@lindusembedded.com>
>>
>> This commit fixes an unbound local exception caused by save_cwd not
>> being defined when fsl-eula is not true.
>> ---
>
> Thanks a lot for the patch.
>
> Which board did you test?
> (I will test for another one)
>
> Daiane
>
>>   classes/fsl-eula-unpack.bbclass |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/classes/fsl-eula-unpack.bbclass
>> b/classes/fsl-eula-unpack.bbclass
>> index 7a6a554..6660a88 100644
>> --- a/classes/fsl-eula-unpack.bbclass
>> +++ b/classes/fsl-eula-unpack.bbclass
>> @@ -18,6 +18,7 @@ python fsl_bin_do_unpack() {
>>       fetcher = bb.fetch2.Fetch(src_uri, localdata)
>>
>>       for url in fetcher.ud.values():
>> +        save_cwd = os.getcwd()
>>           # Check for supported fetchers
>>           if url.type in ['http', 'https', 'ftp', 'file']:
>>               if url.parm.get('fsl-eula', False):
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
>>
>
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-fsl-arm][PATCH] fsl-eula-unpack: Avoid unbound local exception.

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

On Tue, Dec 4, 2012 at 8:22 AM, <alex@lindusembedded.com> wrote:

> From: Alex Gonzalez <alex@lindusembedded.com>
>
> This commit fixes an unbound local exception caused by save_cwd not
> being defined when fsl-eula is not true.
>

Thanks by doing it.

I applied it to denzil and master branches.

An small detail, next time use '-s' when commiting so you include your
signed-off-by line.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[-- Attachment #2: Type: text/html, Size: 1316 bytes --]