* [PATCH V1] initscripts/urandom: create directory before staging into it
@ 2012-12-05 7:57 Ming Liu
2012-12-05 19:30 ` Saul Wold
0 siblings, 1 reply; 5+ messages in thread
From: Ming Liu @ 2012-12-05 7:57 UTC (permalink / raw)
To: openembedded-core
/etc/init.d/urandom fails to start/stop because it tries to save
random-seed into /var/lib/urandom folder which does not exist in the
file system.
Fixed by creating /var/lib/urandom at do_install time.
Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index d25838b..39be9a8 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system startup initialization scrip
SECTION = "base"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
-PR = "r137"
+PR = "r138"
INHIBIT_DEFAULT_DEPS = "1"
@@ -133,4 +133,6 @@ do_install () {
fi
install -m 0755 ${WORKDIR}/device_table.txt ${D}${sysconfdir}/device_table
+ # Holds state information pertaining to urandom
+ install -d ${D}/var/lib/urandom
}
--
1.7.11
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V1] initscripts/urandom: create directory before staging into it
2012-12-05 7:57 [PATCH V1] initscripts/urandom: create directory before staging into it Ming Liu
@ 2012-12-05 19:30 ` Saul Wold
2012-12-06 1:41 ` Ming Liu
2012-12-06 2:22 ` ChenQi
0 siblings, 2 replies; 5+ messages in thread
From: Saul Wold @ 2012-12-05 19:30 UTC (permalink / raw)
To: Ming Liu; +Cc: openembedded-core
On 12/04/2012 11:57 PM, Ming Liu wrote:
> /etc/init.d/urandom fails to start/stop because it tries to save
> random-seed into /var/lib/urandom folder which does not exist in the
> file system.
>
> Fixed by creating /var/lib/urandom at do_install time.
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
> meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
> index d25838b..39be9a8 100644
> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
> @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system startup initialization scrip
> SECTION = "base"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
> -PR = "r137"
> +PR = "r138"
>
> INHIBIT_DEFAULT_DEPS = "1"
>
> @@ -133,4 +133,6 @@ do_install () {
> fi
>
> install -m 0755 ${WORKDIR}/device_table.txt ${D}${sysconfdir}/device_table
> + # Holds state information pertaining to urandom
> + install -d ${D}/var/lib/urandom
I thought this would go in volatiles, not here.
Sau!
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] initscripts/urandom: create directory before staging into it
2012-12-05 19:30 ` Saul Wold
@ 2012-12-06 1:41 ` Ming Liu
2012-12-06 2:22 ` ChenQi
1 sibling, 0 replies; 5+ messages in thread
From: Ming Liu @ 2012-12-06 1:41 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]
On 12/06/2012 03:30 AM, Saul Wold wrote:
> On 12/04/2012 11:57 PM, Ming Liu wrote:
>> /etc/init.d/urandom fails to start/stop because it tries to save
>> random-seed into /var/lib/urandom folder which does not exist in the
>> file system.
>>
>> Fixed by creating /var/lib/urandom at do_install time.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>> meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb
>> b/meta/recipes-core/initscripts/initscripts_1.0.bb
>> index d25838b..39be9a8 100644
>> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
>> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
>> @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system
>> startup initialization scrip
>> SECTION = "base"
>> LICENSE = "GPLv2"
>> LIC_FILES_CHKSUM =
>> "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>> -PR = "r137"
>> +PR = "r138"
>>
>> INHIBIT_DEFAULT_DEPS = "1"
>>
>> @@ -133,4 +133,6 @@ do_install () {
>> fi
>>
>> install -m 0755 ${WORKDIR}/device_table.txt
>> ${D}${sysconfdir}/device_table
>> + # Holds state information pertaining to urandom
>> + install -d ${D}/var/lib/urandom
>
> I thought this would go in volatiles, not here.
Yes, it's a alternative solution or maybe better.
I was going to put it into volatiles, but considering it's a urandom
specific directory, so I eventually put it here.
OK, I will send the V2 as you suggest.
>
> Sau!
>
>> }
>>
>
>
[-- Attachment #2: Type: text/html, Size: 4277 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] initscripts/urandom: create directory before staging into it
2012-12-05 19:30 ` Saul Wold
2012-12-06 1:41 ` Ming Liu
@ 2012-12-06 2:22 ` ChenQi
2012-12-07 5:33 ` Ming Liu
1 sibling, 1 reply; 5+ messages in thread
From: ChenQi @ 2012-12-06 2:22 UTC (permalink / raw)
To: openembedded-core
On 12/06/2012 03:30 AM, Saul Wold wrote:
> On 12/04/2012 11:57 PM, Ming Liu wrote:
>> /etc/init.d/urandom fails to start/stop because it tries to save
>> random-seed into /var/lib/urandom folder which does not exist in the
>> file system.
>>
>> Fixed by creating /var/lib/urandom at do_install time.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>> meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb
>> b/meta/recipes-core/initscripts/initscripts_1.0.bb
>> index d25838b..39be9a8 100644
>> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
>> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
>> @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system
>> startup initialization scrip
>> SECTION = "base"
>> LICENSE = "GPLv2"
>> LIC_FILES_CHKSUM =
>> "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>> -PR = "r137"
>> +PR = "r138"
>>
>> INHIBIT_DEFAULT_DEPS = "1"
>>
>> @@ -133,4 +133,6 @@ do_install () {
>> fi
>>
>> install -m 0755 ${WORKDIR}/device_table.txt
>> ${D}${sysconfdir}/device_table
>> + # Holds state information pertaining to urandom
>> + install -d ${D}/var/lib/urandom
>
> I thought this would go in volatiles, not here.
>
> Sau!
>
Hi Saul,
From my understanding, volatiles is a configuration file which deals
with files related with volatile storage.
Files, directories and links related to volatile storage should be in
this file, as it's a final method to check and make sure they are
created properly. But files under /var/lib should not there.
So in my option, this patch is ok.
Thanks,
Chen Qi
>> }
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] initscripts/urandom: create directory before staging into it
2012-12-06 2:22 ` ChenQi
@ 2012-12-07 5:33 ` Ming Liu
0 siblings, 0 replies; 5+ messages in thread
From: Ming Liu @ 2012-12-07 5:33 UTC (permalink / raw)
To: openembedded-core, Saul Wold
On 12/06/2012 10:22 AM, ChenQi wrote:
> On 12/06/2012 03:30 AM, Saul Wold wrote:
>> On 12/04/2012 11:57 PM, Ming Liu wrote:
>>> /etc/init.d/urandom fails to start/stop because it tries to save
>>> random-seed into /var/lib/urandom folder which does not exist in the
>>> file system.
>>>
>>> Fixed by creating /var/lib/urandom at do_install time.
>>>
>>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>>> ---
>>> meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb
>>> b/meta/recipes-core/initscripts/initscripts_1.0.bb
>>> index d25838b..39be9a8 100644
>>> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
>>> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
>>> @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system
>>> startup initialization scrip
>>> SECTION = "base"
>>> LICENSE = "GPLv2"
>>> LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>>> -PR = "r137"
>>> +PR = "r138"
>>>
>>> INHIBIT_DEFAULT_DEPS = "1"
>>>
>>> @@ -133,4 +133,6 @@ do_install () {
>>> fi
>>>
>>> install -m 0755 ${WORKDIR}/device_table.txt
>>> ${D}${sysconfdir}/device_table
>>> + # Holds state information pertaining to urandom
>>> + install -d ${D}/var/lib/urandom
>>
>> I thought this would go in volatiles, not here.
>>
>> Sau!
>>
> Hi Saul,
>
> From my understanding, volatiles is a configuration file which deals
> with files related with volatile storage.
> Files, directories and links related to volatile storage should be in
> this file, as it's a final method to check and make sure they are
> created properly. But files under /var/lib should not there.
Hi, Saul:
Any comments? Should I send the V2 (put it into volatiles)?
the best,
thank you
>
> So in my option, this patch is ok.
>
> Thanks,
> Chen Qi
>
>>> }
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-07 5:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 7:57 [PATCH V1] initscripts/urandom: create directory before staging into it Ming Liu
2012-12-05 19:30 ` Saul Wold
2012-12-06 1:41 ` Ming Liu
2012-12-06 2:22 ` ChenQi
2012-12-07 5:33 ` Ming Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.