From: Jaehoon Chung <jh80.chung@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org, ben-linux@fluff.org,
patches@linaro.org
Subject: Re: [PATCH 1/1] mmc: sdhci-s3c: Fix compilation warning
Date: Thu, 06 Dec 2012 13:13:57 +0900 [thread overview]
Message-ID: <50C01B85.5060502@samsung.com> (raw)
In-Reply-To: <1354620787-20575-1-git-send-email-sachin.kamat@linaro.org>
It looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 12/04/2012 08:33 PM, Sachin Kamat wrote:
> 'sc' is used only when CONFIG_PM_RUNTIME is defined. Hence define it
> conditionally.
>
> Silences the following warning:
> drivers/mmc/host/sdhci-s3c.c: In function ‘sdhci_s3c_notify_change’:
> drivers/mmc/host/sdhci-s3c.c:378:20: warning: unused variable ‘sc’ [-Wunused-variable]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mmc/host/sdhci-s3c.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 7ea3aea..82a8de1 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -375,7 +375,9 @@ static struct sdhci_ops sdhci_s3c_ops = {
> static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
> {
> struct sdhci_host *host = platform_get_drvdata(dev);
> +#ifdef CONFIG_PM_RUNTIME
> struct sdhci_s3c *sc = sdhci_priv(host);
> +#endif
> unsigned long flags;
>
> if (host) {
>
prev parent reply other threads:[~2012-12-06 4:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 11:33 [PATCH 1/1] mmc: sdhci-s3c: Fix compilation warning Sachin Kamat
2012-12-06 4:13 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C01B85.5060502@samsung.com \
--to=jh80.chung@samsung.com \
--cc=ben-linux@fluff.org \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.