* [PATCH 1/1] mmc: sdhci-s3c: Fix compilation warning
@ 2012-12-04 11:33 Sachin Kamat
2012-12-06 4:13 ` Jaehoon Chung
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2012-12-04 11:33 UTC (permalink / raw)
To: linux-mmc; +Cc: cjb, ben-linux, sachin.kamat, patches
'sc' is used only when CONFIG_PM_RUNTIME is defined. Hence define it
conditionally.
Silences the following warning:
drivers/mmc/host/sdhci-s3c.c: In function ‘sdhci_s3c_notify_change’:
drivers/mmc/host/sdhci-s3c.c:378:20: warning: unused variable ‘sc’ [-Wunused-variable]
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mmc/host/sdhci-s3c.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 7ea3aea..82a8de1 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -375,7 +375,9 @@ static struct sdhci_ops sdhci_s3c_ops = {
static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
{
struct sdhci_host *host = platform_get_drvdata(dev);
+#ifdef CONFIG_PM_RUNTIME
struct sdhci_s3c *sc = sdhci_priv(host);
+#endif
unsigned long flags;
if (host) {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] mmc: sdhci-s3c: Fix compilation warning
2012-12-04 11:33 [PATCH 1/1] mmc: sdhci-s3c: Fix compilation warning Sachin Kamat
@ 2012-12-06 4:13 ` Jaehoon Chung
0 siblings, 0 replies; 2+ messages in thread
From: Jaehoon Chung @ 2012-12-06 4:13 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-mmc, cjb, ben-linux, patches
It looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 12/04/2012 08:33 PM, Sachin Kamat wrote:
> 'sc' is used only when CONFIG_PM_RUNTIME is defined. Hence define it
> conditionally.
>
> Silences the following warning:
> drivers/mmc/host/sdhci-s3c.c: In function ‘sdhci_s3c_notify_change’:
> drivers/mmc/host/sdhci-s3c.c:378:20: warning: unused variable ‘sc’ [-Wunused-variable]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mmc/host/sdhci-s3c.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 7ea3aea..82a8de1 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -375,7 +375,9 @@ static struct sdhci_ops sdhci_s3c_ops = {
> static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
> {
> struct sdhci_host *host = platform_get_drvdata(dev);
> +#ifdef CONFIG_PM_RUNTIME
> struct sdhci_s3c *sc = sdhci_priv(host);
> +#endif
> unsigned long flags;
>
> if (host) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-06 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-04 11:33 [PATCH 1/1] mmc: sdhci-s3c: Fix compilation warning Sachin Kamat
2012-12-06 4:13 ` Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.