All of lore.kernel.org
 help / color / mirror / Atom feed
From: Orit Wasserman <owasserm@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] arch_init/ram_load: add error message for block length mismatch
Date: Thu, 06 Dec 2012 14:18:33 +0200	[thread overview]
Message-ID: <50C08D19.1030109@redhat.com> (raw)
In-Reply-To: <1354795700-3052-1-git-send-email-alevy@redhat.com>

On 12/06/2012 02:08 PM, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> Please ignore previous version, accidentally removed goto done and used wrong
> format size specifiers.
missed that too, but I'm adding better error messages anyway :)
> 
>  arch_init.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch_init.c b/arch_init.c
> index e6effe8..fba24f3 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -808,6 +808,9 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
>                      QLIST_FOREACH(block, &ram_list.blocks, next) {
>                          if (!strncmp(id, block->idstr, sizeof(id))) {
>                              if (block->length != length) {
> +                                fprintf(stderr, "Length mismatch: %s: %ld "
> +                                        "in != %ld\n", id, length,
> +                                        block->length);
>                                  ret =  -EINVAL;
>                                  goto done;
>                              }
> 



WARNING: multiple messages have this Message-ID (diff)
From: Orit Wasserman <owasserm@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] arch_init/ram_load: add error message for block length mismatch
Date: Thu, 06 Dec 2012 14:18:33 +0200	[thread overview]
Message-ID: <50C08D19.1030109@redhat.com> (raw)
In-Reply-To: <1354795700-3052-1-git-send-email-alevy@redhat.com>

On 12/06/2012 02:08 PM, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> Please ignore previous version, accidentally removed goto done and used wrong
> format size specifiers.
missed that too, but I'm adding better error messages anyway :)
> 
>  arch_init.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch_init.c b/arch_init.c
> index e6effe8..fba24f3 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -808,6 +808,9 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
>                      QLIST_FOREACH(block, &ram_list.blocks, next) {
>                          if (!strncmp(id, block->idstr, sizeof(id))) {
>                              if (block->length != length) {
> +                                fprintf(stderr, "Length mismatch: %s: %ld "
> +                                        "in != %ld\n", id, length,
> +                                        block->length);
>                                  ret =  -EINVAL;
>                                  goto done;
>                              }
> 

  reply	other threads:[~2012-12-06 12:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06 12:02 [Qemu-trivial] [PATCH] arch_init/ram_load: add error message for block length mismatch Alon Levy
2012-12-06 12:02 ` [Qemu-devel] " Alon Levy
2012-12-06 12:08 ` [Qemu-trivial] [PATCH v2] " Alon Levy
2012-12-06 12:08   ` [Qemu-devel] " Alon Levy
2012-12-06 12:18   ` Orit Wasserman [this message]
2012-12-06 12:18     ` Orit Wasserman
2012-12-18 16:00   ` [Qemu-trivial] " Stefan Hajnoczi
2012-12-18 16:00     ` Stefan Hajnoczi
2012-12-06 12:11 ` [Qemu-trivial] [Qemu-devel] [PATCH] " Orit Wasserman
2012-12-06 12:11   ` Orit Wasserman
2012-12-06 12:17   ` [Qemu-trivial] " Alon Levy
2012-12-06 12:17     ` Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C08D19.1030109@redhat.com \
    --to=owasserm@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.