All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jeff Moyer <jmoyer@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Zach Brown <zab@redhat.com>, Peter Zijlstra <pzijlstr@redhat.com>,
	Ingo <mingo@redhat.com>
Subject: Re: [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads
Date: Thu, 6 Dec 2012 19:19:34 +0100	[thread overview]
Message-ID: <50C0E1B6.5060602@fusionio.com> (raw)
In-Reply-To: <20121206180150.GQ19802@htj.dyndns.org>

On 2012-12-06 19:01, Tejun Heo wrote:
> As for the original patch, I think it's a bit too much to expose to
> userland.  It's probably a good idea to bind the flusher to the local
> node but do we really need to expose an interface to let userland
> control the affinity directly?  Do we actually have a use case at
> hand?

We need to expose it. Once the binding is set from the kernel side on a
kernel thread, it can't be modified.

Binding either for performance reasons or for ensuring that we
explicitly don't run in some places is a very useful feature.

-- 
Jens Axboe

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jaxboe@fusionio.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jeff Moyer <jmoyer@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Zach Brown <zab@redhat.com>, Peter Zijlstra <pzijlstr@redhat.com>,
	Ingo <mingo@redhat.com>
Subject: Re: [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads
Date: Thu, 6 Dec 2012 19:19:34 +0100	[thread overview]
Message-ID: <50C0E1B6.5060602@fusionio.com> (raw)
In-Reply-To: <20121206180150.GQ19802@htj.dyndns.org>

On 2012-12-06 19:01, Tejun Heo wrote:
> As for the original patch, I think it's a bit too much to expose to
> userland.  It's probably a good idea to bind the flusher to the local
> node but do we really need to expose an interface to let userland
> control the affinity directly?  Do we actually have a use case at
> hand?

We need to expose it. Once the binding is set from the kernel side on a
kernel thread, it can't be modified.

Binding either for performance reasons or for ensuring that we
explicitly don't run in some places is a very useful feature.

-- 
Jens Axboe


  parent reply	other threads:[~2012-12-06 18:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 18:53 [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads Jeff Moyer
2012-12-03 18:53 ` Jeff Moyer
2012-12-04  2:34 ` Dave Chinner
2012-12-04  2:34   ` Dave Chinner
2012-12-04 14:42   ` Jeff Moyer
2012-12-04 14:42     ` Jeff Moyer
2012-12-04 20:35     ` Dave Chinner
2012-12-04 20:35       ` Dave Chinner
2012-12-04 20:14 ` Jens Axboe
2012-12-04 20:14   ` Jens Axboe
2012-12-04 20:23   ` Jeff Moyer
2012-12-04 20:23     ` Jeff Moyer
2012-12-04 20:27     ` Jens Axboe
2012-12-04 20:27       ` Jens Axboe
2012-12-04 22:26       ` Jeff Moyer
2012-12-04 22:26         ` Jeff Moyer
2012-12-05  7:43         ` Jens Axboe
2012-12-05  7:43           ` Jens Axboe
2012-12-06 18:01         ` Tejun Heo
2012-12-06 18:01           ` Tejun Heo
2012-12-06 18:08           ` Jeff Moyer
2012-12-06 18:08             ` Jeff Moyer
2012-12-06 18:13             ` Tejun Heo
2012-12-06 18:13               ` Tejun Heo
2012-12-06 18:19           ` Jens Axboe [this message]
2012-12-06 18:19             ` Jens Axboe
2012-12-06 18:22             ` Tejun Heo
2012-12-06 18:22               ` Tejun Heo
2012-12-06 18:33               ` Jeff Moyer
2012-12-06 18:33                 ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C0E1B6.5060602@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=pzijlstr@redhat.com \
    --cc=tj@kernel.org \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.