[Buildroot] [PATCH] fix cjson package

[Buildroot] [PATCH] fix cjson package

[Viallard Anthony]

Hi buildroot guys,

I've try to use cjson package but there a download problem. So, I fix up 
the package Makefile and here the change :


diff --git a/package/cjson/cjson.mk b/package/cjson/cjson.mk
index ccc6010..728639d 100644
--- a/package/cjson/cjson.mk
+++ b/package/cjson/cjson.mk
@@ -3,8 +3,8 @@
  # cjson
  #
  #############################################################
-CJSON_VERSION         = undefined
-CJSON_SOURCE          = cJSONFiles.zip
+CJSON_VERSION         = 2011-10-10
+CJSON_SOURCE          = cJSONFiles-$(CJSON_VERSION).zip
  CJSON_SITE            = http://downloads.sourceforge.net/project/cjson/
  CJSON_INSTALL_STAGING = YES
  CJSON_LICENSE         = MIT


Cheers,
Viallard Anthony.

[Buildroot] [PATCH] fix cjson package

[Danomi Manchego]

Viallard,

> -CJSON_VERSION         = undefined
> -CJSON_SOURCE          = cJSONFiles.zip
> +CJSON_VERSION         = 2011-10-10
> +CJSON_SOURCE          = cJSONFiles-$(CJSON_VERSION).zip
>  CJSON_SITE            = http://downloads.sourceforge.net/project/cjson/

This worked for you?  It doesn't work for me ... i.e. this line works for me:

    wget http://downloads.sourceforge.net/project/cjson/cJSONFiles.zip

but this line gives me ERROR 404 Not Found:

    wget http://downloads.sourceforge.net/project/cjson/cJSONFiles-2011-10-10.zip

Am I missing something here?

Danomi -

[Buildroot] [PATCH] fix cjson package

[Viallard Anthony]

On 07. 12. 12 03:14, Danomi Manchego wrote:
> Viallard,
>
>> -CJSON_VERSION         = undefined
>> -CJSON_SOURCE          = cJSONFiles.zip
>> +CJSON_VERSION         = 2011-10-10
>> +CJSON_SOURCE          = cJSONFiles-$(CJSON_VERSION).zip
>>   CJSON_SITE            = http://downloads.sourceforge.net/project/cjson/
> This worked for you?  It doesn't work for me ... i.e. this line works for me:
>
>      wget http://downloads.sourceforge.net/project/cjson/cJSONFiles.zip
>
> but this line gives me ERROR 404 Not Found:
>
>      wget http://downloads.sourceforge.net/project/cjson/cJSONFiles-2011-10-10.zip
>
> Am I missing something here?
>
> Danomi -
Actually, "wget 
http://downloads.sourceforge.net/project/cjson/cJSONFiles.zip" works and 
the other link not indeed. I just realize I've a "Backup download site" 
with cJSONFiles-2011-10-10.zip on it ...

But there really a problem when buildroot trying to download the file :

-----------------------
avd at avd-box:~/wksp/buildroot$ make cjson-build
 >>> cjson undefined Downloading
--2012-12-07 09:24:34--  http://192.168.2.17/files/buildroot/cJSONFiles.zip
Connexion vers 192.168.2.17:80...connect?.
requ?te HTTP transmise, en attente de la r?ponse...404 Not Found
2012-12-07 09:24:34 ERREUR 404: Not Found.

--2012-12-07 09:24:34--  
http://downloads.sourceforge.net/project/cjson//cJSONFiles.zip
R?solution de downloads.sourceforge.net (downloads.sourceforge.net)... 
216.34.181.59
Connexion vers downloads.sourceforge.net 
(downloads.sourceforge.net)|216.34.181.59|:80...connect?.
requ?te HTTP transmise, en attente de la r?ponse...404 Not Found
2012-12-07 09:24:35 ERREUR 404: Not Found.

--2012-12-07 09:24:35--  http://192.168.2.17/files/buildroot/cJSONFiles.zip
Connexion vers 192.168.2.17:80...connect?.
requ?te HTTP transmise, en attente de la r?ponse...404 Not Found
2012-12-07 09:24:35 ERREUR 404: Not Found.

make: *** 
[/home/avd/wksp/buildroot/output/build/cjson-undefined/.stamp_downloaded] Erreur 
1
-----------------------

And i know now what is the actual issue. Here the good big fix :

---
  package/cjson/cjson.mk |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/cjson/cjson.mk b/package/cjson/cjson.mk
index ccc6010..55af800 100644
--- a/package/cjson/cjson.mk
+++ b/package/cjson/cjson.mk
@@ -5,7 +5,7 @@
  #############################################################
  CJSON_VERSION         = undefined
  CJSON_SOURCE          = cJSONFiles.zip
-CJSON_SITE            = http://downloads.sourceforge.net/project/cjson/
+CJSON_SITE            = http://downloads.sourceforge.net/project/cjson
  CJSON_INSTALL_STAGING = YES
  CJSON_LICENSE         = MIT

-- 
1.7.10.4

Cheers,
avd.

[Buildroot] [PATCH] fix cjson package

[Danomi Manchego]

On Fri, Dec 7, 2012 at 3:41 AM, Viallard Anthony
<viallard@syscom-instruments.com> wrote:
> And i know now what is the actual issue. Here the good big fix :
>
> ---
>  package/cjson/cjson.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/cjson/cjson.mk b/package/cjson/cjson.mk
> index ccc6010..55af800 100644
> --- a/package/cjson/cjson.mk
> +++ b/package/cjson/cjson.mk
> @@ -5,7 +5,7 @@
>  #############################################################
>  CJSON_VERSION         = undefined
>  CJSON_SOURCE          = cJSONFiles.zip
> -CJSON_SITE            = http://downloads.sourceforge.net/project/cjson/
> +CJSON_SITE            = http://downloads.sourceforge.net/project/cjson
>
>  CJSON_INSTALL_STAGING = YES
>  CJSON_LICENSE         = MIT
>
> --
> 1.7.10.4

I'm not sure if Peter needs you to send the good fix as a
git-send-email'ed V2, but:

Acked-by: Danomi Manchego <danomimanchego123@gmail.com>

[Buildroot] [PATCH] fix cjson package

[Peter Korsgaard]

>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:

Hi,

 Danomi> I'm not sure if Peter needs you to send the good fix as a
 Danomi> git-send-email'ed V2, but:

 Danomi> Acked-by: Danomi Manchego <danomimanchego123@gmail.com>

Yes, preferably - But I've created a git commit myself for this -
Thanks.

-- 
Bye, Peter Korsgaard