From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org, Thomas Graf <tgraf@suug.ch>,
Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [patch v2] bridge: make buffer larger in br_setlink()
Date: Fri, 07 Dec 2012 20:15:42 +0100 [thread overview]
Message-ID: <50C2405E.1070904@bfs.de> (raw)
In-Reply-To: <20121207185359.GP22569@mwanda>
Am 07.12.2012 19:53, schrieb Dan Carpenter:
> On Fri, Dec 07, 2012 at 05:07:24PM +0100, walter harms wrote:
>>
>>
>> Am 07.12.2012 12:10, schrieb Dan Carpenter:
>>> We pass IFLA_BRPORT_MAX to nla_parse_nested() so we need
>>> IFLA_BRPORT_MAX + 1 elements. Also Smatch complains that we read past
>>> the end of the array when in br_set_port_flag() when it's called with
>>> IFLA_BRPORT_FAST_LEAVE.
>>>
>>
>>
>>
>> I have no clue why nla_parse_nested() need IFLA_BRPORT_MAX elements.
>> but the majory of loop look like
>> for(i=0;i<max;++)
>> most programmers will think this way.
>> So it seems the place to fix is nla_parse_nested().
>> doing not so is asking for trouble (in the long run).
>> At least this function needs a big warning label that (max-1)
>> is actually needed.
>>
>
> Yeah, nla_parse_nested() is actually documented already.
>
documenting unexspected behavier is not as much helpfull as changing it.
just my 2 cents,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, Thomas Graf <tgraf@suug.ch>
Subject: Re: [patch v2] bridge: make buffer larger in br_setlink()
Date: Fri, 07 Dec 2012 19:15:42 +0000 [thread overview]
Message-ID: <50C2405E.1070904@bfs.de> (raw)
In-Reply-To: <20121207185359.GP22569@mwanda>
Am 07.12.2012 19:53, schrieb Dan Carpenter:
> On Fri, Dec 07, 2012 at 05:07:24PM +0100, walter harms wrote:
>>
>>
>> Am 07.12.2012 12:10, schrieb Dan Carpenter:
>>> We pass IFLA_BRPORT_MAX to nla_parse_nested() so we need
>>> IFLA_BRPORT_MAX + 1 elements. Also Smatch complains that we read past
>>> the end of the array when in br_set_port_flag() when it's called with
>>> IFLA_BRPORT_FAST_LEAVE.
>>>
>>
>>
>>
>> I have no clue why nla_parse_nested() need IFLA_BRPORT_MAX elements.
>> but the majory of loop look like
>> for(i=0;i<max;++)
>> most programmers will think this way.
>> So it seems the place to fix is nla_parse_nested().
>> doing not so is asking for trouble (in the long run).
>> At least this function needs a big warning label that (max-1)
>> is actually needed.
>>
>
> Yeah, nla_parse_nested() is actually documented already.
>
documenting unexspected behavier is not as much helpfull as changing it.
just my 2 cents,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, Thomas Graf <tgraf@suug.ch>
Subject: Re: [patch v2] bridge: make buffer larger in br_setlink()
Date: Fri, 07 Dec 2012 20:15:42 +0100 [thread overview]
Message-ID: <50C2405E.1070904@bfs.de> (raw)
In-Reply-To: <20121207185359.GP22569@mwanda>
Am 07.12.2012 19:53, schrieb Dan Carpenter:
> On Fri, Dec 07, 2012 at 05:07:24PM +0100, walter harms wrote:
>>
>>
>> Am 07.12.2012 12:10, schrieb Dan Carpenter:
>>> We pass IFLA_BRPORT_MAX to nla_parse_nested() so we need
>>> IFLA_BRPORT_MAX + 1 elements. Also Smatch complains that we read past
>>> the end of the array when in br_set_port_flag() when it's called with
>>> IFLA_BRPORT_FAST_LEAVE.
>>>
>>
>>
>>
>> I have no clue why nla_parse_nested() need IFLA_BRPORT_MAX elements.
>> but the majory of loop look like
>> for(i=0;i<max;++)
>> most programmers will think this way.
>> So it seems the place to fix is nla_parse_nested().
>> doing not so is asking for trouble (in the long run).
>> At least this function needs a big warning label that (max-1)
>> is actually needed.
>>
>
> Yeah, nla_parse_nested() is actually documented already.
>
documenting unexspected behavier is not as much helpfull as changing it.
just my 2 cents,
wh
next prev parent reply other threads:[~2012-12-07 19:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 6:18 [Bridge] [patch] bridge: make buffer larger in br_setlink() Dan Carpenter
2012-12-07 6:18 ` Dan Carpenter
2012-12-07 6:18 ` Dan Carpenter
2012-12-07 9:31 ` [Bridge] " Thomas Graf
2012-12-07 9:31 ` Thomas Graf
2012-12-07 9:31 ` Thomas Graf
2012-12-07 11:10 ` [Bridge] [patch v2] " Dan Carpenter
2012-12-07 11:10 ` Dan Carpenter
2012-12-07 11:10 ` Dan Carpenter
2012-12-07 16:07 ` [Bridge] " walter harms
2012-12-07 16:07 ` walter harms
2012-12-07 16:07 ` walter harms
2012-12-07 18:53 ` [Bridge] " Dan Carpenter
2012-12-07 18:53 ` Dan Carpenter
2012-12-07 18:53 ` Dan Carpenter
2012-12-07 19:15 ` walter harms [this message]
2012-12-07 19:15 ` walter harms
2012-12-07 19:15 ` walter harms
2012-12-07 17:08 ` [Bridge] " Stephen Hemminger
2012-12-07 17:08 ` Stephen Hemminger
2012-12-07 17:08 ` Stephen Hemminger
2012-12-07 19:40 ` [Bridge] " David Miller
2012-12-07 19:40 ` David Miller
2012-12-07 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C2405E.1070904@bfs.de \
--to=wharms@bfs.de \
--cc=bridge@lists.linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.