From: "Andreas Färber" <afaerber@suse.de>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: correctly align types in thunking code
Date: Sat, 08 Dec 2012 17:55:59 +0100 [thread overview]
Message-ID: <50C3711F.9050508@suse.de> (raw)
In-Reply-To: <1354979928-19000-1-git-send-email-laurent@vivier.eu>
Am 08.12.2012 16:18, schrieb Laurent Vivier:
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> thunk.h | 22 +++++++++++++++++-----
> 1 file changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/thunk.h b/thunk.h
> index 87025c3..d3e9f3d 100644
> --- a/thunk.h
> +++ b/thunk.h
> @@ -151,20 +151,32 @@ static inline int thunk_type_align(const argtype *type_ptr, int is_host)
> case TYPE_CHAR:
> return 1;
> case TYPE_SHORT:
> - return 2;
> + if (is_host) {
> + return __alignof__(short);
Might __alignof__() depend on a certain GCC version? Is it supported by
clang?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-08 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 15:18 [Qemu-devel] [PATCH] linux-user: correctly align types in thunking code Laurent Vivier
2012-12-08 16:40 ` Peter Maydell
2012-12-08 17:10 ` Laurent Vivier
2012-12-08 16:55 ` Andreas Färber [this message]
2012-12-08 17:13 ` Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2012-12-20 20:55 Laurent Vivier
2013-01-01 23:08 ` Laurent Vivier
2018-05-10 20:59 Laurent Vivier
2018-05-11 10:43 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C3711F.9050508@suse.de \
--to=afaerber@suse.de \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.