[PATCH 1/5] kbuild: remove deprecated use of defined in timeconst.pl

[PATCH 1/5] kbuild: remove deprecated use of defined in timeconst.pl

[pefoley2]

From: Peter Foley <pefoley2@verizon.net>

Fix this warning by removing a unneeded use of defined

TIMEC   kernel/timeconst.h
defined(@array) is deprecated at kernel/timeconst.pl line 373.
  	(Maybe you should just omit the defined()?)

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 kernel/timeconst.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl
index eb51d76..0461239 100644
--- a/kernel/timeconst.pl
+++ b/kernel/timeconst.pl
@@ -370,7 +370,7 @@ if ($hz eq '--can') {
 	}
 
 	@val = @{$canned_values{$hz}};
-	if (!defined(@val)) {
+	if (!@val) {
 		@val = compute_values($hz);
 	}
 	output($hz, @val);
-- 
1.8.0

[PATCH 2/5] kbuild: silence rule for extra_certificates

[pefoley2]

From: Peter Foley <pefoley2@verizon.net>

Silence the touch extra_certificates command

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 kernel/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/Makefile b/kernel/Makefile
index 86e3285..18a0b61 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -137,7 +137,7 @@ ifeq ($(CONFIG_MODULE_SIG),y)
 # Pull the signing certificate and any extra certificates into the kernel
 #
 extra_certificates:
-	touch $@
+	@touch $@
 
 kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
 
-- 
1.8.0

Re: [PATCH 2/5] kbuild: silence rule for extra_certificates

[Michal Marek]

Added David and Rusty.

On Sun, Nov 18, 2012 at 03:05:14PM -0500, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
> 
> Silence the touch extra_certificates command
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>

I think we should tell the user that the default empty extra
certificates list is being used, in case the user used a wrong filename
or similar. How about this?

Subject: MODSIGN: Fix kbuild output when using default extra_certificates

Signed-off-by: Michal Marek <mmarek@suse.cz>

diff --git a/kernel/Makefile b/kernel/Makefile
index 0dfeca4..8c708e4 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -136,8 +136,12 @@ ifeq ($(CONFIG_MODULE_SIG),y)
 #
 # Pull the signing certificate and any extra certificates into the kernel
 #
+
+quiet_cmd_touch = TOUCH   $@
+      cmd_touch = touch   $@
+
 extra_certificates:
-	touch $@
+	$(call cmd,touch)
 
 kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
 
But I don't insist on the above, feel free to hide the command
completely.

Michal

> ---
>  kernel/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 86e3285..18a0b61 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -137,7 +137,7 @@ ifeq ($(CONFIG_MODULE_SIG),y)
>  # Pull the signing certificate and any extra certificates into the kernel
>  #
>  extra_certificates:
> -	touch $@
> +	@touch $@
>  
>  kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
>  
> -- 
> 1.8.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] kbuild: silence rule for extra_certificates

[Rusty Russell]

Michal Marek <mmarek@suse.cz> writes:
> Added David and Rusty.
>
> On Sun, Nov 18, 2012 at 03:05:14PM -0500, pefoley2@verizon.net wrote:
>> From: Peter Foley <pefoley2@verizon.net>
>> 
>> Silence the touch extra_certificates command
>> 
>> Signed-off-by: Peter Foley <pefoley2@verizon.net>
>
> I think we should tell the user that the default empty extra
> certificates list is being used, in case the user used a wrong filename
> or similar. How about this?

I prefer this one... Peter?

Thanks,
Rusty.

>
> Subject: MODSIGN: Fix kbuild output when using default extra_certificates
>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 0dfeca4..8c708e4 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -136,8 +136,12 @@ ifeq ($(CONFIG_MODULE_SIG),y)
>  #
>  # Pull the signing certificate and any extra certificates into the kernel
>  #
> +
> +quiet_cmd_touch = TOUCH   $@
> +      cmd_touch = touch   $@
> +
>  extra_certificates:
> -	touch $@
> +	$(call cmd,touch)
>  
>  kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
>  
> But I don't insist on the above, feel free to hide the command
> completely.
>
> Michal
>
>> ---
>>  kernel/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/kernel/Makefile b/kernel/Makefile
>> index 86e3285..18a0b61 100644
>> --- a/kernel/Makefile
>> +++ b/kernel/Makefile
>> @@ -137,7 +137,7 @@ ifeq ($(CONFIG_MODULE_SIG),y)
>>  # Pull the signing certificate and any extra certificates into the kernel
>>  #
>>  extra_certificates:
>> -	touch $@
>> +	@touch $@
>>  
>>  kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
>>  
>> -- 
>> 1.8.0
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] kbuild: silence rule for extra_certificates

[Peter Foley]

On Sun, Dec 9, 2012 at 7:08 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> Michal Marek <mmarek@suse.cz> writes:
>> Added David and Rusty.
>>
>> On Sun, Nov 18, 2012 at 03:05:14PM -0500, pefoley2@verizon.net wrote:
>>> From: Peter Foley <pefoley2@verizon.net>
>>>
>>> Silence the touch extra_certificates command
>>>
>>> Signed-off-by: Peter Foley <pefoley2@verizon.net>
>>
>> I think we should tell the user that the default empty extra
>> certificates list is being used, in case the user used a wrong filename
>> or similar. How about this?
>
> I prefer this one... Peter?
>
> Thanks,
> Rusty.
>

Looks good to me.

Thanks,

Peter

[PATCH 3/5] add eboot.o and efi_stub_$(BITS).o to $(targets)

[pefoley2]

From: Peter Foley <pefoley2@verizon.net>

eboot.o and efi_stub_$(BITS).o are not in $(targets) so they are rebuilt
every time make is invoked. Add them to $(targets) to prevent unnecessary
rebuilding of bzImage.

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 arch/x86/boot/compressed/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index 8a84501..9d7a898 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -4,7 +4,7 @@
 # create a compressed vmlinux image from the original vmlinux
 #
 
-targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o
+targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o eboot.o efi_stub_$(BITS).o
 
 KBUILD_CFLAGS := -m$(BITS) -D__KERNEL__ $(LINUX_INCLUDE) -O2
 KBUILD_CFLAGS += -fno-strict-aliasing -fPIC
-- 
1.8.0

Re: [PATCH 3/5] add eboot.o and efi_stub_$(BITS).o to $(targets)

[Michal Marek]

Added x86@kernel.org.

On 18.11.2012 21:05, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
> 
> eboot.o and efi_stub_$(BITS).o are not in $(targets) so they are rebuilt
> every time make is invoked. Add them to $(targets) to prevent unnecessary
> rebuilding of bzImage.
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>

Acked-by: Michal Marek <mmarek@suse.cz>

BTW, it might be a good idea to split the $(targets) assignment into
multiple lines.

Michal

> ---
>  arch/x86/boot/compressed/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index 8a84501..9d7a898 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -4,7 +4,7 @@
>  # create a compressed vmlinux image from the original vmlinux
>  #
>  
> -targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o
> +targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o eboot.o efi_stub_$(BITS).o
>  
>  KBUILD_CFLAGS := -m$(BITS) -D__KERNEL__ $(LINUX_INCLUDE) -O2
>  KBUILD_CFLAGS += -fno-strict-aliasing -fPIC
> 

[PATCH 4/5] silence 'arch/x86/realmode/rm/realmode.bin' is up to date message

[pefoley2]

From: Peter Foley <pefoley2@verizon.net>

Since realmode.bin is in $(always) the recursive make from the realmode
directory does not need to specify a specific target.
Remove the realmode.bin target to eliminate the 'up to date'
message.

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 arch/x86/realmode/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/realmode/Makefile b/arch/x86/realmode/Makefile
index 94f7fbe..08fe883 100644
--- a/arch/x86/realmode/Makefile
+++ b/arch/x86/realmode/Makefile
@@ -15,4 +15,4 @@ obj-y += rmpiggy.o
 $(obj)/rmpiggy.o: $(obj)/rm/realmode.bin
 
 $(obj)/rm/realmode.bin: FORCE
-	$(Q)$(MAKE) $(build)=$(obj)/rm $@
+	$(Q)$(MAKE) $(build)=$(obj)/rm
-- 
1.8.0

Re: [PATCH 4/5] silence 'arch/x86/realmode/rm/realmode.bin' is up to date message

[Michal Marek]

x86@kernel.org added.

On 18.11.2012 21:05, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
> 
> Since realmode.bin is in $(always) the recursive make from the realmode
> directory does not need to specify a specific target.

... and the rm/ subdirectory is unconditionally visited by the Makefile
already.

> Remove the realmode.bin target to eliminate the 'up to date'
> message.
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>

Acked-by: Michal Marek <mmarek@suse.cz>

Michal

> ---
>  arch/x86/realmode/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/realmode/Makefile b/arch/x86/realmode/Makefile
> index 94f7fbe..08fe883 100644
> --- a/arch/x86/realmode/Makefile
> +++ b/arch/x86/realmode/Makefile
> @@ -15,4 +15,4 @@ obj-y += rmpiggy.o
>  $(obj)/rmpiggy.o: $(obj)/rm/realmode.bin
>  
>  $(obj)/rm/realmode.bin: FORCE
> -	$(Q)$(MAKE) $(build)=$(obj)/rm $@
> +	$(Q)$(MAKE) $(build)=$(obj)/rm
> 

[PATCH 5/5] x86: add dummy rules to avoid 'nothing to be done' messages

[pefoley2]

From: Peter Foley <pefoley2@verizon.net>

Add do-nothing rules to archheaders and archscripts targets to avoid
'nothing to be done' messages.

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 arch/x86/syscalls/Makefile | 1 +
 arch/x86/tools/Makefile    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile
index f325af2..b6c923a 100644
--- a/arch/x86/syscalls/Makefile
+++ b/arch/x86/syscalls/Makefile
@@ -56,3 +56,4 @@ targets	+= $(uapisyshdr-y) $(syshdr-y)
 
 all: $(addprefix $(uapi)/,$(uapisyshdr-y))
 all: $(addprefix $(out)/,$(syshdr-y))
+	@:
diff --git a/arch/x86/tools/Makefile b/arch/x86/tools/Makefile
index bae601f..dce567c 100644
--- a/arch/x86/tools/Makefile
+++ b/arch/x86/tools/Makefile
@@ -40,3 +40,4 @@ $(obj)/insn_sanity.o: $(srctree)/arch/x86/lib/insn.c $(srctree)/arch/x86/lib/ina
 HOST_EXTRACFLAGS += -I$(srctree)/tools/include
 hostprogs-y	+= relocs
 relocs: $(obj)/relocs
+	@:
-- 
1.8.0

Re: [PATCH 5/5] x86: add dummy rules to avoid 'nothing to be done' messages

[Michal Marek]

Added x86@kernel.org

Michal

On 18.11.2012 21:05, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
> 
> Add do-nothing rules to archheaders and archscripts targets to avoid
> 'nothing to be done' messages.
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
>  arch/x86/syscalls/Makefile | 1 +
>  arch/x86/tools/Makefile    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile
> index f325af2..b6c923a 100644
> --- a/arch/x86/syscalls/Makefile
> +++ b/arch/x86/syscalls/Makefile
> @@ -56,3 +56,4 @@ targets	+= $(uapisyshdr-y) $(syshdr-y)
>  
>  all: $(addprefix $(uapi)/,$(uapisyshdr-y))
>  all: $(addprefix $(out)/,$(syshdr-y))
> +	@:
> diff --git a/arch/x86/tools/Makefile b/arch/x86/tools/Makefile
> index bae601f..dce567c 100644
> --- a/arch/x86/tools/Makefile
> +++ b/arch/x86/tools/Makefile
> @@ -40,3 +40,4 @@ $(obj)/insn_sanity.o: $(srctree)/arch/x86/lib/insn.c $(srctree)/arch/x86/lib/ina
>  HOST_EXTRACFLAGS += -I$(srctree)/tools/include
>  hostprogs-y	+= relocs
>  relocs: $(obj)/relocs
> +	@:
> 

Re: [PATCH 1/5] kbuild: remove deprecated use of defined in timeconst.pl

[Michal Marek]

On 18.11.2012 21:05, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
> 
> Fix this warning by removing a unneeded use of defined

An identical fix for this is in the -mm tree already.

Michal