From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440
Date: Mon, 10 Dec 2012 11:16:08 +0900 [thread overview]
Message-ID: <50C545E8.8050301@samsung.com> (raw)
In-Reply-To: <030c01cdd672$cb1b6b40$615241c0$%kim@samsung.com>
Hi,
On 12/10/2012 10:07 AM, Kukjin Kim wrote:
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/mach-exynos/common.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 0eb3b9a..9ecda37 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
> * Theses parameters should be NULL and 0 because EXYNOS4
> * uses GIC instead of VIC.
> */
> - s5p_init_irq(NULL, 0);
> + if (!of_machine_is_compatible("samsung,exynos5440"))
> + s5p_init_irq(NULL, 0);
How about remove to call s5p_init_irq() here because All exynos SoCs use
GIC instead of VIC?
>
> gic_arch_extn.irq_set_wake = s3c_irq_wake;
> }
WARNING: multiple messages have this Message-ID (diff)
From: jy0922.shim@samsung.com (Joonyoung Shim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440
Date: Mon, 10 Dec 2012 11:16:08 +0900 [thread overview]
Message-ID: <50C545E8.8050301@samsung.com> (raw)
In-Reply-To: <030c01cdd672$cb1b6b40$615241c0$%kim@samsung.com>
Hi,
On 12/10/2012 10:07 AM, Kukjin Kim wrote:
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/mach-exynos/common.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 0eb3b9a..9ecda37 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
> * Theses parameters should be NULL and 0 because EXYNOS4
> * uses GIC instead of VIC.
> */
> - s5p_init_irq(NULL, 0);
> + if (!of_machine_is_compatible("samsung,exynos5440"))
> + s5p_init_irq(NULL, 0);
How about remove to call s5p_init_irq() here because All exynos SoCs use
GIC instead of VIC?
>
> gic_arch_extn.irq_set_wake = s3c_irq_wake;
> }
next prev parent reply other threads:[~2012-12-10 2:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 1:07 [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440 Kukjin Kim
2012-12-10 1:07 ` Kukjin Kim
2012-12-10 2:16 ` Joonyoung Shim [this message]
2012-12-10 2:16 ` Joonyoung Shim
2012-12-19 3:26 ` Kukjin Kim
2012-12-19 3:26 ` Kukjin Kim
2012-12-20 2:04 ` Joonyoung Shim
2012-12-20 2:04 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C545E8.8050301@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.