From: Stefan Weil <sw@weilnetz.de>
To: John Spencer <maillist-qemu@barfooze.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()
Date: Mon, 10 Dec 2012 07:37:50 +0100 [thread overview]
Message-ID: <50C5833E.2020404@weilnetz.de> (raw)
In-Reply-To: <50C57E3D.9010708@barfooze.de>
Am 10.12.2012 07:16, schrieb John Spencer:
Your patch is not shown here because you had attached it to your email.
Please use "git send-email" to send patches.See also
http://wiki.qemu.org/Contribute/SubmitAPatch.
In your patch, you replaced a wrong forward declarationof function setgroups
by an include statement using grp.h. That's fine.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
There are more extern declarations in linux-user/syscall.c.
Even if they are correct, they should be replaced by include statements.
If there will be a v2 of your patch series, you could add patches
for those declarations, too.
Regards
Stefan Weil
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: John Spencer <maillist-qemu@barfooze.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()
Date: Mon, 10 Dec 2012 07:37:50 +0100 [thread overview]
Message-ID: <50C5833E.2020404@weilnetz.de> (raw)
In-Reply-To: <50C57E3D.9010708@barfooze.de>
Am 10.12.2012 07:16, schrieb John Spencer:
Your patch is not shown here because you had attached it to your email.
Please use "git send-email" to send patches.See also
http://wiki.qemu.org/Contribute/SubmitAPatch.
In your patch, you replaced a wrong forward declarationof function setgroups
by an include statement using grp.h. That's fine.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
There are more extern declarations in linux-user/syscall.c.
Even if they are correct, they should be replaced by include statements.
If there will be a v2 of your patch series, you could add patches
for those declarations, too.
Regards
Stefan Weil
next prev parent reply other threads:[~2012-12-10 6:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 6:16 [Qemu-trivial] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() John Spencer
2012-12-10 6:16 ` [Qemu-devel] " John Spencer
2012-12-10 6:37 ` Stefan Weil [this message]
2012-12-10 6:37 ` Stefan Weil
2012-12-10 7:09 ` [Qemu-trivial] " John Spencer
2012-12-10 7:09 ` John Spencer
-- strict thread matches above, loose matches on Subject: below --
2012-12-10 6:59 [Qemu-trivial] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c John Spencer
2012-12-10 6:59 ` [Qemu-trivial] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() John Spencer
2012-12-10 17:47 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C5833E.2020404@weilnetz.de \
--to=sw@weilnetz.de \
--cc=maillist-qemu@barfooze.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.