Bug found and fixed. Patch is attached to the letter.

Bug found and fixed. Patch is attached to the letter.

[Vladimir Testov]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hello!

I was playing with grub-mkfont utility, trying to make console font with 
selected size (10 actually).
And there were too much space between strings. (Also, I had to keep utf-8 
symbols that are not ascii)
So I faced that -c\--asce option of grub-mkfont does not work at all. This 
patch fixes the problem.
Now `grub-mkconfig -s 10 -c 9 -d 2 -a -o ... ...` makes the font I need.

Hope it will be useful.

And hope it will be added to upstream (as well as my previous patch).

-- 
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

[-- Attachment #2: grub2-mkfont-fix.patch --]
[-- Type: text/x-patch, Size: 407 bytes --]

diff -Naur grub-2.00/util/grub-mkfont.c grub-new/util/grub-mkfont.c
--- grub-2.00/util/grub-mkfont.c	2012-03-10 16:17:57.000000000 +0400
+++ grub-new/util/grub-mkfont.c	2012-12-04 18:00:35.463252107 +0400
@@ -1101,7 +1101,7 @@
       arguments->font_info.desc = strtoul (arg, NULL, 0);
       break;
 
-    case 'e':
+    case 'c':
       arguments->font_info.asce = strtoul (arg, NULL, 0);
       break;
 

Re: Bug found and fixed. Patch is attached to the letter.

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On 04.12.2012 17:51, Vladimir Testov wrote:

> Hello!
> 
> I was playing with grub-mkfont utility, trying to make console font with 
> selected size (10 actually).
> And there were too much space between strings. (Also, I had to keep utf-8 
> symbols that are not ascii)
> So I faced that -c\--asce option of grub-mkfont does not work at all. This 
> patch fixes the problem.
> Now `grub-mkconfig -s 10 -c 9 -d 2 -a -o ... ...` makes the font I need.
> 

Committed, thanks.

> Hope it will be useful.
> 
> And hope it will be added to upstream (as well as my previous patch).
> 
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel



-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]