All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: John Spencer <maillist-qemu@barfooze.de>
Cc: qemu-trivial@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in	linux-user/syscall.c
Date: Tue, 11 Dec 2012 07:07:09 +0100	[thread overview]
Message-ID: <50C6CD8D.6020901@weilnetz.de> (raw)
In-Reply-To: <50C68B04.9020902@barfooze.de>

Am 11.12.2012 02:23, schrieb John Spencer:
> On 12/10/2012 06:49 PM, Stefan Weil wrote:
>> Am 10.12.2012 07:59, schrieb John Spencer:
>>> +#include<sys/syscall.h>
>
>>
>> This is a workaround for a missing declaration of function syscall
>> in musl's unistd.h. See my comment to patch 1 for more information.
>>
>
> thanks for noticing! fixed in musl:
>
> http://git.musl-libc.org/cgit/musl/commit/?id=baf246e559e915a78a9703e10d15020c7edee423 
>
>
> how do we proceed with the 2 good patches ? is there anything i have 
> to do to get them merged, now that you put the "Reviewed-by" stamp on 
> them ?
>
> Thanks,
> John Spencer


I assume that Stefan Hajnoczi will add them to the qemu-trivial queue.
Just wait and resend those patches if nothing happens the next two weeks.

Regards,
Stefan Weil



WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: John Spencer <maillist-qemu@barfooze.de>
Cc: qemu-trivial@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in	linux-user/syscall.c
Date: Tue, 11 Dec 2012 07:07:09 +0100	[thread overview]
Message-ID: <50C6CD8D.6020901@weilnetz.de> (raw)
In-Reply-To: <50C68B04.9020902@barfooze.de>

Am 11.12.2012 02:23, schrieb John Spencer:
> On 12/10/2012 06:49 PM, Stefan Weil wrote:
>> Am 10.12.2012 07:59, schrieb John Spencer:
>>> +#include<sys/syscall.h>
>
>>
>> This is a workaround for a missing declaration of function syscall
>> in musl's unistd.h. See my comment to patch 1 for more information.
>>
>
> thanks for noticing! fixed in musl:
>
> http://git.musl-libc.org/cgit/musl/commit/?id=baf246e559e915a78a9703e10d15020c7edee423 
>
>
> how do we proceed with the 2 good patches ? is there anything i have 
> to do to get them merged, now that you put the "Reviewed-by" stamp on 
> them ?
>
> Thanks,
> John Spencer


I assume that Stefan Hajnoczi will add them to the qemu-trivial queue.
Just wait and resend those patches if nothing happens the next two weeks.

Regards,
Stefan Weil

  reply	other threads:[~2012-12-11  6:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10  6:59 [Qemu-trivial] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c John Spencer
2012-12-10  6:59 ` [Qemu-devel] " John Spencer
2012-12-10  6:59 ` [Qemu-trivial] [PATCH 2/4] fix build error on ARM due to wrong glibc check John Spencer
2012-12-10  6:59   ` [Qemu-devel] " John Spencer
2012-12-10 17:46   ` [Qemu-trivial] " Stefan Weil
2012-12-10 17:46     ` Stefan Weil
2012-12-18 16:23   ` [Qemu-trivial] " Stefan Hajnoczi
2012-12-18 16:23     ` [Qemu-devel] " Stefan Hajnoczi
2012-12-10  6:59 ` [Qemu-trivial] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c John Spencer
2012-12-10  6:59   ` [Qemu-devel] " John Spencer
2012-12-10 17:49   ` [Qemu-trivial] " Stefan Weil
2012-12-10 17:49     ` Stefan Weil
2012-12-11  1:23     ` [Qemu-trivial] " John Spencer
2012-12-11  1:23       ` John Spencer
2012-12-11  6:07       ` Stefan Weil [this message]
2012-12-11  6:07         ` Stefan Weil
2012-12-10  6:59 ` [Qemu-trivial] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() John Spencer
2012-12-10  6:59   ` [Qemu-devel] " John Spencer
2012-12-10 17:47   ` [Qemu-trivial] " Stefan Weil
2012-12-10 17:47     ` Stefan Weil
2012-12-18 16:23   ` [Qemu-trivial] " Stefan Hajnoczi
2012-12-18 16:23     ` [Qemu-devel] " Stefan Hajnoczi
2012-12-10 17:44 ` [Qemu-trivial] [Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c Stefan Weil
2012-12-10 17:44   ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C6CD8D.6020901@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=maillist-qemu@barfooze.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.