From: Sergei Shtylyov <sshtylyov@mvista.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree
Date: Tue, 11 Dec 2012 17:27:32 +0000 [thread overview]
Message-ID: <50C77AE8.8090008@mvista.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1212111407570.2091@hadrien>
Hello.
On 12/11/2012 04:08 PM, Julia Lawall wrote:
>>> From: Julia Lawall <Julia.Lawall@lip6.fr>
>>> The function at91_dt_node_to_map is ultimately called by the function
>>> pinctrl_get, which is an exported function. Since it is possible that this
>>> function is not called from within a probe function, for safety, the kfree
>>> is converted to a devm_kfree, to both free the data and remove it from the
>>> device in a failure situation.
>>
>>> A newline is added in the call to devm_kfree to avoid exceeding the 80
>>
>> devm_kzalloc() you mean?
> Yes, sorry. Should I send a new patch?
Up to the maintainer I guess...
> thanks,
> julia
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree
Date: Tue, 11 Dec 2012 21:26:48 +0300 [thread overview]
Message-ID: <50C77AE8.8090008@mvista.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1212111407570.2091@hadrien>
Hello.
On 12/11/2012 04:08 PM, Julia Lawall wrote:
>>> From: Julia Lawall <Julia.Lawall@lip6.fr>
>>> The function at91_dt_node_to_map is ultimately called by the function
>>> pinctrl_get, which is an exported function. Since it is possible that this
>>> function is not called from within a probe function, for safety, the kfree
>>> is converted to a devm_kfree, to both free the data and remove it from the
>>> device in a failure situation.
>>
>>> A newline is added in the call to devm_kfree to avoid exceeding the 80
>>
>> devm_kzalloc() you mean?
> Yes, sorry. Should I send a new patch?
Up to the maintainer I guess...
> thanks,
> julia
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree
Date: Tue, 11 Dec 2012 21:26:48 +0300 [thread overview]
Message-ID: <50C77AE8.8090008@mvista.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1212111407570.2091@hadrien>
Hello.
On 12/11/2012 04:08 PM, Julia Lawall wrote:
>>> From: Julia Lawall <Julia.Lawall@lip6.fr>
>>> The function at91_dt_node_to_map is ultimately called by the function
>>> pinctrl_get, which is an exported function. Since it is possible that this
>>> function is not called from within a probe function, for safety, the kfree
>>> is converted to a devm_kfree, to both free the data and remove it from the
>>> device in a failure situation.
>>
>>> A newline is added in the call to devm_kfree to avoid exceeding the 80
>>
>> devm_kzalloc() you mean?
> Yes, sorry. Should I send a new patch?
Up to the maintainer I guess...
> thanks,
> julia
WBR, Sergei
next prev parent reply other threads:[~2012-12-11 17:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 9:58 [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree Julia Lawall
2012-12-11 10:58 ` Julia Lawall
2012-12-11 10:58 ` Julia Lawall
2012-12-11 13:00 ` Sergei Shtylyov
2012-12-11 13:00 ` Sergei Shtylyov
2012-12-11 13:00 ` Sergei Shtylyov
2012-12-11 13:08 ` Julia Lawall
2012-12-11 13:08 ` Julia Lawall
2012-12-11 13:08 ` Julia Lawall
2012-12-11 17:27 ` Sergei Shtylyov [this message]
2012-12-11 18:26 ` Sergei Shtylyov
2012-12-11 18:26 ` Sergei Shtylyov
2012-12-12 11:56 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 11:56 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 11:56 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 14:22 ` Julia Lawall
2012-12-12 14:22 ` Julia Lawall
2012-12-12 14:22 ` Julia Lawall
2012-12-12 17:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 17:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 17:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-14 15:46 ` Linus Walleij
2012-12-14 15:46 ` Linus Walleij
2012-12-14 15:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C77AE8.8090008@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.