From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Joachim Eastwood <manabian@gmail.com>,
broonie@opensource.wolfsonmicro.com
Cc: voice.shen@atmel.com, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: atmel-ssc: make it buildable on other architectures
Date: Thu, 13 Dec 2012 12:17:52 +0100 [thread overview]
Message-ID: <50C9B960.6000407@atmel.com> (raw)
In-Reply-To: <1354970801-9185-1-git-send-email-manabian@gmail.com>
On 12/08/2012 01:46 PM, Joachim Eastwood :
> Not very useful on non AT91/AVR32 platforms but it provides
> more build coverage and prepares for ARM multiplatform.
>
> Also fixes a truncated warning that would come when
> building on a 64-bit arch.
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
It if needs it to go forward:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>
> Hi Mark,
>
> Sending it to you since seem like you're the last one who
> commited changes to the driver and the driver is mostly
> used on ASoC.
>
> Tested on RM9200 and build tested on x86_64.
>
> regards
> Joachim Eastwood
>
> drivers/misc/Kconfig | 2 +-
> drivers/misc/atmel-ssc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index b151b7c..8f59d88 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -192,7 +192,7 @@ config ICS932S401
>
> config ATMEL_SSC
> tristate "Device driver for Atmel SSC peripheral"
> - depends on AVR32 || ARCH_AT91
> + depends on HAS_IOMEM
> ---help---
> This option enables device driver support for Atmel Synchronized
> Serial Communication peripheral (SSC).
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 158da5a..0cee274 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
>
> /* disable all interrupts */
> clk_enable(ssc->clk);
> - ssc_writel(ssc->regs, IDR, ~0UL);
> + ssc_writel(ssc->regs, IDR, -1);
> ssc_readl(ssc->regs, SR);
> clk_disable(ssc->clk);
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Joachim Eastwood <manabian@gmail.com>,
broonie@opensource.wolfsonmicro.com
Cc: voice.shen@atmel.com, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: atmel-ssc: make it buildable on other architectures
Date: Thu, 13 Dec 2012 11:17:52 +0000 [thread overview]
Message-ID: <50C9B960.6000407@atmel.com> (raw)
In-Reply-To: <1354970801-9185-1-git-send-email-manabian@gmail.com>
On 12/08/2012 01:46 PM, Joachim Eastwood :
> Not very useful on non AT91/AVR32 platforms but it provides
> more build coverage and prepares for ARM multiplatform.
>
> Also fixes a truncated warning that would come when
> building on a 64-bit arch.
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
It if needs it to go forward:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>
> Hi Mark,
>
> Sending it to you since seem like you're the last one who
> commited changes to the driver and the driver is mostly
> used on ASoC.
>
> Tested on RM9200 and build tested on x86_64.
>
> regards
> Joachim Eastwood
>
> drivers/misc/Kconfig | 2 +-
> drivers/misc/atmel-ssc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index b151b7c..8f59d88 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -192,7 +192,7 @@ config ICS932S401
>
> config ATMEL_SSC
> tristate "Device driver for Atmel SSC peripheral"
> - depends on AVR32 || ARCH_AT91
> + depends on HAS_IOMEM
> ---help---
> This option enables device driver support for Atmel Synchronized
> Serial Communication peripheral (SSC).
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 158da5a..0cee274 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
>
> /* disable all interrupts */
> clk_enable(ssc->clk);
> - ssc_writel(ssc->regs, IDR, ~0UL);
> + ssc_writel(ssc->regs, IDR, -1);
> ssc_readl(ssc->regs, SR);
> clk_disable(ssc->clk);
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: atmel-ssc: make it buildable on other architectures
Date: Thu, 13 Dec 2012 12:17:52 +0100 [thread overview]
Message-ID: <50C9B960.6000407@atmel.com> (raw)
In-Reply-To: <1354970801-9185-1-git-send-email-manabian@gmail.com>
On 12/08/2012 01:46 PM, Joachim Eastwood :
> Not very useful on non AT91/AVR32 platforms but it provides
> more build coverage and prepares for ARM multiplatform.
>
> Also fixes a truncated warning that would come when
> building on a 64-bit arch.
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
It if needs it to go forward:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>
> Hi Mark,
>
> Sending it to you since seem like you're the last one who
> commited changes to the driver and the driver is mostly
> used on ASoC.
>
> Tested on RM9200 and build tested on x86_64.
>
> regards
> Joachim Eastwood
>
> drivers/misc/Kconfig | 2 +-
> drivers/misc/atmel-ssc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index b151b7c..8f59d88 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -192,7 +192,7 @@ config ICS932S401
>
> config ATMEL_SSC
> tristate "Device driver for Atmel SSC peripheral"
> - depends on AVR32 || ARCH_AT91
> + depends on HAS_IOMEM
> ---help---
> This option enables device driver support for Atmel Synchronized
> Serial Communication peripheral (SSC).
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 158da5a..0cee274 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
>
> /* disable all interrupts */
> clk_enable(ssc->clk);
> - ssc_writel(ssc->regs, IDR, ~0UL);
> + ssc_writel(ssc->regs, IDR, -1);
> ssc_readl(ssc->regs, SR);
> clk_disable(ssc->clk);
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2012-12-13 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 12:46 [PATCH] ASoC: atmel-ssc: make it buildable on other architectures Joachim Eastwood
2012-12-08 12:46 ` Joachim Eastwood
2012-12-08 12:46 ` Joachim Eastwood
2012-12-10 9:53 ` Bo Shen
2012-12-10 9:53 ` Bo Shen
2012-12-10 9:53 ` Bo Shen
2012-12-13 11:17 ` Nicolas Ferre [this message]
2012-12-13 11:17 ` Nicolas Ferre
2012-12-13 11:17 ` Nicolas Ferre
2012-12-24 15:48 ` Mark Brown
2012-12-24 15:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C9B960.6000407@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=plagnioj@jcrosoft.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.