From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Gary Thomas <gary@mlbassoc.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files.
Date: Thu, 13 Dec 2012 22:50:33 -0500 [thread overview]
Message-ID: <50CAA209.1000009@windriver.com> (raw)
In-Reply-To: <50CA5BE5.5000709@mlbassoc.com>
On 12-12-13 5:51 PM, Gary Thomas wrote:
> On 2012-12-13 14:45, Robert P. J. Day wrote:
>> On Thu, 13 Dec 2012, David Nyström wrote:
>>
>>> Hi,
>>>
>>> Hmm,
>>> This will lead to these variables beeing append:able but
>>> non-overridable in image layer, as an(un?)intended consequence,
>>> right ?
>>>
>>> Br,
>>> David
>>>
>>> Sent from my Android phone using TouchDown (www.nitrodesk.com)
>>>
>>> -----Original Message-----
>>> From: Robert P. J. Day [rpjday@crashcourse.ca]
>>> Received: Thursday, 13 Dec 2012, 20:59
>>> To: Yocto discussion list [yocto@yoctoproject.org]
>>> Subject: [yocto] [PATCH] Use "+=" consistently when setting
>>> IMAGE_FSTYPES in Yocto machine conf files.
>>>
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>>
>>> ---
>>>
>>> diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf
>>> b/meta-yocto-bsp/conf/machine/atom-pc.conf
>>> index 77dd7fb..fbde1d3 100644
>>> --- a/meta-yocto-bsp/conf/machine/atom-pc.conf
>>> +++ b/meta-yocto-bsp/conf/machine/atom-pc.conf
>>> @@ -25,7 +25,7 @@ XSERVER ?= "xserver-xorg \
>>>
>>> MACHINE_EXTRA_RRECOMMENDS = "kernel-modules eee-acpi-scripts"
>>>
>>> -IMAGE_FSTYPES ?= "ext3 cpio.gz live"
>>> +IMAGE_FSTYPES += "ext3 cpio.gz live"
>>>
>>> APPEND += "usbcore.autosuspend=1"
>>>
>>> diff --git a/meta-yocto-bsp/conf/machine/routerstationpro.conf
>>> b/meta-yocto-bsp/conf/machine/routerstationpro.conf
>>> index e5e4d1a..c7a5ad5 100644
>>> --- a/meta-yocto-bsp/conf/machine/routerstationpro.conf
>>> +++ b/meta-yocto-bsp/conf/machine/routerstationpro.conf
>>> @@ -22,5 +22,5 @@ USE_VT ?= "0"
>>>
>>> MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
>>>
>>> -IMAGE_FSTYPES ?= "jffs2 tar.bz2"
>>> +IMAGE_FSTYPES += "jffs2 tar.bz2"
>>
>> please don't top post. and i'll have to take a look at this to see
>> what the potential problem is here. can anyone else see a potential
>> issue with this patch?
>
> Yes, as David said, it eliminates the possibility of overriding
> the variable. IMO, all of these should be ?= which lets there
> be a useful default, but can still be [completely] overridden
> by the user.
I'd agree that if we were shooting for consistency, I'd go with
?= and not the +=.
Cheers,
Bruce
>
next prev parent reply other threads:[~2012-12-14 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 19:58 [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files Robert P. J. Day
2012-12-13 20:59 ` David Nyström
2012-12-13 21:45 ` Robert P. J. Day
2012-12-13 22:51 ` Gary Thomas
2012-12-14 3:50 ` Bruce Ashfield [this message]
2012-12-14 11:03 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CAA209.1000009@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=gary@mlbassoc.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.