* [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. @ 2012-12-13 19:58 Robert P. J. Day 2012-12-13 20:59 ` David Nyström 0 siblings, 1 reply; 6+ messages in thread From: Robert P. J. Day @ 2012-12-13 19:58 UTC (permalink / raw) To: Yocto discussion list Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf b/meta-yocto-bsp/conf/machine/atom-pc.conf index 77dd7fb..fbde1d3 100644 --- a/meta-yocto-bsp/conf/machine/atom-pc.conf +++ b/meta-yocto-bsp/conf/machine/atom-pc.conf @@ -25,7 +25,7 @@ XSERVER ?= "xserver-xorg \ MACHINE_EXTRA_RRECOMMENDS = "kernel-modules eee-acpi-scripts" -IMAGE_FSTYPES ?= "ext3 cpio.gz live" +IMAGE_FSTYPES += "ext3 cpio.gz live" APPEND += "usbcore.autosuspend=1" diff --git a/meta-yocto-bsp/conf/machine/routerstationpro.conf b/meta-yocto-bsp/conf/machine/routerstationpro.conf index e5e4d1a..c7a5ad5 100644 --- a/meta-yocto-bsp/conf/machine/routerstationpro.conf +++ b/meta-yocto-bsp/conf/machine/routerstationpro.conf @@ -22,5 +22,5 @@ USE_VT ?= "0" MACHINE_EXTRA_RRECOMMENDS = " kernel-modules" -IMAGE_FSTYPES ?= "jffs2 tar.bz2" +IMAGE_FSTYPES += "jffs2 tar.bz2" -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. 2012-12-13 19:58 [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files Robert P. J. Day @ 2012-12-13 20:59 ` David Nyström 2012-12-13 21:45 ` Robert P. J. Day 0 siblings, 1 reply; 6+ messages in thread From: David Nyström @ 2012-12-13 20:59 UTC (permalink / raw) To: yocto@yoctoproject.org, rpjday@crashcourse.ca [-- Attachment #1: Type: text/plain, Size: 2009 bytes --] Hi, Hmm, This will lead to these variables beeing append:able but non-overridable in image layer, as an(un?)intended consequence, right ? Br, David Sent from my Android phone using TouchDown (www.nitrodesk.com) -----Original Message----- From: Robert P. J. Day [rpjday@crashcourse.ca] Received: Thursday, 13 Dec 2012, 20:59 To: Yocto discussion list [yocto@yoctoproject.org] Subject: [yocto] [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf b/meta-yocto-bsp/conf/machine/atom-pc.conf index 77dd7fb..fbde1d3 100644 --- a/meta-yocto-bsp/conf/machine/atom-pc.conf +++ b/meta-yocto-bsp/conf/machine/atom-pc.conf @@ -25,7 +25,7 @@ XSERVER ?= "xserver-xorg \ MACHINE_EXTRA_RRECOMMENDS = "kernel-modules eee-acpi-scripts" -IMAGE_FSTYPES ?= "ext3 cpio.gz live" +IMAGE_FSTYPES += "ext3 cpio.gz live" APPEND += "usbcore.autosuspend=1" diff --git a/meta-yocto-bsp/conf/machine/routerstationpro.conf b/meta-yocto-bsp/conf/machine/routerstationpro.conf index e5e4d1a..c7a5ad5 100644 --- a/meta-yocto-bsp/conf/machine/routerstationpro.conf +++ b/meta-yocto-bsp/conf/machine/routerstationpro.conf @@ -22,5 +22,5 @@ USE_VT ?= "0" MACHINE_EXTRA_RRECOMMENDS = " kernel-modules" -IMAGE_FSTYPES ?= "jffs2 tar.bz2" +IMAGE_FSTYPES += "jffs2 tar.bz2" -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto [-- Attachment #2: Type: text/html, Size: 3897 bytes --] ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. 2012-12-13 20:59 ` David Nyström @ 2012-12-13 21:45 ` Robert P. J. Day 2012-12-13 22:51 ` Gary Thomas 0 siblings, 1 reply; 6+ messages in thread From: Robert P. J. Day @ 2012-12-13 21:45 UTC (permalink / raw) To: David Nyström; +Cc: yocto@yoctoproject.org [-- Attachment #1: Type: TEXT/PLAIN, Size: 2165 bytes --] On Thu, 13 Dec 2012, David Nyström wrote: > Hi, > > Hmm, > This will lead to these variables beeing append:able but non-overridable in image layer, as an(un?)intended consequence, > right ? > > Br, > David > > Sent from my Android phone using TouchDown (www.nitrodesk.com) > > -----Original Message----- > From: Robert P. J. Day [rpjday@crashcourse.ca] > Received: Thursday, 13 Dec 2012, 20:59 > To: Yocto discussion list [yocto@yoctoproject.org] > Subject: [yocto] [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > --- > > diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf b/meta-yocto-bsp/conf/machine/atom-pc.conf > index 77dd7fb..fbde1d3 100644 > --- a/meta-yocto-bsp/conf/machine/atom-pc.conf > +++ b/meta-yocto-bsp/conf/machine/atom-pc.conf > @@ -25,7 +25,7 @@ XSERVER ?= "xserver-xorg \ > > MACHINE_EXTRA_RRECOMMENDS = "kernel-modules eee-acpi-scripts" > > -IMAGE_FSTYPES ?= "ext3 cpio.gz live" > +IMAGE_FSTYPES += "ext3 cpio.gz live" > > APPEND += "usbcore.autosuspend=1" > > diff --git a/meta-yocto-bsp/conf/machine/routerstationpro.conf b/meta-yocto-bsp/conf/machine/routerstationpro.conf > index e5e4d1a..c7a5ad5 100644 > --- a/meta-yocto-bsp/conf/machine/routerstationpro.conf > +++ b/meta-yocto-bsp/conf/machine/routerstationpro.conf > @@ -22,5 +22,5 @@ USE_VT ?= "0" > > MACHINE_EXTRA_RRECOMMENDS = " kernel-modules" > > -IMAGE_FSTYPES ?= "jffs2 tar.bz2" > +IMAGE_FSTYPES += "jffs2 tar.bz2" please don't top post. and i'll have to take a look at this to see what the potential problem is here. can anyone else see a potential issue with this patch? rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. 2012-12-13 21:45 ` Robert P. J. Day @ 2012-12-13 22:51 ` Gary Thomas 2012-12-14 3:50 ` Bruce Ashfield 0 siblings, 1 reply; 6+ messages in thread From: Gary Thomas @ 2012-12-13 22:51 UTC (permalink / raw) To: yocto On 2012-12-13 14:45, Robert P. J. Day wrote: > On Thu, 13 Dec 2012, David Nyström wrote: > >> Hi, >> >> Hmm, >> This will lead to these variables beeing append:able but non-overridable in image layer, as an(un?)intended consequence, >> right ? >> >> Br, >> David >> >> Sent from my Android phone using TouchDown (www.nitrodesk.com) >> >> -----Original Message----- >> From: Robert P. J. Day [rpjday@crashcourse.ca] >> Received: Thursday, 13 Dec 2012, 20:59 >> To: Yocto discussion list [yocto@yoctoproject.org] >> Subject: [yocto] [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. >> >> >> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> >> >> --- >> >> diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf b/meta-yocto-bsp/conf/machine/atom-pc.conf >> index 77dd7fb..fbde1d3 100644 >> --- a/meta-yocto-bsp/conf/machine/atom-pc.conf >> +++ b/meta-yocto-bsp/conf/machine/atom-pc.conf >> @@ -25,7 +25,7 @@ XSERVER ?= "xserver-xorg \ >> >> MACHINE_EXTRA_RRECOMMENDS = "kernel-modules eee-acpi-scripts" >> >> -IMAGE_FSTYPES ?= "ext3 cpio.gz live" >> +IMAGE_FSTYPES += "ext3 cpio.gz live" >> >> APPEND += "usbcore.autosuspend=1" >> >> diff --git a/meta-yocto-bsp/conf/machine/routerstationpro.conf b/meta-yocto-bsp/conf/machine/routerstationpro.conf >> index e5e4d1a..c7a5ad5 100644 >> --- a/meta-yocto-bsp/conf/machine/routerstationpro.conf >> +++ b/meta-yocto-bsp/conf/machine/routerstationpro.conf >> @@ -22,5 +22,5 @@ USE_VT ?= "0" >> >> MACHINE_EXTRA_RRECOMMENDS = " kernel-modules" >> >> -IMAGE_FSTYPES ?= "jffs2 tar.bz2" >> +IMAGE_FSTYPES += "jffs2 tar.bz2" > > please don't top post. and i'll have to take a look at this to see > what the potential problem is here. can anyone else see a potential > issue with this patch? Yes, as David said, it eliminates the possibility of overriding the variable. IMO, all of these should be ?= which lets there be a useful default, but can still be [completely] overridden by the user. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. 2012-12-13 22:51 ` Gary Thomas @ 2012-12-14 3:50 ` Bruce Ashfield 2012-12-14 11:03 ` Robert P. J. Day 0 siblings, 1 reply; 6+ messages in thread From: Bruce Ashfield @ 2012-12-14 3:50 UTC (permalink / raw) To: Gary Thomas; +Cc: yocto On 12-12-13 5:51 PM, Gary Thomas wrote: > On 2012-12-13 14:45, Robert P. J. Day wrote: >> On Thu, 13 Dec 2012, David Nyström wrote: >> >>> Hi, >>> >>> Hmm, >>> This will lead to these variables beeing append:able but >>> non-overridable in image layer, as an(un?)intended consequence, >>> right ? >>> >>> Br, >>> David >>> >>> Sent from my Android phone using TouchDown (www.nitrodesk.com) >>> >>> -----Original Message----- >>> From: Robert P. J. Day [rpjday@crashcourse.ca] >>> Received: Thursday, 13 Dec 2012, 20:59 >>> To: Yocto discussion list [yocto@yoctoproject.org] >>> Subject: [yocto] [PATCH] Use "+=" consistently when setting >>> IMAGE_FSTYPES in Yocto machine conf files. >>> >>> >>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> >>> >>> --- >>> >>> diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf >>> b/meta-yocto-bsp/conf/machine/atom-pc.conf >>> index 77dd7fb..fbde1d3 100644 >>> --- a/meta-yocto-bsp/conf/machine/atom-pc.conf >>> +++ b/meta-yocto-bsp/conf/machine/atom-pc.conf >>> @@ -25,7 +25,7 @@ XSERVER ?= "xserver-xorg \ >>> >>> MACHINE_EXTRA_RRECOMMENDS = "kernel-modules eee-acpi-scripts" >>> >>> -IMAGE_FSTYPES ?= "ext3 cpio.gz live" >>> +IMAGE_FSTYPES += "ext3 cpio.gz live" >>> >>> APPEND += "usbcore.autosuspend=1" >>> >>> diff --git a/meta-yocto-bsp/conf/machine/routerstationpro.conf >>> b/meta-yocto-bsp/conf/machine/routerstationpro.conf >>> index e5e4d1a..c7a5ad5 100644 >>> --- a/meta-yocto-bsp/conf/machine/routerstationpro.conf >>> +++ b/meta-yocto-bsp/conf/machine/routerstationpro.conf >>> @@ -22,5 +22,5 @@ USE_VT ?= "0" >>> >>> MACHINE_EXTRA_RRECOMMENDS = " kernel-modules" >>> >>> -IMAGE_FSTYPES ?= "jffs2 tar.bz2" >>> +IMAGE_FSTYPES += "jffs2 tar.bz2" >> >> please don't top post. and i'll have to take a look at this to see >> what the potential problem is here. can anyone else see a potential >> issue with this patch? > > Yes, as David said, it eliminates the possibility of overriding > the variable. IMO, all of these should be ?= which lets there > be a useful default, but can still be [completely] overridden > by the user. I'd agree that if we were shooting for consistency, I'd go with ?= and not the +=. Cheers, Bruce > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files. 2012-12-14 3:50 ` Bruce Ashfield @ 2012-12-14 11:03 ` Robert P. J. Day 0 siblings, 0 replies; 6+ messages in thread From: Robert P. J. Day @ 2012-12-14 11:03 UTC (permalink / raw) To: Bruce Ashfield; +Cc: yocto [-- Attachment #1: Type: TEXT/PLAIN, Size: 2874 bytes --] On Thu, 13 Dec 2012, Bruce Ashfield wrote: > On 12-12-13 5:51 PM, Gary Thomas wrote: > > On 2012-12-13 14:45, Robert P. J. Day wrote: > > > On Thu, 13 Dec 2012, David Nyström wrote: > > > > > > > Hi, > > > > > > > > Hmm, > > > > This will lead to these variables beeing append:able but > > > > non-overridable in image layer, as an(un?)intended consequence, > > > > right ? > > > > > > > > -----Original Message----- > > > > From: Robert P. J. Day [rpjday@crashcourse.ca] > > > > Received: Thursday, 13 Dec 2012, 20:59 > > > > To: Yocto discussion list [yocto@yoctoproject.org] > > > > Subject: [yocto] [PATCH] Use "+=" consistently when setting > > > > IMAGE_FSTYPES in Yocto machine conf files. > > > > > > > > diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf > > > > b/meta-yocto-bsp/conf/machine/atom-pc.conf > > > > index 77dd7fb..fbde1d3 100644 > > > > --- a/meta-yocto-bsp/conf/machine/atom-pc.conf > > > > +++ b/meta-yocto-bsp/conf/machine/atom-pc.conf > > > > @@ -25,7 +25,7 @@ XSERVER ?= "xserver-xorg \ > > > > > > > > MACHINE_EXTRA_RRECOMMENDS = "kernel-modules eee-acpi-scripts" > > > > > > > > -IMAGE_FSTYPES ?= "ext3 cpio.gz live" > > > > +IMAGE_FSTYPES += "ext3 cpio.gz live" > > > > > > > > APPEND += "usbcore.autosuspend=1" > > > > > > > > diff --git a/meta-yocto-bsp/conf/machine/routerstationpro.conf > > > > b/meta-yocto-bsp/conf/machine/routerstationpro.conf > > > > index e5e4d1a..c7a5ad5 100644 > > > > --- a/meta-yocto-bsp/conf/machine/routerstationpro.conf > > > > +++ b/meta-yocto-bsp/conf/machine/routerstationpro.conf > > > > @@ -22,5 +22,5 @@ USE_VT ?= "0" > > > > > > > > MACHINE_EXTRA_RRECOMMENDS = " kernel-modules" > > > > > > > > -IMAGE_FSTYPES ?= "jffs2 tar.bz2" > > > > +IMAGE_FSTYPES += "jffs2 tar.bz2" > > > > > > please don't top post. and i'll have to take a look at this to see > > > what the potential problem is here. can anyone else see a potential > > > issue with this patch? > > > > Yes, as David said, it eliminates the possibility of overriding > > the variable. IMO, all of these should be ?= which lets there > > be a useful default, but can still be [completely] overridden > > by the user. > > I'd agree that if we were shooting for consistency, I'd go with > ?= and not the +=. if someone thinks that's a cleanup worth making and wants to take it, help yourself to it, i'm going to be buried in ADT stuff all day. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-14 11:03 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-13 19:58 [PATCH] Use "+=" consistently when setting IMAGE_FSTYPES in Yocto machine conf files Robert P. J. Day 2012-12-13 20:59 ` David Nyström 2012-12-13 21:45 ` Robert P. J. Day 2012-12-13 22:51 ` Gary Thomas 2012-12-14 3:50 ` Bruce Ashfield 2012-12-14 11:03 ` Robert P. J. Day
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.