All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Tang Chen <tangchen@cn.fujitsu.com>, akpm@linux-foundation.org
Cc: isimatu.yasuaki@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
	mel@csn.ul.ie, wency@cn.fujitsu.com, mingo@elte.hu,
	penberg@kernel.org, torvalds@linux-foundation.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] memory-hotplug: Add help info for CONFIG_MOVABLE_NODE option
Date: Fri, 14 Dec 2012 17:39:21 +0800	[thread overview]
Message-ID: <50CAF3C9.3090906@cn.fujitsu.com> (raw)
In-Reply-To: <1355477270-19922-2-git-send-email-tangchen@cn.fujitsu.com>

On 12/14/2012 05:27 PM, Tang Chen wrote:
> This patch adds help info for CONFIG_MOVABLE_NODE option.
> 
> This option allows user to online all memory of a node as movable
> memory. So that the whole node can be hotpluged. Users who don't
> use hotplug feature are also fine with this option on since they
> won't online memory as movable.
> 
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>  mm/Kconfig |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 71259e0..2ad51cb 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -150,6 +150,16 @@ config MOVABLE_NODE
>  	depends on X86_64
>  	depends on NUMA
>  	depends on BROKEN
> +	help
> +	  Allow a node to have only movable memory. Pages used by kernel, such
> +	  as direct mapping pages can not be migrated. So the corresponding
> +	  memory device can not be hotpluged. This option allows users to
> +	  online all the memory of a node as movable memory so that the whole
> +	  node can be hotpluged. Users who don't use hotplug feature are fine
> +	  with this option on since they don't online memory as movable.
> +
> +	  Say Y here if you want to hotplug a whole node.
> +	  Say N here if you want kernel to use memory on all nodes evenly.

Thank you for adding the help text which should have been done by me.

Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Tang Chen <tangchen@cn.fujitsu.com>, akpm@linux-foundation.org
Cc: isimatu.yasuaki@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
	mel@csn.ul.ie, wency@cn.fujitsu.com, mingo@elte.hu,
	penberg@kernel.org, torvalds@linux-foundation.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] memory-hotplug: Add help info for CONFIG_MOVABLE_NODE option
Date: Fri, 14 Dec 2012 17:39:21 +0800	[thread overview]
Message-ID: <50CAF3C9.3090906@cn.fujitsu.com> (raw)
In-Reply-To: <1355477270-19922-2-git-send-email-tangchen@cn.fujitsu.com>

On 12/14/2012 05:27 PM, Tang Chen wrote:
> This patch adds help info for CONFIG_MOVABLE_NODE option.
> 
> This option allows user to online all memory of a node as movable
> memory. So that the whole node can be hotpluged. Users who don't
> use hotplug feature are also fine with this option on since they
> won't online memory as movable.
> 
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>  mm/Kconfig |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 71259e0..2ad51cb 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -150,6 +150,16 @@ config MOVABLE_NODE
>  	depends on X86_64
>  	depends on NUMA
>  	depends on BROKEN
> +	help
> +	  Allow a node to have only movable memory. Pages used by kernel, such
> +	  as direct mapping pages can not be migrated. So the corresponding
> +	  memory device can not be hotpluged. This option allows users to
> +	  online all the memory of a node as movable memory so that the whole
> +	  node can be hotpluged. Users who don't use hotplug feature are fine
> +	  with this option on since they don't online memory as movable.
> +
> +	  Say Y here if you want to hotplug a whole node.
> +	  Say N here if you want kernel to use memory on all nodes evenly.

Thank you for adding the help text which should have been done by me.

Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>

  reply	other threads:[~2012-12-14  9:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14  9:27 [PATCH 0/2] Add help info for CONFIG_MOVABLE_NODE and disable is by default Tang Chen
2012-12-14  9:27 ` Tang Chen
2012-12-14  9:27 ` [PATCH 1/2] memory-hotplug: Add help info for CONFIG_MOVABLE_NODE option Tang Chen
2012-12-14  9:27   ` Tang Chen
2012-12-14  9:39   ` Lai Jiangshan [this message]
2012-12-14  9:39     ` Lai Jiangshan
2012-12-14  9:27 ` [PATCH 2/2] memory-hotplug: Disable CONFIG_MOVABLE_NODE option by default Tang Chen
2012-12-14  9:27   ` Tang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CAF3C9.3090906@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=tangchen@cn.fujitsu.com \
    --cc=torvalds@linux-foundation.org \
    --cc=wency@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.