* [PATCH] radeon: fix regression with eviction since evict caching changes
@ 2012-12-14 11:04 Dave Airlie
2012-12-14 11:22 ` Maarten Lankhorst
0 siblings, 1 reply; 3+ messages in thread
From: Dave Airlie @ 2012-12-14 11:04 UTC (permalink / raw)
To: dri-devel
From: Dave Airlie <airlied@redhat.com>
Since 0d0b3e7443bed6b49cb90fe7ddc4b5578a83a88d
drm/radeon: use cached memory when evicting for vram on non agp
evicting from TTM would try and evict to TTM instead of system,
not so good.
This should fix:
https://bugs.freedesktop.org/show_bug.cgi?id=58272
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/radeon/radeon_object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index 93d3445..883c95d 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -96,9 +96,9 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
if (domain & RADEON_GEM_DOMAIN_CPU) {
if (rbo->rdev->flags & RADEON_IS_AGP) {
- rbo->placements[c++] = TTM_PL_FLAG_WC | TTM_PL_FLAG_TT;
+ rbo->placements[c++] = TTM_PL_FLAG_WC | TTM_PL_FLAG_SYSTEM;
} else {
- rbo->placements[c++] = TTM_PL_FLAG_CACHED | TTM_PL_FLAG_TT;
+ rbo->placements[c++] = TTM_PL_FLAG_CACHED | TTM_PL_FLAG_SYSTEM;
}
}
if (!c)
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] radeon: fix regression with eviction since evict caching changes
2012-12-14 11:04 [PATCH] radeon: fix regression with eviction since evict caching changes Dave Airlie
@ 2012-12-14 11:22 ` Maarten Lankhorst
2012-12-14 14:48 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Maarten Lankhorst @ 2012-12-14 11:22 UTC (permalink / raw)
To: Dave Airlie; +Cc: dri-devel
Op 14-12-12 12:04, Dave Airlie schreef:
> From: Dave Airlie <airlied@redhat.com>
>
> Since 0d0b3e7443bed6b49cb90fe7ddc4b5578a83a88d
> drm/radeon: use cached memory when evicting for vram on non agp
>
> evicting from TTM would try and evict to TTM instead of system,
> not so good.
>
> This should fix:
> https://bugs.freedesktop.org/show_bug.cgi?id=58272
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] radeon: fix regression with eviction since evict caching changes
2012-12-14 11:22 ` Maarten Lankhorst
@ 2012-12-14 14:48 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2012-12-14 14:48 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: dri-devel
Added to my tree. Thanks.
On Fri, Dec 14, 2012 at 6:22 AM, Maarten Lankhorst
<maarten.lankhorst@canonical.com> wrote:
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-14 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-14 11:04 [PATCH] radeon: fix regression with eviction since evict caching changes Dave Airlie
2012-12-14 11:22 ` Maarten Lankhorst
2012-12-14 14:48 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.