From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>,
Don Slutz <Don@CloudSwitch.Com>,
Eduardo Habkost <ehabkost@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState
Date: Fri, 14 Dec 2012 16:40:01 +0100 [thread overview]
Message-ID: <50CB4851.6040208@redhat.com> (raw)
In-Reply-To: <50CB45CF.5000709@suse.de>
Il 14/12/2012 16:29, Andreas Färber ha scritto:
> The latest motivation for making the CPU a device was to have the static
> properties infrastructure for machine/CPU versioning. The global
> property defaults are set in qdev's instance_init, so object_new() seems
> fine for that.
>
> qdev_[try_]create() would further set the parent bus to SysBus if NULL.
> The CPU is not a SysBusDevice so I think not using qdev_create() may be
> safer... Maybe Anthony or Paolo can confirm?
I think various parts of qdev assume there is a bus, so actually using
SysBus would be safer (though uglier).
Paolo
next prev parent reply other threads:[~2012-12-14 15:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 16:49 [Qemu-devel] [PATCH 0/8] CPU DeviceState v10 Eduardo Habkost
2012-12-05 16:49 ` [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs Eduardo Habkost
2012-12-14 15:34 ` Andreas Färber
2012-12-14 15:38 ` Paolo Bonzini
2012-12-14 17:21 ` Eduardo Habkost
2013-01-02 13:48 ` Andreas Färber
2013-01-02 14:32 ` Eduardo Habkost
2012-12-05 16:49 ` [Qemu-devel] [PATCH 2/8] libqemustub: Add qemu_[un]register_reset() stubs Eduardo Habkost
2012-12-05 16:49 ` [Qemu-devel] [PATCH 3/8] libqemustub: vmstate register/unregister stubs Eduardo Habkost
2013-01-02 12:57 ` Andreas Färber
2012-12-05 16:49 ` [Qemu-devel] [PATCH 4/8] libqemustub: sysbus_get_default() stub Eduardo Habkost
2012-12-05 16:49 ` [Qemu-devel] [PATCH 5/8] qdev: Coding style fixes Eduardo Habkost
2012-12-18 22:01 ` Andreas Färber
2012-12-05 16:49 ` [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-* Eduardo Habkost
2012-12-18 22:30 ` Andreas Färber
2012-12-05 16:49 ` [Qemu-devel] [PATCH 7/8] include qdev code into *-user, too Eduardo Habkost
2012-12-05 16:49 ` [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState Eduardo Habkost
2012-12-12 13:34 ` Andreas Färber
2012-12-12 13:59 ` Eduardo Habkost
2012-12-12 14:27 ` Igor Mammedov
2012-12-12 14:36 ` Eduardo Habkost
2012-12-14 15:29 ` Andreas Färber
2012-12-14 15:40 ` Paolo Bonzini [this message]
2012-12-14 15:44 ` Andreas Färber
2012-12-14 17:56 ` Eduardo Habkost
2013-01-02 15:08 ` Andreas Färber
2013-01-02 16:40 ` Igor Mammedov
2013-01-02 16:49 ` Eduardo Habkost
2013-01-03 17:36 ` [Qemu-devel] [PATCH 0/8] CPU DeviceState v10 Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CB4851.6040208@redhat.com \
--to=pbonzini@redhat.com \
--cc=Don@CloudSwitch.Com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.