Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*

["Andreas Färber" <afaerber@suse.de>]

Am 05.12.2012 17:49, schrieb Eduardo Habkost:
> This separates the qdev properties code in two parts:
>  - qdev-properties.c, that contains most of the qdev properties code;
>  - qdev-properties-system.c for code specific for qemu-system-*,
>    containing:
>    - Property types: drive, chr, netdev, vlan, that depend on code that
>      won't be included on *-user
>    - qemu_add_globals(), that depends on qemu-config.o.
> 
> This change should help on two things:
>  - Allowing DeviceState to be used by *-user without pulling
>    dependencies that are specific for qemu-system-*;
>  - Writing qdev unit tests without pulling too many dependencies.
> 
> The copyright/license of qdev-properties.c isn't explicitly stated at
> the file, so add a simple copyright/license header pointing to the
> commit ID of the original file.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

I dropped a trailing white line in qdev-properties-system.c; otherwise
it passed checkpatch.pl cleanly now. I verified that nothing got lost or
accidentally changed during the code movement.

Thanks, applied to qom-cpu queue:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg