From: "Christian König" <deathsimple@vodafone.de>
To: Jerome Glisse <j.glisse@gmail.com>
Cc: Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: resume fence driver to last sync sequence on lockup
Date: Mon, 17 Dec 2012 10:11:23 +0100 [thread overview]
Message-ID: <50CEE1BB.7090500@vodafone.de> (raw)
In-Reply-To: <CAH3drwbbJMvLn-FkSpyVZWLwh857ceeGaVHPDv2e+=6A75Abtw@mail.gmail.com>
On 14.12.2012 21:33, Jerome Glisse wrote:
> On Fri, Dec 14, 2012 at 3:13 PM, Christian König
> <deathsimple@vodafone.de> wrote:
>> On 14.12.2012 18:39, j.glisse@gmail.com wrote:
>>> From: Jerome Glisse <jglisse@redhat.com>
>>>
>>> After lockup we need to resume fence to last sync sequence and not
>>> last received sequence so that all thread waiting on command stream
>>> that lockedup resume. Otherwise GPU reset will be ineffective in most
>>> cases.
>> NAK. I changed this on purpose to get partial resets working, please don't
>> change it back.
>>
>> The IB test code should reset this to the last synced value anyway, if it
>> doesn't work then there is something wrong there.
>>
>> Christian.
> There is something wrong ....
What symptoms? What exactly is going wrong?
Thinking about it the sequence probably won't get reseted when we
encounter a unrecoverable GPU lockup. And even when the partial GPU
reset fails it might be a good idea to reset the fence sequence like
this....
Ok, you're right there is something wrong. Going to write a patch for
this...
Cheers,
Christian.
next prev parent reply other threads:[~2012-12-17 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 17:39 [PATCH] drm/radeon: resume fence driver to last sync sequence on lockup j.glisse
2012-12-14 20:13 ` Christian König
2012-12-14 20:33 ` Jerome Glisse
2012-12-17 9:11 ` Christian König [this message]
2012-12-17 15:23 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CEE1BB.7090500@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
--cc=jglisse@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.