From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: OMAP: Split vrfb.c to remove last remaining cpu_is_omap usage
Date: Mon, 17 Dec 2012 11:31:08 +0200 [thread overview]
Message-ID: <50CEE65C.20009@ti.com> (raw)
In-Reply-To: <20121216200314.24238.9481.stgit@muffinssi.local>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On 2012-12-16 22:03, Tony Lindgren wrote:
> Looks like we missed plat-omap/fb.c for cpu_is_omap usage
> mach-omap2. This is the last user of cpu_is_omap, so let's
> quickly fix it up so we can finally remove plat/cpu.h for
> omap2lus.
>
> We want to limit cpu_is_omap macro usage to mach-omap2 only so
> we can make plat/cpu.h private. After this we can finally drop
> plat/cpu.h for omap2+.
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap1/Makefile | 2 +
> arch/arm/mach-omap1/fb.c | 80 ++++++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-omap2/Makefile | 2 +
> arch/arm/mach-omap2/fb.c | 50 +-------------------------
> arch/arm/plat-omap/Makefile | 2 +
> 5 files changed, 85 insertions(+), 51 deletions(-)
> create mode 100644 arch/arm/mach-omap1/fb.c
> rename arch/arm/{plat-omap/fb.c => mach-omap2/fb.c} (76%)
Ok, I didn't realize that plat-omap cannot refer to cpu_is_omap either.
The patch looks fine, except the subject should say "split fb.c", not
"split vrfb.c".
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: OMAP: Split vrfb.c to remove last remaining cpu_is_omap usage
Date: Mon, 17 Dec 2012 11:31:08 +0200 [thread overview]
Message-ID: <50CEE65C.20009@ti.com> (raw)
In-Reply-To: <20121216200314.24238.9481.stgit@muffinssi.local>
On 2012-12-16 22:03, Tony Lindgren wrote:
> Looks like we missed plat-omap/fb.c for cpu_is_omap usage
> mach-omap2. This is the last user of cpu_is_omap, so let's
> quickly fix it up so we can finally remove plat/cpu.h for
> omap2lus.
>
> We want to limit cpu_is_omap macro usage to mach-omap2 only so
> we can make plat/cpu.h private. After this we can finally drop
> plat/cpu.h for omap2+.
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap1/Makefile | 2 +
> arch/arm/mach-omap1/fb.c | 80 ++++++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-omap2/Makefile | 2 +
> arch/arm/mach-omap2/fb.c | 50 +-------------------------
> arch/arm/plat-omap/Makefile | 2 +
> 5 files changed, 85 insertions(+), 51 deletions(-)
> create mode 100644 arch/arm/mach-omap1/fb.c
> rename arch/arm/{plat-omap/fb.c => mach-omap2/fb.c} (76%)
Ok, I didn't realize that plat-omap cannot refer to cpu_is_omap either.
The patch looks fine, except the subject should say "split fb.c", not
"split vrfb.c".
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121217/f46adcb7/attachment.sig>
next prev parent reply other threads:[~2012-12-17 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 20:03 [PATCH 0/2] drop plat/cpu.h for omap2plus Tony Lindgren
2012-12-16 20:03 ` Tony Lindgren
2012-12-16 20:03 ` [PATCH 1/2] ARM: OMAP: Split vrfb.c to remove last remaining cpu_is_omap usage Tony Lindgren
2012-12-16 20:03 ` Tony Lindgren
2012-12-17 9:31 ` Tomi Valkeinen [this message]
2012-12-17 9:31 ` Tomi Valkeinen
2012-12-17 17:19 ` Tony Lindgren
2012-12-17 17:19 ` Tony Lindgren
2012-12-16 20:03 ` [PATCH 2/2] ARM: OMAP2+: Drop plat/cpu.h for omap2plus Tony Lindgren
2012-12-16 20:03 ` Tony Lindgren
2012-12-17 9:04 ` Laurent Pinchart
2012-12-17 9:04 ` Laurent Pinchart
2012-12-17 10:48 ` Jean Pihet
2012-12-17 10:48 ` Jean Pihet
2012-12-17 14:59 ` Mauro Carvalho Chehab
2012-12-17 14:59 ` Mauro Carvalho Chehab
2012-12-20 6:42 ` [PATCH 0/2] drop " Santosh Shilimkar
2012-12-20 6:42 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CEE65C.20009@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.